[osumoclement]

I suggest making your intended edits to that PR, so the developers don't need to review the two PR's for the addon.

Sure, will do

[osumoclement]

Code:

I tried this on CoreELEC / Kodi20 and unfortunately, it throws an error:

I encounter the same error when I try running the addon on Kodinerds build (which has support for MKV Dolby Vision). If you check the log just above the exception, you'll probably see this error:xbmc CRenderManager::Capture - unknown capture id: 0

If you check RenderManager.cpp it defines the capture ID as 0 by default unsigned int CRenderManager::m_nextCaptureId = 0;. It seems in LibreElec and other non-vanilla Kodi the capture ID is not zero, and the frame captured is empty leading to index out of range. The actual block where the error is thrown is this:

cpp:


it = m_captures.find(captureId);

if (it == m_captures.end())

{

CLog::Log(LOGERROR, "CRenderManager::Capture - unknown capture id: {}", captureId);

return;

}

I do not yet know what CaptureID is and why it's different in non-Vanilla Kodi versions, but this is something I am keen to solve and hopefully if anyone has some insights on this I would appreciate

[Karellen]

It seems in LibreElec and other non-vanilla Kodi the capture ID is not zero

Maybe @lrusak might be able to help there

[HeresJohnny]

I opened a thread over at the CoreELEC forums and got an initial response.

[osumoclement]

I opened a thread over at the CoreELEC forums and got an initial response.

Fantastic, that's a good start. I will do some tinkering today and see what happens

[osumoclement]

I tried this on CoreELEC / Kodi20 and unfortunately, it throws an error:

I have something which *could* work on CoreELEC. Go to Kodi Settings -> Player -> Check Allow Hardware Acceleration MediaCodec (Surface) -> Uncheck Allow Hardware Acceleration MediaCodec

Once this is done, play a (preferably HDR) video with hard coded black bars and see if the addon works

[HeresJohnny]

What you describe seem to be Android options. However, CoreELEC is mostly Linux based for AML chips and doesn't have those options if memory serves right. I'll check in a few to be sure, though.

[osumoclement]

What you describe seem to be Android options. However, CoreELEC is mostly Linux based for AML chips and doesn't have those options

Ah, I see. I will try to install CoreELEC on a USB (if that's even possible) and see what I can find

[osumoclement]

@HeresJohnny I installed LibreELEC (which is similar to CoreELEC) on USB for live use on my computer, and the addon worked. I have increased the frame capture delay time and you can get the updated addon zip here. Try it and if it doesn't work that means there's some sort of setting in CoreELEC that's responsible (maybe hardware acceleration), and I will figure out how to fix it

[Pienoet]

@HeresJohnny I installed LibreELEC (which is similar to CoreELEC) on USB for live use on my computer, and the addon worked. I have increased the frame capture delay time and you can get the updated addon zip here. Try it and if it doesn't work that means there's some sort of setting in CoreELEC that's responsible (maybe hardware acceleration), and I will figure out how to fix it

I just tried this on my ODROID N2 running the latest coreelec 19 and it works great. I tested with some movies and it works. How about that zooming is the any picture quality lost. How does the zooming works? In kodi you can also zoom untill the blackbars are gone.

[osumoclement]

I just tried this on my ODROID N2 running the latest coreelec 19 and it works great. I tested with some movies and it works. How about that zooming is the any picture quality lost

Wonderful to hear that it works on your CoreELEC setup Technically, there is some quality lost as the picture is stretched up and new pixels created to cover the new area. However, its not enough to be noticeable. It could be argued that having black bars is picture distortion in itself, and to me that's much worse than the miniscule effect zooming has.

It actually works by zooming until the black bars are gone, just as you'd do manually on Kodi. The difference is, this addon does it automatically for you - you don't have to do anything. Any time you watch anything, it will fill the screen as soon as you click play.

[Pienoet]

I just tried this on my ODROID N2 running the latest coreelec 19 and it works great. I tested with some movies and it works. How about that zooming is the any picture quality lost

Wonderful to hear that it works on your CoreELEC setup Technically, there is some quality lost as the picture is stretched up and new pixels created to cover the new area. However, its not enough to be noticeable. It could be argued that having black bars is picture distortion in itself, and to me that's much worse than the miniscule effect zooming has.

It actually works by zooming until the black bars are gone, just as you'd do manually on Kodi. The difference is, this addon does it automatically for you - you don't have to do anything. Any time you watch anything, it will fill the screen as soon as you click play.

Can you tell me the percentage when the zooming kicks in?
Bc i noticed with the handmaid's tale that has small black bars and nothing happends or is it only working with movies?

[osumoclement]

Can you tell me the percentage when the zooming kicks in?
Bc i noticed with the handmaid's tale that has small black bars and nothing happends or is it only working with movies?

The addon notifies you of the amount it has zoomed. It works on any kind of video, including TV shows and movies. What episode is this that has small black bars?

[HeresJohnny]

I just tried this on my ODROID N2 running the latest coreelec 19 and it works great. I tested with some movies and it works. How about that zooming is the any picture quality lost. How does the zooming works? In kodi you can also zoom untill the blackbars are gone.

Lucky you, it still doesn't work for me:

python:
2022-10-12 19:52:58.054 T:3824     info <general>: Starting Kodi (20.0-ALPHA3 (19.90.710) Git:0db3de0508d0c62143280c66186a8a90298cfc85). Platform: Linux ARM 32-bit

2022-10-12 19:52:58.054 T:3824     info <general>: Using Release Kodi x32

2022-10-12 19:52:58.054 T:3824     info <general>: Kodi compiled 2022-10-07 by GCC 12.2.0 for Linux ARM 32-bit version 4.9.255 (264703)

2022-10-12 19:52:58.054 T:3824     info <general>: Running on Hardkernel ODROID-N2Plus with CoreELEC (official): 20.0-Nexus_nightly_20221007, kernel: Linux ARM 64-bit version 4.9.269

2022-10-12 19:52:58.054 T:3824     info <general>: FFmpeg version/source: 4.4.1-Nexus-Alpha1-Kodi

2022-10-12 19:52:58.054 T:3824     info <general>: Host CPU: Amlogic S922X rev b, 6 cores available

2022-10-12 19:52:58.054 T:3824     info <general>: ARM Features: Neon enabled

[...]

2022-10-12 21:56:38.157 T:3824     info <general>: Loading skin file: VideoFullScreen.xml, load type: KEEP_IN_MEMORY

2022-10-12 21:56:38.165 T:3824     info <general>: [WHITELIST] Searching the whitelist for: width: 1920, height: 1080, fps: 24.000, 3D: false

2022-10-12 21:56:38.166 T:3824     info <general>: Display resolution ADJUST : 4096x2160 @ 24.00 - Full Screen (16) (weight: 0.000)

2022-10-12 21:56:38.177 T:4153     info <general>: Interim Aspect Ratio = 178

2022-10-12 21:56:38.178 T:4153    error <general>: CRenderManager::Capture - unknown capture id: 0

2022-10-12 21:56:38.178 T:4153     info <general>: Interim Aspect Ratio = 178

2022-10-12 21:56:38.195 T:4153    error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                                   Error Type: <class 'IndexError'>

                                                   Error Contents: bytearray index out of range

                                                   Traceback (most recent call last):

                                                     File "/storage/.kodi/addons/script.black.bars.never/addon.py", line 38, in onAVStarted

                                                       self.abolishBlackBars()

                                                     File "/storage/.kodi/addons/script.black.bars.never/addon.py", line 117, in abolishBlackBars

                                                       aspectratio = self.GetAspectRatioFromFrame()

                                                     File "/storage/.kodi/addons/script.black.bars.never/addon.py", line 91, in GetAspectRatioFromFrame

                                                       __middleScreenDark = self.LineColorLessThan(

                                                     File "/storage/.kodi/addons/script.black.bars.never/addon.py", line 62, in LineColorLessThan

                                                       _bArray[i] &= 0x00

                                                   IndexError: bytearray index out of range

                                                   -->End of Python script error report<--

                                                   

2022-10-12 21:56:38.408 T:4183     info <general>: Closing stream player 3

2022-10-12 21:56:38.408 T:4183     info <general>: Opening stream: 0 source: 1024

2022-10-12 21:56:38.537 T:4183     info <general>: CDVDSubtitlesLibass: Using libass version 1600000

2022-10-12 21:56:38.537 T:4183     info <general>: CDVDSubtitlesLibass: Creating ASS library structure

2022-10-12 21:56:38.537 T:4183     info <general>: CDVDSubtitlesLibass: Initializing ASS Renderer

2022-10-12 21:56:38.537 T:4183     info <general>: CDVDSubtitlesLibass: Initializing ASS library font settings

2022-10-12 21:56:38.561 T:4183     info <general>: CDVDSubtitlesLibass: Creating new ASS track

I guess either the renderer works differently in Kodi 20 or the resolution is too high.

[osumoclement]

Lucky you, it still doesn't work for me:

Try disabling hardware acceleration and see if it works