Kodi Community Forum
Beta Simple Favourites - defeats addons that hide the context menu - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Beta Simple Favourites - defeats addons that hide the context menu (/showthread.php?tid=293511)

Pages: 1 2 3 4 5 6 7 8 9 10 11

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

I mean SF does insert the ActivateWindow command in nearly every favorite it makes:

<favourite name="TV Shows" thumb="special://home/addons/backgrounds/TV Shows.jpg">ActivateWindow(10025,&quot;library://video/tvshows/titles.xml/?sf_options=meta%3Dlabel%253DTitle%26_options_sf&quot;,return)</favourite>
    <favourite name="Movies" thumb="special://home/addons/backgrounds/Movies.jpg">ActivateWindow(10025,&quot;library://video/movies/titles.xml/?sf_options=meta%3Dlabel%253DTitle%26_options_sf&quot;,return)</favourite>
</favourites>

RE: Simple Favourites - defeats addons that hide the context menu - trogggy - 2018-11-10

@ primaeval:
Just tried this on leia and found I can't open a smart playlist or folder from simple favourites.  It works perfectly in krypton.

I tried a fresh leia install.  Added a small library, a couple of playlists and simple favourites.
Added both playlists to favourites.
Added both playlists to simple favourites, both directly (following the video library prompt) and via the existing favourites.
None of the links work in simple favourites, the 2 in favourites open the smart playlists as expected.
Added a couple of folders to favourites.  They open fine.
Added them to simple favourites.  They don't open.

All these favourites work via 'ActivateWindow(videos...' or 'ActivateWindow(10025,...'

I've posted my favourites.xml, the favourites.xml from simple favs and a debug log.  If I can do anything else to help debug please let me know.
Thanks for a really useful addon btw.  I don't need the ActivateWindow function at the moment, just jumping up and down pointing at the error.
https://pastebin.com/Y6vLDyvL

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-11-10

(2018-11-10, 00:20)trogggy Wrote: @ primaeval:
Just tried this on leia and found I can't open a smart playlist or folder from simple favourites.  It works perfectly in krypton.

I tried a fresh leia install.  Added a small library, a couple of playlists and simple favourites.
Added both playlists to favourites.
Added both playlists to simple favourites, both directly (following the video library prompt) and via the existing favourites.
None of the links work in simple favourites, the 2 in favourites open the smart playlists as expected.
Added a couple of folders to favourites.  They open fine.
Added them to simple favourites.  They don't open.

All these favourites work via 'ActivateWindow(videos...' or 'ActivateWindow(10025,...'

I've posted my favourites.xml, the favourites.xml from simple favs and a debug log.  If I can do anything else to help debug please let me know.
Thanks for a really useful addon btw.  I don't need the ActivateWindow function at the moment, just jumping up and down pointing at the error.
https://pastebin.com/Y6vLDyvL
 Thanks.
Playing a PlayMedia link crashes Kodi for me on Leia.
Something has been changed in the Kodi core.
I'll have to file a bug report if I can't work out what they've done.
[EDIT] I made a bug report here. https://github.com/xbmc/xbmc/issues/14838

If you just want video links, have you tried my "Video Favourites" addon?

I did find a way to fix Super Favourites too if that helps.
https://forum.kodi.tv/showthread.php?tid=293511&pid=2783510#pid2783510

RE: Simple Favourites - defeats addons that hide the context menu - trogggy - 2018-11-10

@ primaeval
Thanks for replying. 
I took another look today, and it looks like simplefavs won't open any 'ActivateWindow' links in leia.

I tried a very simple example that just opens the file manager window:
Quote:<favourite name="File Manager" >ActivateWindow(10003,return)</favourite>
Added that to favourites and simplefavs in a clean (except for confluence) leia install.
Running from favourites works as expected, from simplefavs nothing happens.
In the log I'm hitting the button in simplefavs at 13:21:00:
https://pastebin.com/9HZqJ8S8
Repeated with a clean krypton, this time file manager window opens from simplefavs (though there are still some errors in the log).
This time I'm hitting the simplefavs button at 13:34:03:
https://pastebin.com/Nag4365Z

Hope this is of some use - I'm not desperate for a solution, just trying to help with debugging.
Cheers.

RE: Simple Favourites - defeats addons that hide the context menu - effe.rnr - 2019-01-15

Hi,
I tried the addon with Kodi 18 RC5 on NVidia Shield/Android, but I can't add folders. If I choose "add" I can name the folder but when I submit, the folder isn't there.

Would be happy if you could fix that.
thanks!

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2019-01-15

(2019-01-15, 03:01)effe.rnr Wrote: Hi,
I tried the addon with Kodi 18 RC5 on NVidia Shield/Android, but I can't add folders. If I choose "add" I can name the folder but when I submit, the folder isn't there.

Would be happy if you could fix that.
thanks!
 You'll have to tell me more. Are you using a special Kodi skin.
It still works on 18RC5.2 Windows. You might need to exit the addon to refresh the folder listing.
However it will crash when you play a link. I opened a bug report here https://github.com/xbmc/xbmc/issues/14838
Have you tried Video Favourites?

RE: Simple Favourites - defeats addons that hide the context menu - effe.rnr - 2019-01-15

okay, today the folders are there. Maybe the restart of the shield triggered that.

Thanks anyway!

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2019-01-29

(2018-10-17, 19:21)jdig4240 Wrote:
(2018-10-17, 17:08)primaeval Wrote: Here is a bodge for SF that lets you play folders from SF.
I don't know why the rest of the function is so complicated but there must be a reason.
So don't expect this to work in every case.

https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a

SF fails on the last function of activateWindowCommand
Code:
xbmc.executebuiltin('Container.Update(%s)' % plugin)
 YESSSSSS! That definitely fixed the SF folders. They now open!! You da man! So what bugs do you expect there still might be?? Either way, ill check it out some more and test some various functions and ill let you know if i see anything unusual. Really appreciate it P! 
Ok, so this SF fix  has been working well so far. The only bug i notice is clicking back no longer goes back one to previous folder. It goes all the way back to the home menu or out of SF.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2019-01-29

(2019-01-29, 01:53)jdig4240 Wrote:
(2018-10-17, 19:21)jdig4240 Wrote:
(2018-10-17, 17:08)primaeval Wrote: Here is a bodge for SF that lets you play folders from SF.
I don't know why the rest of the function is so complicated but there must be a reason.
So don't expect this to work in every case.

https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a

SF fails on the last function of activateWindowCommand
Code:
xbmc.executebuiltin('Container.Update(%s)' % plugin)
 YESSSSSS! That definitely fixed the SF folders. They now open!! You da man! So what bugs do you expect there still might be?? Either way, ill check it out some more and test some various functions and ill let you know if i see anything unusual. Really appreciate it P!  
Ok, so this SF fix  has been working well so far. The only bug i notice is clicking back no longer goes back one to previous folder. It goes all the way back to the home menu or out of SF. 
That's probably what the rest of the code that I commented out does.
https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a
I can't do anything about it until Kodi fix the bug I mentioned earlier.

RE: Simple Favourites - defeats addons that hide the context menu - amerikiwians - 2019-05-05

(2019-01-29, 10:43)primaeval Wrote: [quote="jdig4240" pid='2813671' dateline='1548719623']
[quote="jdig4240" pid='2783549' dateline='1539796911']
I can't do anything about it until Kodi fix the bug I mentioned earlier.

Hi,

I noticed someone else was having a similar issue with KODI 18 not opening xbmc.executebuiltin('ActivateWindow commands here https://forum.kodi.tv/showthread.php?tid=340954.

Seems that closing busy dialogs before executing activate window worked for their issue.

Is this a possible solution for the Simple Favorites issue or is it still a Kodi Core bug?

If this won't help please disregard.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2019-05-05

(2019-05-05, 17:02)amerikiwians Wrote:
(2019-01-29, 10:43)primaeval Wrote:
(2019-01-29, 01:53)jdig4240 Wrote:
(2018-10-17, 19:21)jdig4240 Wrote: I can't do anything about it until Kodi fix the bug I mentioned earlier.

Hi,

I noticed someone else was having a similar issue with KODI 18 not opening xbmc.executebuiltin('ActivateWindow commands here https://forum.kodi.tv/showthread.php?tid=340954.

Seems that closing busy dialogs before executing activate window worked for their issue.

Is this a possible solution for the Simple Favorites issue or is it still a Kodi Core bug?

If this won't help please disregard.
 

Thank's for that.
I came across that dialog close issue when I was making IPTV Recorder.
It could well be the solution to Super Favourites.

Could you see if this change fixes Super Favourites.
https://github.com/primaeval/spoyser-repo/commit/506f8498b45563cda457bf70529fb0707b7b869a
I can't remember how to use Super Favourites now.
The fix will close all dialog windows according to this.
https://kodi.wiki/view/List_of_built-in_functions

RE: Simple Favourites - defeats addons that hide the context menu - amerikiwians - 2019-05-18

(2019-05-05, 18:04)primaeval Wrote:
(2019-05-05, 17:02)amerikiwians Wrote:
(2019-01-29, 10:43)primaeval Wrote:  

Thank's for that.
I came across that dialog close issue when I was making IPTV Recorder.
It could well be the solution to Super Favourites.

Could you see if this change fixes Super Favourites.
https://github.com/primaeval/spoyser-repo/commit/506f8498b45563cda457bf70529fb0707b7b869a
I can't remember how to use Super Favourites now.
The fix will close all dialog windows according to this.
https://kodi.wiki/view/List_of_built-in_functions 

Sorry,

I have not used Super Favorites as I could not figure it out and get it to organise favorites as I wanted. I have been using 'Simple Favourites' for years and love it. Hopefully there will be a way to fix 'Simple Favourites' soon.

RE: Simple Favourites - defeats addons that hide the context menu - Paranoidjack - 2019-09-15

I'm using this with Kodi (Matrix) and I'm attempting to favourite a directory which is hosted on an HTTP server: it successfully adds the favourite, however, when accessing that favourite nothing occurs.

This is the error from the logfile: https://paste.kodi.tv/zehukeboju.kodi

RE: Simple Favourites - defeats addons that hide the context menu - rocko - 2019-10-01

I had to do a fresh install of kodi and now the option to reorder is not there in simple favorites? The settings are all correct. Any ideas?

RE: Simple Favourites - defeats addons that hide the context menu - effe.rnr - 2019-10-02

(2019-10-01, 18:54)rocko Wrote: I had to do a fresh install of kodi and now the option to reorder is not there in simple favorites? The settings are all correct. Any ideas?

I suppose you have enabled "sort" in the addon settings. When you disable it, you should se the move option again.