(2020-06-06, 16:35)jurialmunkey Wrote:

(2020-06-06, 15:26)tripkip Wrote:

(2020-06-06, 09:25)jurialmunkey Wrote: Pressing OK to return was actually the old behaviour for the wall. There was a discussion about it where other users said that was counterintuitive and it should play the item directly...

I'm not sure what you mean by "NL scraped genres"?

Ah ok, that's surprising. I can live with the way it works. [emoji6]

My scraper (TMDB) is set to NL (Dutch). As a result the genre for the movies are imported localized. So 'Animation' becomes 'Animatie'. This in turn causes the genre icon not to show.

I think it is one of those things where what is/isn't intuitive depends on what purpose you're using the wall for. I find if I'm looking for something specific, then I'll expect OK to play immediately from the wall; whereas if I'm just browsing, I expect the opposite. Ultimately I think OK playing directly makes slightly more sense because you still have back to close, whereas if OK closes then there's no button to play directly.

For genres in a different language, you would need to edit the genre image resource addon and change the image filenames to match the Dutch names. The skin just adds ".png" to the genre label to display the genre icon.

(2020-06-06, 05:33)jurialmunkey Wrote:

(2020-06-05, 18:44)FXB78 Wrote: When using PVR sometimes the lookup seems to fail & leaves a blank poster to the left, I would normally see the channel logo here if there is no data instead of this blank poster view. Is this a bug or is there a setting I need to change somewhere?

The poster only displays if TMDbHelper service returns an image URL. The issue is that it's up to Kodi to retrieve the actual image from the URL when it is referenced in the skin (once the image loads, Kodi caches it in the texture cache so it doesn't have to look it up from the URL again).

A few things can cause this issue:
1. Kodi simply hasn't retrieved and loaded the image into the texture cache yet due to a backlog in the background image loader (most likely).
2. TMDb/FanartTV image server is down/slow (or internet connection is down/slow) (also possible).
3. Malformed or incorrect URL (unlikely)

There's no much that can be done from the skin side. The skin can't check if the image exists, it can only check that a URL was specified by checking if this condition is true or false: String.IsEmpty(Window(Home).Property(TMDbHelper.ListItem.Poster))

(2020-06-06, 09:19)jurialmunkey Wrote:

(2020-06-05, 16:57)Edworld Wrote: If I move down from movie to alphabet strip and back up it trigger the filter screen. Is this by design?

Definitely not intentional. What view is this happening in? Are you sure you aren't pressing down twice

(2020-06-06, 17:58)wsx1 Wrote:

(2020-06-06, 16:35)jurialmunkey Wrote:

(2020-06-06, 15:26)tripkip Wrote: Ah ok, that's surprising. I can live with the way it works. [emoji6]

My scraper (TMDB) is set to NL (Dutch). As a result the genre for the movies are imported localized. So 'Animation' becomes 'Animatie'. This in turn causes the genre icon not to show.

I think it is one of those things where what is/isn't intuitive depends on what purpose you're using the wall for. I find if I'm looking for something specific, then I'll expect OK to play immediately from the wall; whereas if I'm just browsing, I expect the opposite. Ultimately I think OK playing directly makes slightly more sense because you still have back to close, whereas if OK closes then there's no button to play directly.

For genres in a different language, you would need to edit the genre image resource addon and change the image filenames to match the Dutch names. The skin just adds ".png" to the genre label to display the genre icon.

Can you give and example and the path for the "genre" edit?.
I have the same problem because my language is Italian

(2020-06-06, 18:21)FXB78 Wrote:

(2020-06-06, 05:33)jurialmunkey Wrote:

(2020-06-05, 18:44)FXB78 Wrote: When using PVR sometimes the lookup seems to fail & leaves a blank poster to the left, I would normally see the channel logo here if there is no data instead of this blank poster view. Is this a bug or is there a setting I need to change somewhere?

The poster only displays if TMDbHelper service returns an image URL. The issue is that it's up to Kodi to retrieve the actual image from the URL when it is referenced in the skin (once the image loads, Kodi caches it in the texture cache so it doesn't have to look it up from the URL again).

A few things can cause this issue:
1. Kodi simply hasn't retrieved and loaded the image into the texture cache yet due to a backlog in the background image loader (most likely).
2. TMDb/FanartTV image server is down/slow (or internet connection is down/slow) (also possible).
3. Malformed or incorrect URL (unlikely)

There's no much that can be done from the skin side. The skin can't check if the image exists, it can only check that a URL was specified by checking if this condition is true or false: String.IsEmpty(Window(Home).Property(TMDbHelper.ListItem.Poster))

If the image hasn't been loaded into the texture cache would you expect the image to show say, 5 minutes later for example? These images never display, but for whatever reason it only happens on certain shows.

From what I can see in the Debug log a failure gives the warning DEBUG: [Warning] CGUITextureManager::GetTexturePath: could not find texture 'None' which I think seems to indicate there is no image to load in the first place?

EDIT - I dug out an old version of TMDBHelper, ver 2.4.0 and it doesn't give me this behaviour, it displays the channel logo square as I would expect if there is no image. So it appears somewhere between 2.4.0 & 2.4.36 of TMDB Helper there has been a change which has caused these Blank Poster views. See screenshots demonstrating this below:

(2020-06-06, 18:53)Edworld Wrote:

(2020-06-06, 09:19)jurialmunkey Wrote:

(2020-06-05, 16:57)Edworld Wrote: If I move down from movie to alphabet strip and back up it trigger the filter screen. Is this by design?

Definitely not intentional. What view is this happening in? Are you sure you aren't pressing down twice

I didn't know they were different views....

Yes you are correct, if you move down twice... and I know why I do it twice. The first movie in my collection is (500) days of summer. I guess the skin / alphabet strip doesn't know what to do with ( and nothing gets highlighted. That is how I end up pressing down twice waiting for something to get highlighted.

(2020-06-07, 12:22)hacky4real Wrote: Kiosk mode is enabled but view options can be changed; is there a way they can be locked?

(2020-06-07, 09:41)jurialmunkey Wrote:

(2020-06-06, 18:21)FXB78 Wrote:

(2020-06-06, 05:33)jurialmunkey Wrote: The poster only displays if TMDbHelper service returns an image URL. The issue is that it's up to Kodi to retrieve the actual image from the URL when it is referenced in the skin (once the image loads, Kodi caches it in the texture cache so it doesn't have to look it up from the URL again).

A few things can cause this issue:
1. Kodi simply hasn't retrieved and loaded the image into the texture cache yet due to a backlog in the background image loader (most likely).
2. TMDb/FanartTV image server is down/slow (or internet connection is down/slow) (also possible).
3. Malformed or incorrect URL (unlikely)

There's no much that can be done from the skin side. The skin can't check if the image exists, it can only check that a URL was specified by checking if this condition is true or false: String.IsEmpty(Window(Home).Property(TMDbHelper.ListItem.Poster))

If the image hasn't been loaded into the texture cache would you expect the image to show say, 5 minutes later for example? These images never display, but for whatever reason it only happens on certain shows.

From what I can see in the Debug log a failure gives the warning DEBUG: [Warning] CGUITextureManager::GetTexturePath: could not find texture 'None' which I think seems to indicate there is no image to load in the first place?

EDIT - I dug out an old version of TMDBHelper, ver 2.4.0 and it doesn't give me this behaviour, it displays the channel logo square as I would expect if there is no image. So it appears somewhere between 2.4.0 & 2.4.36 of TMDB Helper there has been a change which has caused these Blank Poster views. See screenshots demonstrating this below:

Okay, yep that's definitely a bug -- it is option 3 (incorrect url) after all! Looks like there was some regression somewhere and if the URL has a None value it is being added as literal "None" rather than an empty value.

I'll see if I can find the cause and get back to you.

(2020-06-07, 13:58)FXB78 Wrote:

(2020-06-07, 09:41)jurialmunkey Wrote:

(2020-06-06, 18:21)FXB78 Wrote: If the image hasn't been loaded into the texture cache would you expect the image to show say, 5 minutes later for example? These images never display, but for whatever reason it only happens on certain shows.

From what I can see in the Debug log a failure gives the warning DEBUG: [Warning] CGUITextureManager::GetTexturePath: could not find texture 'None' which I think seems to indicate there is no image to load in the first place?

EDIT - I dug out an old version of TMDBHelper, ver 2.4.0 and it doesn't give me this behaviour, it displays the channel logo square as I would expect if there is no image. So it appears somewhere between 2.4.0 & 2.4.36 of TMDB Helper there has been a change which has caused these Blank Poster views. See screenshots demonstrating this below:

Okay, yep that's definitely a bug -- it is option 3 (incorrect url) after all! Looks like there was some regression somewhere and if the URL has a None value it is being added as literal "None" rather than an empty value.

I'll see if I can find the cause and get back to you.

Thanks, after trying a few old versions I narrowed it down to the update from 2.4.27 to 2.4.28 and more specifically it seems to be this commit which started the issue https://github.com/jurialmunkey/plugin.video.themoviedb.helper/commit/f115347a26f30b95f13e18899a0bd318116bada0. Hopefully that will help you to get to the bottom of it

(2020-06-07, 16:38)jurialmunkey Wrote:

(2020-06-07, 13:58)FXB78 Wrote:

(2020-06-07, 09:41)jurialmunkey Wrote: Okay, yep that's definitely a bug -- it is option 3 (incorrect url) after all! Looks like there was some regression somewhere and if the URL has a None value it is being added as literal "None" rather than an empty value.

I'll see if I can find the cause and get back to you.

Thanks, after trying a few old versions I narrowed it down to the update from 2.4.27 to 2.4.28 and more specifically it seems to be this commit which started the issue https://github.com/jurialmunkey/plugin.video.themoviedb.helper/commit/f115347a26f30b95f13e18899a0bd318116bada0. Hopefully that will help you to get to the bottom of it

Out of interest, if you disable "Get additional details from the local Kodi library database", does that fix it? Just trying to narrow down if the issue is with that or the fanarttv lookup.

(2020-06-07, 16:38)jurialmunkey Wrote: EDIT: Actually can you just test latest git version of TMDbHelper - Hopefully will fix the issue.

(2020-06-07, 13:29)jurialmunkey Wrote:

(2020-06-07, 12:22)hacky4real Wrote: Kiosk mode is enabled but view options can be changed; is there a way they can be locked?

I've hidden the view mode switcher in Kiosk Mode in the latest. Do you think that "Sort by" and "Hide Watched" should also be hidden, or just the view mode switch?


I think just the view mode switch is fine.
Thanks 

(2020-06-07, 16:50)FXB78 Wrote:

(2020-06-07, 16:38)jurialmunkey Wrote: EDIT: Actually can you just test latest git version of TMDbHelper - Hopefully will fix the issue.

Just tested and unfortunately it's still not fixed.