+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Information Providers (scrapers) (https://forum.kodi.tv/forumdisplay.php?fid=147)
+----- Forum: TV Show Scrapers (https://forum.kodi.tv/forumdisplay.php?fid=305)
+----- Thread: Release TMDb TV Show scraper (Python - Default Matrix Scraper) (/showthread.php?tid=357232)
RE: TMDB TV Show scraper - roby69 - 2021-01-15
(2021-01-15, 01:46)pkscout Wrote: @roby69 @Tobby There is updated code for the TMDb TV Show scrapers that addresses the issues you two brought up.
2- saves Original Title to C09 in the database (which should be able to be referenced by skins)
Works well with kodi 19b2.The original title is correctly exported to the tvshow.nfo .
thank you, you are quick.
RE: TMDB TV Show scraper - pkscout - 2021-01-15
(2021-01-15, 11:44)Tobby Wrote:Thanks for testing. That's a big help.(2021-01-15, 01:46)pkscout Wrote: @roby69 @Tobby There is updated code for the TMDb TV Show scrapers that addresses the issues you two brought up.
1- by default separates landscape art and fanart (with option to disable that and have it all be fanart)
2- saves Original Title to C09 in the database (which should be able to be referenced by skins)
If one or both of you could test the changes before I push them to the main repo, that would be very helpful.
Leia: https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/tree/leia
Matrix: https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/tree/matrix
Tested the Leia version and both your fixes seem to work great. Thanks a lot. That was quick.
Also, sorry to bother you again, but lately when scraping TV shows with Swedish as my preferred language the episode titles don't fall back to English, even though everything else does. Instead they are simply named "Avsnitt 1, 2, 3” and so on (Episode 1, 2, 3 in English).
I tried it with the non Python version and got the same result, so it's not an error in your addon, but perhaps an API change from TMDb? Do you have any clue? This has happened even though there's no Swedish translation for the show at all on TMDb.
On the episode names, there may have been an API change, but it's hard to know. Unfortunately TMDb doesn't pre-announce or announce API changes. There's also a possibility that someone put in a Swedish translation for the episode names with just "Avsnitt 1, 2, 3" as the translation.
RE: TMDB TV Show scraper - pkscout - 2021-01-15
(2021-01-15, 14:39)roby69 Wrote:Thanks for checking. I appreciate it.(2021-01-15, 01:46)pkscout Wrote: @roby69 @Tobby There is updated code for the TMDb TV Show scrapers that addresses the issues you two brought up.
2- saves Original Title to C09 in the database (which should be able to be referenced by skins)
Works well with kodi 19b2.The original title is correctly exported to the tvshow.nfo .
thank you, you are quick.
RE: TMDB TV Show scraper - Tobby - 2021-01-15
(2021-01-15, 18:21)pkscout Wrote:(2021-01-15, 11:44)Tobby Wrote:Thanks for testing. That's a big help.(2021-01-15, 01:46)pkscout Wrote: @roby69 @Tobby There is updated code for the TMDb TV Show scrapers that addresses the issues you two brought up.
1- by default separates landscape art and fanart (with option to disable that and have it all be fanart)
2- saves Original Title to C09 in the database (which should be able to be referenced by skins)
If one or both of you could test the changes before I push them to the main repo, that would be very helpful.
Leia: https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/tree/leia
Matrix: https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/tree/matrix
Tested the Leia version and both your fixes seem to work great. Thanks a lot. That was quick.
Also, sorry to bother you again, but lately when scraping TV shows with Swedish as my preferred language the episode titles don't fall back to English, even though everything else does. Instead they are simply named "Avsnitt 1, 2, 3” and so on (Episode 1, 2, 3 in English).
I tried it with the non Python version and got the same result, so it's not an error in your addon, but perhaps an API change from TMDb? Do you have any clue? This has happened even though there's no Swedish translation for the show at all on TMDb.
On the episode names, there may have been an API change, but it's hard to know. Unfortunately TMDb doesn't pre-announce or announce API changes. There's also a possibility that someone put in a Swedish translation for the episode names with just "Avsnitt 1, 2, 3" as the translation.
No worries. Least I can do.
I just tried it with Firefly, which has no translated episode titles in Swedish, yet the episodes where still named Avsnitt 1, 2, 3.
https://www.themoviedb.org/tv/1437-firefly/season/1?language=sv-SE
RE: TMDB TV Show scraper - Karellen - 2021-01-15
(2021-01-15, 21:17)Tobby Wrote: I just tried it with Firefly, which has no translated episode titles in Swedish, yet the episodes where still named Avsnitt 1, 2, 3.That is what the API is returning...
RE: TMDB TV Show scraper - Tobby - 2021-01-15
(2021-01-15, 22:06)Karellen Wrote:(2021-01-15, 21:17)Tobby Wrote: I just tried it with Firefly, which has no translated episode titles in Swedish, yet the episodes where still named Avsnitt 1, 2, 3.That is what the API is returning...
Well that's annoying. That's the default episode names on TMDB and can't be deleted. Thank you for helping though.
I'll probably have to change the scraping languages for the TV shows in question. As far as I know there's no nfo tag or something like that to set the scraping language, so basically change the language by hand or set up a separate source for the affected shows?
RE: TMDB TV Show scraper - Karellen - 2021-01-15
(2021-01-15, 23:18)Tobby Wrote: Well that's annoying. That's the default episode names on TMDB and can't be deleted. Thank you for helping though.I posted a question at TheMovieDB forums.... https://www.themoviedb.org/talk/60020206cb3084003ed9e30c
RE: TMDB TV Show scraper - Tobby - 2021-01-15
(2021-01-15, 23:31)Karellen Wrote:(2021-01-15, 23:18)Tobby Wrote: Well that's annoying. That's the default episode names on TMDB and can't be deleted. Thank you for helping though.I posted a question at TheMovieDB forums.... https://www.themoviedb.org/talk/60020206cb3084003ed9e30c
Thank you
RE: TMDB TV Show scraper - musera - 2021-01-19
I'm currently in the process of switching to this scraper from the tvdb scraper. Everything scrapes okay and the switch over process should be pretty painless but I'm coming across a problem with one element in my nfo's. My nfo files are pretty simple as they only contain a title, sort title (sometimes), tags (sometimes), named seasons, a bunch of unique id's and finally a link the correct page to get the rest of the information. To change scraper all I've had to do is change the link from tvdb to tmdb, which I just wrote a script that scanned through all my nfo's and automatically changed the link. I've (double) checked the nfo's and everything is correct.
So the problem is simple, scanning in named seasons doesn't work. So unless tmdb has named the seasons then it'll end up named "Season 1" instead of whatever I named it. Though I know the element is being scanned in correctly because I always include a "Season 99" which I always use namedseason to call it "OP/ED". I have to assume the scraper is overwriting the season names but can't overwrite season 99 as it doesn't exist (hence why I use it).
Here is an example nfo to show more clearly what I am talking about:Thanks for any help you can give.
xml:<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<tvshow>
<title>Arakawa Under the Bridge</title>
<namedseason number="1">Arakawa Under the Bridge</namedseason> <!-- When scanned in this ends up named "Season 1" -->
<namedseason number="2">Arakawa Under the Bridge x Bridge</namedseason> <!-- When scanned in this ends up named "Season 2" -->
<namedseason number="99">OP/ED</namedseason> <!-- This season doesn't exist on tmdb so when scanned in the season is named "OP/ED" -->
<uniqueid default="false" type="tmdb">35423</uniqueid>
<uniqueid default="false" type="tvrage">25620</uniqueid>
<uniqueid default="false" type="imdb">tt1639471</uniqueid>
<uniqueid default="true" type="tvdb">143271</uniqueid>
</tvshow>
https://www.themoviedb.org/tv/35423
Thanks for any help you can give me
RE: TMDB TV Show scraper - Karellen - 2021-01-19
I don't know if this will work, but can you try the following as a test...
xml:<namedseason number="1" clear="true">Arakawa Under the Bridge</namedseason>
RE: TMDB TV Show scraper - musera - 2021-01-19
(2021-01-19, 02:01)Karellen Wrote: I don't know if this will work, but can you try the following as a test...
xml:<namedseason number="1" clear="true">Arakawa Under the Bridge</namedseason>
Gave it a go on a couple of different shows and it did nothing.
RE: TMDB TV Show scraper - Karellen - 2021-01-19
(2021-01-19, 02:16)musera Wrote: Gave it a go on a couple of different shows and it did nothing.I don't think this is a scraper issue, as none of the scrapers I tested loaded that namedseason at all if it is a part of a Combination NFO. If I use just a normal Metadata NFO, then it works.
This seems to be the scanner and Kodi core that is loading it this way. Even though the named season is identified in the log, I could not catch it being loaded or overwritten in the database.
Wait a couple of days to see if a developer has a comment, if not then submit an Issue report on Github and I will come along and confirm your bug.
RE: TMDB TV Show scraper - musera - 2021-01-19
(2021-01-19, 02:44)Karellen Wrote: I don't think this is a scraper issue, as none of the scrapers I tested loaded that namedseason at all if it is a part of a Combination NFO. If I use just a normal Metadata NFO, then it works.
This seems to be the scanner and Kodi core that is loading it this way. Even though the named season is identified in the log, I could not catch it being loaded or overwritten in the database.
The tvdb scraper worked fine using namedseason with a combination nfo, I've been using that successfully for quite some time. If it weren't going the paid API route (which I don't mind paying for but I believe many people will abandon ship and the quality of information will go down) then I would have happily stayed with that scraper.
Quote:Wait a couple of days to see if a developer has a comment, if not then submit an Issue report on Github and I will come along and confirm your bug.
Thanks for that, I'll probably wait a week-ish before going that route.
RE: TMDB TV Show scraper - Karellen - 2021-01-19
(2021-01-19, 04:24)musera Wrote: The tvdb scraper worked fine using namedseason with a combination nfo, I've been using that successfully for quite some time.Ah, ok. I did not test TVDB as I was using v19 and there is no TVDB scraper for v19.
I tried with v18 and TVDB with the TVDB link and you are dead right. It does work.
Maybe the scraper developer @pkscout might spot what the issue is. Log here... https://paste.kodi.tv/opuqojusog.kodi
RE: TMDB TV Show scraper - pkscout - 2021-01-19
(2021-01-19, 04:46)Karellen Wrote:I can't see anything in that log that I understand. It has a mix of TVDB and TMDb scraping, so I'm never sure if the line I'm looking at is regarding the TVDB scraper or the TMDB one. So to start, it would be helpful to have a log that has just TMDb stuff in it. I honestly haven't looked with any detail at how Kodi deals with mixed nfo files, and I didn't even know there was such a thing as a named season. I think I might know where the scraper is assigning a season name, but if this is the result of what I think it might be, it's going to take awhile for me to figure out how to ask Kodi if there's already a named season defined.(2021-01-19, 04:24)musera Wrote: The tvdb scraper worked fine using namedseason with a combination nfo, I've been using that successfully for quite some time.Ah, ok. I did not test TVDB as I was using v19 and there is no TVDB scraper for v19.
I tried with v18 and TVDB with the TVDB link and you are dead right. It does work.
Maybe the scraper developer @pkscout might spot what the issue is. Log here... https://paste.kodi.tv/opuqojusog.kodi