+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Amber (https://forum.kodi.tv/forumdisplay.php?fid=203)
+---- Thread: Release Amber for Leia/Matrix/Nexus (/showthread.php?tid=342130)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
RE: Amber for Leia - bsoriano - 2019-04-10
Thank you all that have provided feedback on the default startup menu position functionality . I am still looking for ways to make this work without the "quirks". It might take longer than I anticipated, so this evening I will add an option to disable the functionality (for the time being). I will edit this post when that version is on Github.
I still think this is doable, so bear with me! 😊
Regards,
Bart
RE: Amber for Leia - eljejer - 2019-04-10
Sure I bear with you Bart :-) Hope you find a (easy) solution for "the quirck". Regards, Leo
RE: Amber for Leia - bsoriano - 2019-04-11
Well, I have not been able to find a good way of implementing the startup menu position, without having navigation issues, like how it is now, or having to rewrite the whole menu system, like the only other skin I have seen that does this. I have decided I will not work anymore on this feature.
I will focus my efforts on rewriting the menu system using script.skinshortcuts. For those of you that might not know, doing that means that you will be able to select what each menu option is, what each submenu option is, and the order of the menu options and submenu options for each menu option. Also, this will allow you to decide what widgets (shelves) you want for each menu option. I think this is the best deal in terms of customization.
This is a major change, which will task my skills quite a bit. Given this, it will take some time, so don't expect any new updates for a while.
I apologize I could not accomplish the feature as originally planned.
Regards,
Bart
RE: Amber for Leia - eljejer - 2019-04-11
Thanks for your effort Bart!
RE: Amber for Leia - shedrock - 2019-04-11
(2019-04-11, 17:36)bsoriano Wrote: Well, I have not been able to find a good way of implementing the startup menu position, without having navigation issues, like how it is now, or having to rewrite the whole menu system, like the only other skin I have seen that does this. I have decided I will not work anymore on this feature.
I will focus my efforts on rewriting the menu system using script.skinshortcuts. For those of you that might not know, doing that means that you will be able to select what each menu option is, what each submenu option is, and the order of the menu options and submenu options for each menu option. Also, this will allow you to decide what widgets (shelves) you want for each menu option. I think this is the best deal in terms of customization.
This is a major change, which will task my skills quite a bit. Given this, it will take some time, so don't expect any new updates for a while.
I apologize I could not accomplish the feature as originally planned.
Regards,
Bart
I thought the other skins used skin shortcuts to accomplish the menu feature. I know Refocus used it. As a matter of fact, Aeon Nox Silvo does as well. Maybe i am confusing it with Skin Helper. Either way, I appreciate all that you have done with this skin. It is still the fastest skin around. 👍
Thanks again for the effort.
Shedrock
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 17:50)shedrock Wrote:@shedrock , thank you!(2019-04-11, 17:36)bsoriano Wrote: Well, I have not been able to find a good way of implementing the startup menu position, without having navigation issues, like how it is now, or having to rewrite the whole menu system, like the only other skin I have seen that does this. I have decided I will not work anymore on this feature.
I will focus my efforts on rewriting the menu system using script.skinshortcuts. For those of you that might not know, doing that means that you will be able to select what each menu option is, what each submenu option is, and the order of the menu options and submenu options for each menu option. Also, this will allow you to decide what widgets (shelves) you want for each menu option. I think this is the best deal in terms of customization.
This is a major change, which will task my skills quite a bit. Given this, it will take some time, so don't expect any new updates for a while.
I apologize I could not accomplish the feature as originally planned.
Regards,
Bart
I thought the under ski s used skin shortcuts to accomplish the menu feature. I know Refocus used it. As a matter of fact, Aeon Nox Silvo does as well. Maybe i am confusing it with Skin Helper. Either way, I appreciate all that you have done with this skin. It is still the fastest skin around. 👍
Thanks again for the effort.
Shedrock
The skin only uses skinshortcuts for the custom home menu items, if you enable skinshortcuts in the skin settings. If you do not enable it, the skin uses favourites for the custom home menu items. For all of the standard items, for the submenu items, and the shelves, the skin does not use skinshortcuts.Regards,
Bart
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 17:43)eljejer Wrote: Thanks for your effort Bart!@eljejer thank you!
RE: Amber for Leia - DarrenHill - 2019-04-11
@bsoriano - as the others have said, thanks for all the time and effort
One thought - as the skin looks to be stable and working well aside from the default menu point (which is a nicety anyway), would you be comfortable setting a milestone here and consider uploading what we have now (maybe without the default item choice feature at all) to the official repo?
At the moment Joe Public out there doesn't have any access to the skin under Leia as the current version in the repo is incompatible. It might be very nice to remedy that before continuing on with the longer project of the menu re-write.
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 20:29)DarrenHill Wrote: @bsoriano - as the others have said, thanks for all the time and effort@DarrenHill , certainly! I had not thought about the official repo. I will remove the functionality and re-read the info you sent me on submitting to the repo. Any steps I need to ensure before I start? Thanks.
One thought - as the skin looks to be stable and working well aside from the default menu point (which is a nicety anyway), would you be comfortable setting a milestone here and consider uploading what we have now (maybe without the default item choice feature at all) to the official repo?
At the moment Joe Public out there doesn't have any access to the skin under Leia as the current version in the repo is incompatible. It might be very nice to remedy that before continuing on with the longer project of the menu re-write.
Regards,
Bart
RE: Amber for Leia - spudstuff - 2019-04-11
(2019-04-11, 20:51)bsoriano Wrote: I will remove the functionality and re-read the info you sent me on submitting to the repo. Any steps I need to ensure before I start? Thanks.
Don't forget to remove your debug menu before you submit to the official repo mate.
Cheers.
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 23:10)spudstuff Wrote:Oops! I removed the debug grid, but left the options in the menu! I guess I will have to provide an update once the PR gets reviewed. Thanks for the reminder @spudstuff !(2019-04-11, 20:51)bsoriano Wrote: I will remove the functionality and re-read the info you sent me on submitting to the repo. Any steps I need to ensure before I start? Thanks.
Don't forget to remove your debug menu before you submit to the official repo mate.
Cheers.
RE: Amber for Leia - spudstuff - 2019-04-11
(2019-04-11, 23:11)bsoriano Wrote:Perhaps you can sneak in an update? @DarrenHill what do you think?(2019-04-11, 23:10)spudstuff Wrote:Oops! I removed the debug grid, but left the options in the menu! I guess I will have to provide an update once the PR gets reviewed. Thanks for the reminder @spudstuff !(2019-04-11, 20:51)bsoriano Wrote: I will remove the functionality and re-read the info you sent me on submitting to the repo. Any steps I need to ensure before I start? Thanks.
Don't forget to remove your debug menu before you submit to the official repo mate.
Cheers.
https://kodi.wiki/view/HOW-TO:Update_a_pull_request_to_an_official_addon_repository_on_GitHub
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 23:15)spudstuff Wrote:I already added the changes to the pull request. Now let's hope it passes the human review, since there are two commits! I am doing this through SmartGit for Windows and am not too knowledgeable.(2019-04-11, 23:11)bsoriano Wrote:Perhaps you can sneak in an update? @DarrenHill what do you think?(2019-04-11, 23:10)spudstuff Wrote: Don't forget to remove your debug menu before you submit to the official repo mate.Oops! I removed the debug grid, but left the options in the menu! I guess I will have to provide an update once the PR gets reviewed. Thanks for the reminder @spudstuff !
Cheers.
https://kodi.wiki/view/HOW-TO:Update_a_pull_request_to_an_official_addon_repository_on_GitHub
Thanks again @spudstuff and @DarrenHill .
Regards,
Bart
RE: Amber for Leia - spudstuff - 2019-04-11
(2019-04-11, 23:18)bsoriano Wrote:(2019-04-11, 23:15)spudstuff Wrote:I already added the changes to the pull request. Now let's hope it passes the human review, since there are two commits! I am doing this through SmartGit for Windows and am not too knowledgeable.
Thanks again @spudstuff and @DarrenHill .
Regards,
Bart
FYI they want only one commit per pull request (and you now have two). I think you will still have to follow the process on the wiki unfortunately.
Cheers.
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 23:22)spudstuff Wrote:@spudstuff , should I delete the PR then and resubmit a new one?(2019-04-11, 23:18)bsoriano Wrote:(2019-04-11, 23:15)spudstuff Wrote:I already added the changes to the pull request. Now let's hope it passes the human review, since there are two commits! I am doing this through SmartGit for Windows and am not too knowledgeable.
Thanks again @spudstuff and @DarrenHill .
Regards,
Bart
FYI they want only one commit per pull request (and you now have two). I think you will still have to follow the process on the wiki unfortunately.
Cheers.