paco Wrote:Hello Amet. I use your script every day but I've run into a glitch I can't workaround. As you know, Gracenote has taken down many lyrics on lyrics.wikia.com. Your pre-addon release used to display embedded lyrics (UNSYNCEDLYRICS id3 field) before downloading them from lyrics.wikia so I never noticed the problem.

The artist is "The Who" and the problem song is "5:15" from Quadrophenia. Well, CU Lyrics does find the correct song and displays it. Unfortunately, thanks to a Gracenote takedown, it can only display a few lines. Well, the problem arises that it can't save the song to the lyrics folder because of the colon ':' in the song title (colons are no-nos in Windows filenames). It attempts to save the file but a partial file gets written named '5' (no txt extension). I have exported the lyrics embedded in the MP3 to a text file, but no combination I can come up with will force CU Lyrics to use it instead of the neutered lyrics.wikia version (515.txt, 5-15.txt, 5_15.txt, etc...). Any suggested workarounds?

Amet Wrote:5:15 issue fixed in version 0.9.2, thanks for letting me know.

as for the embedded lyrics, CU Lyrics never supported them, it might have been XBMC Lyrics in the earlier stage.

I might look into it at some point but I think XBMC Lyrics might make appearance again and support that

paco Wrote:Thank you for fixing this issue.

You are mistaken re: embedded lyrics support in CU lyrics. I installed XBMC 9.11 and downloaded CU Lyrics 0.7.6 using the SVN Repo Installer. That version of CU Lyrics displays my embedded lyrics before showing the lyrics.wikia.com version. The funny thing is even though it displays the embedded lyrics, it doesn't save them to the hdd.

Here is a screenshot using 0.7.6 on a clean install (no saved lyrics in folders):



That same song shows up as a 'Gracenote Takedown' using lyrics.wikia.com.

Amet Wrote:heh, of course I was wrong

0.9.3 should have the fix for that, let me know if its okay please

Thanks!

paco Wrote:Hi Amet. Thanks for the quick updates. Unfortunately 0.93 has a few glitches that are very easy to reproduce ( I have XBMC playing in shuffle mode in case it makes a difference). I removed my "The Who" lyrics folder for these tests. I press enter to start playing a song. I run the lyrics script and it displays the embedded lyrics. While the song is playing, I press next. CU Lyrics clears but doesn't load the correct lyrics. Instead it displays the lyrics from the last song again. From that point on, on very song skip, CU Lyrics displays the lyrics of the previous song.

I like the option to use "Embedded Lyrics" from the configure menu (the info lists 0.85?). Can an option be added to save embedded file to disk as well (like the lyrics.wikia lookups)?

Another tweak that would be nice would be an option to remove/hide blank lines before the text (lyrics) start. In some skins, it would look a little cleaner.

I can post a debug log should you require it.

Amet Wrote:0.9.4 should fix all the issues except the blank lines, will work on those when I have more time

Quote:14:02:08 T:4952 M:4294967295 NOTICE: self.current_file: smb://FREENAS/Musik/Jörg Bausch/Denn Ich Fliege/03 - Jörg Bausch - Mann Im Mond.mp3
14:02:08 T:4952 M:4294967295 NOTICE: self.current_song: Artist: Jorg Bausch, Title: Mann im Mond
14:02:08 T:4952 M:4294967295 NOTICE: playing_file: smb://FREENAS/Musik/Jörg Bausch/Denn Ich Fliege/03 - Jörg Bausch - Mann Im Mond.mp3
14:02:08 T:4952 M:4294967295 ERROR: xbp__wfopen = untested
14:02:08 T:4952 M:4294967295 NOTICE: SCRAPER-DEBUG: LyricsFetcher.get_lyrics_thread Artist: Jorg Bausch, Title: Mann im Mond
14:02:08 T:4952 M:4294967295 NOTICE: Search url: http://lyricwiki.org/index.php?title=Jorg%20Bausch:Mann%20Im%20Mond&fmt=js

Quote:20:02:21 T:9836 M:4211269632 NOTICE: SCRAPER-DEBUG: LyricsFetcher.get_lyrics_thread Artist: Anna-Maria Zimmermann, Title: Wer ist dieser DJ? (DJ-Mix)
20:02:21 T:9836 M:4211261440 NOTICE: Search url: http://lyricwiki.org/index.php?title=Anna-Maria%20Zimmermann:Wer%20Ist%20Dieser%20Dj%3F%20%28Dj-Mix%29&fmt=js
20:02:22 T:9836 M:4209549312 NOTICE: Title:[Anna-Maria Zimmermann:Wer Ist Dieser DJ]

Zippolighter Wrote:Attached full debug log

http://pastebin.ca/1933807

Regards Zippolighter

Amet Wrote:cheers mate, I have a solution for the second issue you are having. will look at the other one soon

Zippolighter Wrote:Perfect,
Thanks for your support