Release Artist Slideshow addon (with skin and addon integration) - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27) +---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151) +---- Thread: Release Artist Slideshow addon (with skin and addon integration) (/showthread.php?tid=124880) Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
|
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - meowmoo - 2018-05-21 (2018-05-11, 02:48)pkscout Wrote:HI, Im using NFS mounts in Kodi, other Addons and Kodi can read write just fine from the NAS.(2018-05-10, 15:15)meowmoo Wrote: Hi there,All I can say in looking at that is that there is something happening with the NFS access. Are you using NFS mounts defined in Kodi or NFS mounts in an FSTAB file with path substitution? If the latter, I've never tested with that, so I have no idea how using that particular hack might affect file system access from the Kodi virtual file system (which I use in AS). However I looked at the last changes on your github site, and when I change line 102 in resources/common/fileops.py back to Code: _rename( filename, newfilename ) try and error + luck ;P since i still dont know anything about Python, maby you have a idea whats going on. thanks RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-05-21 (2018-05-21, 16:51)meowmoo Wrote:You basically created a situation where the rename function will generate a python error because the variables filename and newfilename don't exist. That error is trapped, so when the rename fails the program does a two step process to rename. It copies the file to the new location then deletes the original. So that works for you (which is great), but I can't for the life of me figure out why the rename function (which is built into the Kodi python stuff) works on my NFS and not yours.(2018-05-11, 02:48)pkscout Wrote:HI, Im using NFS mounts in Kodi, other Addons and Kodi can read write just fine from the NAS.(2018-05-10, 15:15)meowmoo Wrote: Hi there,All I can say in looking at that is that there is something happening with the NFS access. Are you using NFS mounts defined in Kodi or NFS mounts in an FSTAB file with path substitution? If the latter, I've never tested with that, so I have no idea how using that particular hack might affect file system access from the Kodi virtual file system (which I use in AS). RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - meowmoo - 2018-05-22 Thanks for the info. The only thing I can think of is, you say you are using NFS on a Windows pc, I'm using a Linux based NAS. But this shouldn't be the reason right? RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-05-22 (2018-05-22, 13:11)meowmoo Wrote: Thanks for the info.If both are implementing the NFS protocol properly then no, that shouldn't be a reason. If I can find some time this summer I might take a deeper dive and do some testing to see if I can figure out what's going on. RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - AnimalFat - 2018-06-07 Hi, Thanks for creating and maintaining this add-on, I've been using it for several years now and just recently run into this problem. When running the add-on in a clean install of Kodi 17.6, it fails during the creation of the hashes. Going back through this topic, I added a line to default.py to show which artist it failed on. Although I've switched on the 'replace illegal characters' option, it seems the script doesn't like the / character in an artist name whilst parsing and crashes when it reaches Gary Clail / On-U Sound System - all my music is tagged by MusicBrainz. The log file shows this... Code:
This issue doesn't seem to be on one platform, as it crashes on a Raspberry Pi 3 (LibreELEC), Odroid C2 (LibreELEC), Vero 4K (OSMC) and under Windows 7. Regards, AF RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-06-07 (2018-06-07, 16:08)AnimalFat Wrote: Hi,Could you post a link to the entire debug log? There isn't enough there for me to know where to look. Also, could you check to make sure you have the current version of AS from the main Kodi repo (it should be 2.1.2)? I recently updated Kodi to remove all the artist hashes and use real names instead. So the only place I hash anything now is when I merge images from multiple artists, and that only happens to the image path, not the artist name. So the little log snippet you provided isn't making sense to me unless you're on an older version. RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - AnimalFat - 2018-06-07 Hi, This is definitely AS version 2.1.2 installed from the Kodi repo. The full log can be found here. Regards, AF RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-06-08 (2018-06-07, 18:36)AnimalFat Wrote: Hi,Thanks. That was very helpful. I had forgotten that a new install of AS will run through the upgrade routine that changed the hashed artist folders to named ones (even though there's obviously nothing to upgrade). I've never found a good way to tell the difference between a fresh install and one so old it's never been upgraded, so that's why the upgrade runs, and that's the thing that's generating all those hashes. For some reason Kodi is returning one of you're artist names as a list rather than a string, and I have no idea why. That's what's causing the error. I'll see about trapping for that so that at least AS can continue running when it runs into that. In the meantime, here's a workaround. We're basically going to trick AS into thinking it's already done the upgrade.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - AnimalFat - 2018-06-08 Hi, Thank you for this. I created the files as advised, relaunched Kodi and then triggered AS. No errors. Brilliant! I then tested it a bit further by playing some music and the slideshow worked as nature intended. Thank you again. Regards, AF RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - Blurayx - 2018-06-17 @pkscout Artist slideshow 2.1.2 Artist slideshow displays the artist fanart but there are no images inside the extrafanart folder. I have tried numerous Kodi 18 fresh installs. installing/uninstalling Artist Slideshow. I have the same issues on my Nvidia shield TV & iMac. inside my extrafanart folder RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-06-17 (2018-06-17, 15:42)Blurayx Wrote: @pkscoutBy default AS stores all downloaded images in a directory inside the addon's userdata folder. If you want to store those in your local artist path, please check the AS wiki page (link in my signature) for the settings to adjust (specifically look at section 5.1). RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - Blurayx - 2018-06-17 (2018-06-17, 18:00)pkscout Wrote:Hi pkscout,(2018-06-17, 15:42)Blurayx Wrote: @pkscoutBy default AS stores all downloaded images in a directory inside the addon's userdata folder. If you want to store those in your local artist path, please check the AS wiki page (link in my signature) for the settings to adjust (specifically look at section 5.1). Thanks for your help Followed instructions, I'm still getting the same issue RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-06-18 (2018-06-17, 18:34)Blurayx Wrote:To help further I need a link to a full debug log (with Kodi and AS debug logging on). Also, a screenshot of all the AS settings would help.(2018-06-17, 18:00)pkscout Wrote:Hi pkscout,(2018-06-17, 15:42)Blurayx Wrote: @pkscoutBy default AS stores all downloaded images in a directory inside the addon's userdata folder. If you want to store those in your local artist path, please check the AS wiki page (link in my signature) for the settings to adjust (specifically look at section 5.1). RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - Blurayx - 2018-06-18 (2018-06-18, 00:12)pkscout Wrote:https://paste.kodi.tv/yoxokijoki(2018-06-17, 18:34)Blurayx Wrote:To help further I need a link to a full debug log (with Kodi and AS debug logging on). Also, a screenshot of all the AS settings would help.(2018-06-17, 18:00)pkscout Wrote: By default AS stores all downloaded images in a directory inside the addon's userdata folder. If you want to store those in your local artist path, please check the AS wiki page (link in my signature) for the settings to adjust (specifically look at section 5.1).Hi pkscout, Screenshots from Nvidia shield TV If you need more screenshot settings please let me know Thanks RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2018-06-18 There doesn't seem to be anything in the log indicating ArtistSlideshow was invoked. For most skins you have to play a song and go into the actual music visualization screen for it to run. Could you do that and post another debug log? |