+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Amber (https://forum.kodi.tv/forumdisplay.php?fid=203)
+---- Thread: Release Amber for Leia/Matrix/Nexus (/showthread.php?tid=342130)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
RE: Amber for Leia - spudstuff - 2019-04-11
(2019-04-11, 23:23)bsoriano Wrote:(2019-04-11, 23:22)spudstuff Wrote:@spudstuff , should I delete the PR then and resubmit a new one?(2019-04-11, 23:18)bsoriano Wrote: I already added the changes to the pull request. Now let's hope it passes the human review, since there are two commits! I am doing this through SmartGit for Windows and am not too knowledgeable.
Thanks again @spudstuff and @DarrenHill .
Regards,
Bart
FYI they want only one commit per pull request (and you now have two). I think you will still have to follow the process on the wiki unfortunately.
Cheers.
I suppose that's one option since no-one has manually reviewed it yet. But the link at https://kodi.wiki/view/HOW-TO:Update_a_pull_request_to_an_official_addon_repository_on_GitHub shows a way to update the PR into a single commit.
Cheers.
RE: Amber for Leia - bsoriano - 2019-04-11
(2019-04-11, 23:25)spudstuff Wrote:I closed the PR and opened a new one with just one commit.(2019-04-11, 23:23)bsoriano Wrote:(2019-04-11, 23:22)spudstuff Wrote: FYI they want only one commit per pull request (and you now have two). I think you will still have to follow the process on the wiki unfortunately.@spudstuff , should I delete the PR then and resubmit a new one?
Cheers.
I suppose that's one option since no-one has manually reviewed it yet. But the link at https://kodi.wiki/view/HOW-TO:Update_a_pull_request_to_an_official_addon_repository_on_GitHub shows a way to update the PR into a single commit.
Cheers.
Regards,
Bart
RE: Amber for Leia - timmins - 2019-04-12
How does one change the order of things, I noticed with the last update that some things are in different places. Now I find addons and pictures in different places. It most likely I enabled something to do this.
Thanks for all your hard work.
RE: Amber for Leia - bsoriano - 2019-04-12
(2019-04-12, 00:37)timmins Wrote: How does one change the order of things, I noticed with the last update that some things are in different places. Now I find addons and pictures in different places. It most likely I enabled something to do this.@timmins, you did not do anything on your end. I changed the order of the menu options. Unfortunately, at this time it is not possible for you the users to change the order of the menu options. Once I rewrite the menu system using skinshortcuts, you will be able to decide and change the order yourself.
Thanks for all your hard work.
Regards,
Bart
RE: Amber for Leia - drizzt09 - 2019-04-13
thanks for taking up the dev for this one.its been my fave skin since kodi 13.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
RE: Amber for Leia - bsoriano - 2019-04-13
(2019-04-13, 22:40)drizzt09 Wrote: thanks for taking up the dev for this one.its been my fave skin since kodi 13.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
@drizzt09, thanks for your feedback! I will into this issue right away.
Regards,
Bart
RE: Amber for Leia - gibxxi - 2019-04-14
Hi Bart, was browsing through a debug log for my HTPC for an unrelated issue while using this skin (Kodi keeps flat-out crashing on video playback start) and saw this in the debug log:
Code:
2019-04-13 22:28:33.734 T:8588 NOTICE: load skin from: D:\Kodi Media Center\portable_data\addons\skin.amber (version: 3.1.3)
2019-04-13 22:28:34.294 T:8588 WARNING: JSONRPC: Could not parse type "Setting.Details.SettingList"Dan / Gib.
RE: Amber for Leia - bsoriano - 2019-04-14
(2019-04-13, 22:40)drizzt09 Wrote: thanks for taking up the dev for this one.its been my fave skin since kodi 13.@drizzt09 , it is now fixed on Git. Please download, test, and let me know if you find any more issues. Thanks.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
Regards,
Bart
RE: Amber for Leia - drizzt09 - 2019-04-14
(2019-04-14, 00:03)bsoriano Wrote:Question. Is this going to wipe out current settings? I customize my includes.xml file for sub menus(2019-04-13, 22:40)drizzt09 Wrote: thanks for taking up the dev for this one.its been my fave skin since kodi 13.@drizzt09 , it is now fixed on Git. Please download, test, and let me know if you find any more issues. Thanks.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
Regards,
Bart
RE: Amber for Leia - shedrock - 2019-04-14
(2019-04-14, 01:31)drizzt09 Wrote:Yes, it will. Make a backup of your files first.(2019-04-14, 00:03)bsoriano Wrote:Question. Is this going to wipe out current settings? I customize my includes.xml file for sub menus(2019-04-13, 22:40)drizzt09 Wrote: thanks for taking up the dev for this one.its been my fave skin since kodi 13.@drizzt09 , it is now fixed on Git. Please download, test, and let me know if you find any more issues. Thanks.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
Regards,
Bart
Shedrock
RE: Amber for Leia - bsoriano - 2019-04-14
(2019-04-14, 01:31)drizzt09 Wrote:@drizzt09 , @shedrock is correct if you download the very latest version from Git, as I did modify includes.xml. However, the commit to just fix the navigation error you pointed out only modifies skinsettings.xml.(2019-04-14, 00:03)bsoriano Wrote:Question. Is this going to wipe out current settings? I customize my includes.xml file for sub menus(2019-04-13, 22:40)drizzt09 Wrote: thanks for taking up the dev for this one.its been my fave skin since kodi 13.@drizzt09 , it is now fixed on Git. Please download, test, and let me know if you find any more issues. Thanks.
i just loaded kodi 18 and got your version installed today.
i do notice when you setup custom menus (empty > enabled) you cant change the background image. controller wont go there. i can change path and name only, but remote wont move down to single/multi/skin default
Regards,
Bart
Regards,
Bart
RE: Amber for Leia - bsoriano - 2019-04-14
(2019-04-14, 00:02)gibxxi Wrote: Hi Bart, was browsing through a debug log for my HTPC for an unrelated issue while using this skin (Kodi keeps flat-out crashing on video playback start) and saw this in the debug log:Hello @gibxxi , I have seen those with other skins too, I don't think that is affecting your issue.
Code:2019-04-13 22:28:33.734 T:8588 NOTICE: load skin from: D:\Kodi Media Center\portable_data\addons\skin.amber (version: 3.1.3)
2019-04-13 22:28:34.294 T:8588 WARNING: JSONRPC: Could not parse type "Setting.Details.SettingList"
Dan / Gib.
Regards,
Bart
RE: Amber for Leia - drizzt09 - 2019-04-14
(2019-04-14, 04:24)bsoriano Wrote:Ok I'll grab just that file then... Tomorrow. Too intoxicated now being angry at terrible officiating.(2019-04-14, 01:31)drizzt09 Wrote:@drizzt09 , @shedrock is correct if you download the very latest version from Git, as I did modify includes.xml. However, the commit to just fix the navigation error you pointed out only modifies skinsettings.xml.(2019-04-14, 00:03)bsoriano Wrote: @drizzt09 , it is now fixed on Git. Please download, test, and let me know if you find any more issues. Thanks.Question. Is this going to wipe out current settings? I customize my includes.xml file for sub menus
Regards,
Bart
Regards,
Bart
RE: Amber for Leia - gibxxi - 2019-04-14
(2019-04-14, 04:26)bsoriano Wrote:(2019-04-14, 00:02)gibxxi Wrote: Hi Bart, was browsing through a debug log for my HTPC for an unrelated issue while using this skin (Kodi keeps flat-out crashing on video playback start) and saw this in the debug log:Hello @gibxxi , I have seen those with other skins too, I don't think that is affecting your issue.
Code:2019-04-13 22:28:33.734 T:8588 NOTICE: load skin from: D:\Kodi Media Center\portable_data\addons\skin.amber (version: 3.1.3)
2019-04-13 22:28:34.294 T:8588 WARNING: JSONRPC: Could not parse type "Setting.Details.SettingList"
Dan / Gib.
Regards,
Bart
Hi Bart,
I didn't say it was m8. I just saw the entries while attempting to diagnose the other issue, and thought you might want to know. If this isn't skin specific, so much the better.
Dan / Gib.
P.S: Nice work BTW, I've always liked Amber.
RE: Amber for Leia - bsoriano - 2019-04-14
(2019-04-14, 13:50)gibxxi Wrote:(2019-04-14, 04:26)bsoriano Wrote:(2019-04-14, 00:02)gibxxi Wrote: Hi Bart, was browsing through a debug log for my HTPC for an unrelated issue while using this skin (Kodi keeps flat-out crashing on video playback start) and saw this in the debug log:Hello @gibxxi , I have seen those with other skins too, I don't think that is affecting your issue.
Code:2019-04-13 22:28:33.734 T:8588 NOTICE: load skin from: D:\Kodi Media Center\portable_data\addons\skin.amber (version: 3.1.3)
2019-04-13 22:28:34.294 T:8588 WARNING: JSONRPC: Could not parse type "Setting.Details.SettingList"
Dan / Gib.
Regards,
Bart
Hi Bart,
I didn't say it was m8. I just saw the entries while attempting to diagnose the other issue, and thought you might want to know. If this isn't skin specific, so much the better.
Dan / Gib.
P.S: Nice work BTW, I've always liked Amber.
Thanks Dan! I am sorry I came across as defensive. I think that Leia changed somehow what the settings structure should be for addons in general, but most, including skins, don't follow that structure well. I need to look at this further. Kodi reads the old structure with no issues, except the warnings in the log.
Regards,
Bart