+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Release Artist Slideshow addon (with skin and addon integration) (/showthread.php?tid=124880)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-04-13
(2019-04-13, 04:05)tscholl Wrote:OK, now I feel like I really am going to have to do this as a setting. But here's something else to try. Right above the multiimage control you just modified is another one that looks like this:(2019-04-13, 01:32)pkscout Wrote:Ok I changed it as suggested. It does change the behavior back to the original.(2019-04-12, 17:57)tscholl Wrote: The same behavior is found in the windows versions as well. So some change was made between 17.6 and 18.1 on how KODI displays images.I think I found the difference between the v17 and v18 skin. If you go to my v18 mod folder and look for xml/MusicVisualization.xml you can change line 43 from:
That being said it's definitely not a AS problem, but the problem seriously affects the way the images look when displayed.
Not sure where to go from here unless you can send it back to the dev's for a resolution.
to:Code:<aspectratio>scale</aspectratio>
Code:<aspectratio>keep</aspectratio>
I think that will revert back the behavior. I've been pretty consistent about not wanting to change much of the default Estuary behavior in my mod except for the home screen customization, so I need to decide if I'm going to consider this a bug and fix it or just leave it. I just hate the idea that any time I update my mod that you'd have to manually make that change. So maybe there's a new option to add to the mod. '-)
There is however another problem. The images are displayed on top of the fan art, and the fan art always displays around the edges.
With it set to scale you just can't see the fan art because each image covers the whole screen. In previous versions the fan art displayed as the first image and then the slide show started.
Code:
<control type="image">
<aspectratio>scale</aspectratio>
<fadetime>400</fadetime>
<animation effect="fade" start="0" end="100" time="400">WindowOpen</animation>
<animation effect="fade" start="100" end="0" time="300">WindowClose</animation>
<texture background="true">$INFO[Player.Art(fanart)]</texture>
</control>Try deleting all that. I'm pretty sure that's what is showing the single fanart in the background of your non-full size images.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - tscholl - 2019-04-13
(2019-04-13, 04:20)pkscout Wrote:I deleted the code as suggested, and that does get rid of the fanart in the background. However now the fan art never displays as the first image. Instead the last image of the previous artist is displayed briefly, and then it goes into the new slide show.(2019-04-13, 04:05)tscholl Wrote:OK, now I feel like I really am going to have to do this as a setting. But here's something else to try. Right above the multiimage control you just modified is another one that looks like this:(2019-04-13, 01:32)pkscout Wrote: I think I found the difference between the v17 and v18 skin. If you go to my v18 mod folder and look for xml/MusicVisualization.xml you can change line 43 from:Ok I changed it as suggested. It does change the behavior back to the original.
to:Code:<aspectratio>scale</aspectratio>
Code:<aspectratio>keep</aspectratio>
I think that will revert back the behavior. I've been pretty consistent about not wanting to change much of the default Estuary behavior in my mod except for the home screen customization, so I need to decide if I'm going to consider this a bug and fix it or just leave it. I just hate the idea that any time I update my mod that you'd have to manually make that change. So maybe there's a new option to add to the mod. '-)
There is however another problem. The images are displayed on top of the fan art, and the fan art always displays around the edges.
With it set to scale you just can't see the fan art because each image covers the whole screen. In previous versions the fan art displayed as the first image and then the slide show started.
Code:<control type="image">
<aspectratio>scale</aspectratio>
<fadetime>400</fadetime>
<animation effect="fade" start="0" end="100" time="400">WindowOpen</animation>
<animation effect="fade" start="100" end="0" time="300">WindowClose</animation>
<texture background="true">$INFO[Player.Art(fanart)]</texture>
</control>
Try deleting all that. I'm pretty sure that's what is showing the single fanart in the background of your non-full size images.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - tscholl - 2019-04-13
What I deleted was.
<control type="image">
<left>0</left>
<top>0</top>
<width>100%</width>
<height>100%</height>
<aspectratio>scale</aspectratio>
<fadetime>400</fadetime>
<animation effect="fade" start="0" end="100" time="400">WindowOpen</animation>
<animation effect="fade" start="100" end="0" time="300">WindowClose</animation>
<texture background="true" colordiffuse="$VAR[BackgroundDiffusion]">colors/black.png</texture>
<visible>Player.ShowInfo | Window.IsActive(musicosd)</visible>
</control>
Which is slightly different that your post.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-04-13
(2019-04-13, 04:48)tscholl Wrote:(2019-04-13, 04:20)pkscout Wrote:I deleted the code as suggested, and that does get rid of the fanart in the background. However now the fan art never displays as the first image. Instead the last image of the previous artist is displayed briefly, and then it goes into the new slide show.(2019-04-13, 04:05)tscholl Wrote: Ok I changed it as suggested. It does change the behavior back to the original.OK, now I feel like I really am going to have to do this as a setting. But here's something else to try. Right above the multiimage control you just modified is another one that looks like this:
There is however another problem. The images are displayed on top of the fan art, and the fan art always displays around the edges.
With it set to scale you just can't see the fan art because each image covers the whole screen. In previous versions the fan art displayed as the first image and then the slide show started.
Code:<control type="image">
<aspectratio>scale</aspectratio>
<fadetime>400</fadetime>
<animation effect="fade" start="0" end="100" time="400">WindowOpen</animation>
<animation effect="fade" start="100" end="0" time="300">WindowClose</animation>
<texture background="true">$INFO[Player.Art(fanart)]</texture>
</control>
Try deleting all that. I'm pretty sure that's what is showing the single fanart in the background of your non-full size images.
That's about as good as it's gonna get until I have some time to look in more detail at it on the skin side.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-04-13
(2019-04-13, 04:48)tscholl Wrote:(2019-04-13, 04:20)pkscout Wrote:I deleted the code as suggested, and that does get rid of the fanart in the background. However now the fan art never displays as the first image. Instead the last image of the previous artist is displayed briefly, and then it goes into the new slide show.(2019-04-13, 04:05)tscholl Wrote: Ok I changed it as suggested. It does change the behavior back to the original.OK, now I feel like I really am going to have to do this as a setting. But here's something else to try. Right above the multiimage control you just modified is another one that looks like this:
There is however another problem. The images are displayed on top of the fan art, and the fan art always displays around the edges.
With it set to scale you just can't see the fan art because each image covers the whole screen. In previous versions the fan art displayed as the first image and then the slide show started.
Code:<control type="image">
<aspectratio>scale</aspectratio>
<fadetime>400</fadetime>
<animation effect="fade" start="0" end="100" time="400">WindowOpen</animation>
<animation effect="fade" start="100" end="0" time="300">WindowClose</animation>
<texture background="true">$INFO[Player.Art(fanart)]</texture>
</control>
Try deleting all that. I'm pretty sure that's what is showing the single fanart in the background of your non-full size images.
I just pushed an update to my Estuary mod that has an option in the settings to not scale artist images in the music visualization. That should be much cleaner than trying to delete stuff out of that file.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - tscholl - 2019-04-13
Sounds like a great idea. I'll keep an eye out for the update and let you know how I make out. What is the new version number
Thanks for the update
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-04-13
(2019-04-13, 22:10)tscholl Wrote: Sounds like a great idea. I'll keep an eye out for the update and let you know how I make out. What is the new version number1.2.0
Thanks for the update
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - tscholl - 2019-04-14
(2019-04-13, 23:03)pkscout Wrote:The Skin updated and I updated the settings. Having it as a setting was a great idea!!(2019-04-13, 22:10)tscholl Wrote: Sounds like a great idea. I'll keep an eye out for the update and let you know how I make out. What is the new version number1.2.0
Thanks for the update
When you get a chance you'll have to figure out why the previous artist is shown when it changes to the next artist. I can tell you that it actually overlays the fanart. The correct fanart can be seen around the edges. Good luck with that.
Thanks for a quick fix workaround!
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - Hallucyn8 - 2019-04-15
(2019-04-13, 02:54)pkscout Wrote:Great, thanks for that(2019-04-04, 11:21)Hallucyn8 Wrote: I think I might have found a bug in the Fallback Slideshow feature.This should be fixed in 2.14~beta2. I just released it into my beta repo. If you want to try it you can install my beta repo and update AS from that.
I enabled the fallback slideshow and set a folder with images. In the most part this works as expected and uses those images when there are no images for the currently playing artist but if there is a secondary/featured artist that also has no images available the fallback slideshow does not start and just displays a black screen.
I do have secondary/featured artist images enabled and would like to keep this option.
https://github.com/pkscout/repository.beta.pkscout/raw/helix/repository.beta.pkscout-1.1.1.zip
Otherwise I'll probably put in the request to update the main repo in the next few days.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - eljejer - 2019-04-19
Hello. I'm struggling to get AS to work as expected. The fanart is just not being shown ever. I'm using the Amber skin that has a setting to use AS or not. Obviously, this is set to Yes.
When I play the same album on Estuary skin, the fanart is being shown.
I have already reset the music library (deleted the music source and re-added it, fully scraped the music library and exported the library to Artist Information folder.
What more can I do to resolve this? Any help is appreciated.
I attach the log file here.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-04-20
(2019-04-19, 13:50)eljejer Wrote: Hello. I'm struggling to get AS to work as expected. The fanart is just not being shown ever. I'm using the Amber skin that has a setting to use AS or not. Obviously, this is set to Yes.In that log AS is constantly starting and then stopping because it appears no music is playing. The fact that it works with Estuary points to a skin problem. I'm not familiar with Amber or how to calls AS, so you might try in the Amber skin thread:
When I play the same album on Estuary skin, the fanart is being shown.
I have already reset the music library (deleted the music source and re-added it, fully scraped the music library and exported the library to Artist Information folder.
What more can I do to resolve this? Any help is appreciated.
I attach the log file here.
https://forum.kodi.tv/forumdisplay.php?fid=203
If the devs have any thoughts that I can help with, I'm happy to.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - HeresJohnny - 2019-05-03
I'm using this add-on as a starting point for my post although the problem that occurs is almost certainly due to underlying functions.
In my log I keep seeing this kind of warning when artwork is pulled to the music OSD:
Code:
2019-05-03 18:07:11.474 T:2826888048 DEBUG: ffmpeg[A87EE370]: [swscaler] No accelerated colorspace conversion found from yuv420p to bgra.
2019-05-03 18:07:11.517 T:2826888048 DEBUG: DoWork - took 101 ms to load special://masterprofile/Thumbnails/d/d21a80f9.jpg
As far as I can tell this means that ffmpeg is either outdated or wrongly configured when scaling images so there's always a small CPU cost involved. Is there anything that can be done to achieve accelerated scaling?
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - pkscout - 2019-05-03
(2019-05-03, 18:25)HeresJohnny Wrote: I'm using this add-on as a starting point for my post although the problem that occurs is almost certainly due to underlying functions.All AS does is create a window property that points to a folder of images. The actual rendering is handled by the skin, so this is either a skin or a general Kodi issue. There isn't anything I can change in AS to fix that.
In my log I keep seeing this kind of warning when artwork is pulled to the music OSD:
Code:2019-05-03 18:07:11.474 T:2826888048 DEBUG: ffmpeg[A87EE370]: [swscaler] No accelerated colorspace conversion found from yuv420p to bgra.
2019-05-03 18:07:11.517 T:2826888048 DEBUG: DoWork - took 101 ms to load special://masterprofile/Thumbnails/d/d21a80f9.jpg
As far as I can tell this means that ffmpeg is either outdated or wrongly configured when scaling images so there's always a small CPU cost involved. Is there anything that can be done to achieve accelerated scaling?
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - scott967 - 2019-05-03
(2019-05-03, 18:25)HeresJohnny Wrote: I'm using this add-on as a starting point for my post although the problem that occurs is almost certainly due to underlying functions.
In my log I keep seeing this kind of warning when artwork is pulled to the music OSD:
Code:2019-05-03 18:07:11.474 T:2826888048 DEBUG: ffmpeg[A87EE370]: [swscaler] No accelerated colorspace conversion found from yuv420p to bgra.
2019-05-03 18:07:11.517 T:2826888048 DEBUG: DoWork - took 101 ms to load special://masterprofile/Thumbnails/d/d21a80f9.jpg
As far as I can tell this means that ffmpeg is either outdated or wrongly configured when scaling images so there's always a small CPU cost involved. Is there anything that can be done to achieve accelerated scaling?
Looking at the code on ffmpeg for libswscale (yuv2rgb.c) it appears that hardware acceleration is only available for power pc and x86 architectures. It doesn't look like the code has changed since 2014. I don't know if there is something Kodi needs to do when building to turn on this function.
scott s.
.
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - manfeed - 2019-05-05
Hi @pkscout
Many thanks for your work in this addon, I've been using it for years now without any problem... however, recently I've noticed that similar artists images wasn't showing properly, in fact they all return this:
I looked in the AS addon data folder and saw that lastfmartistsimilar.nfo for each artist was pointing to that online image, as you can see:
xml:
<artist><name>Ashanti</name>
<mbid>b0e304ab-ab52-4e4c-bff5-eb0dff0b3d09</mbid>
<match>0.736042</match>
<url>https://www.last.fm/music/Ashanti</url>
<image size="small">https://lastfm-img2.akamaized.net/i/u/34s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="medium">https://lastfm-img2.akamaized.net/i/u/64s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="large">https://lastfm-img2.akamaized.net/i/u/174s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="extralarge">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="mega">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<streamable>0</streamable>
</artist>
<artist><name>Toni Braxton</name>
<mbid>3c8a8696-e176-4c46-a2d3-48b6b1525c7f</mbid>
<match>0.729155</match>
<url>https://www.last.fm/music/Toni+Braxton</url>
<image size="small">https://lastfm-img2.akamaized.net/i/u/34s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="medium">https://lastfm-img2.akamaized.net/i/u/64s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="large">https://lastfm-img2.akamaized.net/i/u/174s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="extralarge">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="mega">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<streamable>0</streamable>
</artist>
<artist><name>Mariah Carey</name>
<mbid>494e8d09-f85b-4543-892f-a5096aed1cd4</mbid>
<match>0.724704</match>
<url>https://www.last.fm/music/Mariah+Carey</url>
<image size="small">https://lastfm-img2.akamaized.net/i/u/34s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="medium">https://lastfm-img2.akamaized.net/i/u/64s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="large">https://lastfm-img2.akamaized.net/i/u/174s/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="extralarge">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="mega">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<image size="">https://lastfm-img2.akamaized.net/i/u/300x300/2a96cbd8b46e442fc41c2b86b821562f.png</image>
<streamable>0</streamable>
</artist>
I guess there must be a problem with lastfm, isn't it?
Thanks!