(2019-10-27, 01:08)Karellen Wrote: Hello @pkscout

I haven't listened to music in Kodi for a while, but had occasion to last night. I am using v18.4 with AeonNox Silvo v7.0.8 by @mikeSiLVO and Artist Slideshow v2.1.4

I noticed that for every artist we listened to, Artist Slideshow would (attempt to) download artwork and create new folders titled "extrafanart" and "information". Most of these folders were empty. My queries...
1. It seems to be ignoring local artwork
2. It duplicates already available local artwork
3. It does not use the new method of saving extrafanart eg fanart1, fanart2 etc

Any idea why this is happening. Do I have a wrong setting enabled/disabled somewhere? I then disabled all references to external sites in the settings page for the addon, but it continues to create these empty folders. I have since disabled the add-on. Needless to say there was a bit of cleaning up to do.

Judging by the log, it is searching for the \extrafanart\ folder which I don't use, so it does not find any of my extrafanart.

Another issue I noticed, and probably more of a Kodi issue, is after I Disabled the add-on, it merrily continued to download artwork. Disabling required a restart of Kodi.

Let me know if you need anything else.

(2019-10-27, 19:09)pkscout Wrote: I'll also include updates so those folders aren't created if all the download options are turned off.  That isn't a use case I thought about before.

(2019-10-27, 19:09)pkscout Wrote: AS does look for artwork in the extrafanart folder (and has since before I started maintaining it). That seemed to be the unofficial standard for a long time before Kodi 18 shipped so I left it to maintain compatibility with other addons that download artwork.

Updating AS for the new artwork structure has ended up not being trivial (mostly because I'm going to have to have a routine to move and rename every piece of existing artwork AS has downloaded), and I've been waiting to make sure the new artwork structure stabilized, so it's going to be awhile.  Honestly every time I read up on the new structure it seems overly complicated and requires lots of manual work to get it activated, so my motivation to do the major rewrite wanes.  But I'll see if I can't get myself excited about it and do the updates.  I'll also include updates so those folders aren't created if all the download options are turned off.  That isn't a use case I thought about before.

(2019-10-27, 22:20)Karellen Wrote: Ok, thanks for the explanation and understand the extra work involved.  

(2019-10-27, 19:40)black_eagle Wrote: There is a bug in your branch 'new-version'

Line 73 - if self.LOGDEBUG or (loglevel != xmbc.DEBUG and loglevel != xbmc.INFO):

Also I got errors regarding kodi-six with regard to xbmc.LOGDEBUG.  I fixed that by importing xbmc instead of from kodi_six import xbmc.  Can't remember what the exact error was but I can probably reproduce it by turning debug logging on and off in the addon.

python:
ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                            Error Type: <class 'NameError'>

                                            Error Contents: name 'xmbc' is not defined

                                            Traceback (most recent call last):

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/default.py", line 79, in <module>

                                                lw.log( ['loaded plugin ' + module] )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 53, in log

                                                self._output( str_line, loglevel )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 60, in _output

                                                self._output_xbmc( line, loglevel )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 73, in _output_xbmc

                                                if self.LOGDEBUG or (loglevel != xmbc.DEBUG and loglevel != xbmc.INFO):

                                            NameError: name 'xmbc' is not defined

                                            -->End of Python script error report<--

python:
2019-10-28 20:52:40.446 T:18739   DEBUG: CAddonSettings[script.artistslideshow]: loading setting values

2019-10-28 20:52:40.447 T:18739   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                            Error Type: <class 'AttributeError'>

                                            Error Contents: module 'kodi_six.xbmc' has no attribute 'DEBUG'

                                            Traceback (most recent call last):

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/default.py", line 79, in <module>

                                                lw.log( ['loaded plugin ' + module] )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 53, in log

                                                self._output( str_line, loglevel )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 60, in _output

                                                self._output_xbmc( line, loglevel )

                                              File "/home/xbmc/build/kodi-19/kodi-build/portable_data/addons/script.artistslideshow/resources/common/xlogger.py", line 73, in _output_xbmc

                                                if self.LOGDEBUG or (loglevel != xbmc.DEBUG and loglevel != xbmc.INFO):

                                            AttributeError: module 'kodi_six.xbmc' has no attribute 'DEBUG'

                                            -->End of Python script error report<--

python:
if self.LOGDEBUG or (loglevel != xbmc.LOGDEBUG and loglevel != xbmc.LOGINFO):

(2013-12-06, 19:03)cw-kid Wrote:

(2013-12-06, 16:32)devilshura Wrote: For Various Artists that has tag "Various Artists" in artist-name.I make local-artist folder for it, and point for not found/no tag-artist with fallback.
e.g.

Various Artists folder in local artist folder

Show In music visualization


And for fallback images folder
 

Hi Devilshura

Fancy sharing your music fallback images with us? They look quite good!

I can see what you have done and I think why it works for you is because your main music path is D:\Music_Artist\ which is a local drive.

And I think I am correct in saying - so when you play an album tagged with artist-name = "Various Artists" Artist SlideShow will display the images in the various artists\extrafanart folder on your D:\ drive. And if it can't find an image to display either remote or local for a particular artist, it will then display the images in your fallback folder instead.

This doesn't work the same for me, because my main music path is a network path SMB://WHS/Music. So Artist SlideShow will only display Remote images and not "Local" ones. Maybe I need to figure out how to add a mount point in Linux / OpenElec somehow ?



I do however have the same Various Artists folder on my file server, but Artist SlideShow won't use it currently.



This is why I asked if Artist SlideShow could instead display the "Various Artists" fanart images from Fanart.tv (Remote) when I play an album and the artist-name is tagged as "Various Artists" 

(2019-10-31, 22:48)Asiapentti Wrote: @pkscout thank you for adding new Kodi music artwork location to artist slideshow. Only problem i've found, is that now it picks up all images from artist folder (clearlogo, thumb, folder, clearart, landscape). Can you exclude those other artwork types, so that only fanart-fanartxx would be fetched to slideshow.

(2019-11-01, 23:39)meowmoo Wrote: I think you could do a resolution check?
If the picture is smaller than 1080, don't use it

(2019-11-01, 03:54)pkscout Wrote: I'm going to have to think about this, but right now I'm leaning towards not supporting the Kodi music artwork location.  It was never designed with addons like AS in mind and I feel like I'm constantly kludging stuff to get it to work.

(2019-11-01, 03:54)pkscout Wrote: Maybe someday if Kodi let's a skin display a list of images rather than a folder.