Release Artist Slideshow addon (with skin and addon integration) - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27) +---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151) +---- Thread: Release Artist Slideshow addon (with skin and addon integration) (/showthread.php?tid=124880) Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
|
RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-04 (2020-01-04, 17:53)pulsar124 Wrote: AS is definitely broken for the latest official Kodi (18.5; at least under Android), whether I am using the pkscout's Leia Estuary mod or not.I am unable to duplicate your issue on my Mac, Windows, or OSMC machines with either my Estuary mod or the default Estuary. I'll be happy to look through the logs, but if you're having the same problem with Estuary and my Estuary mod I'm leaning towards either a local issue you have or something on Android. Regardless, as I said above, AS doesn't actually show any images. All it does is set a skin property so the skin can show an image. If you're seeing the problem with the default Estuary, I'd suggest you post something in the Estuary support forum, as maybe someone there has an Android based Kodi setup they can test with to help troubleshoot. https://forum.kodi.tv/forumdisplay.php?fid=260 RE: Artist Slideshow addon (with skin and addon integration) - pulsar124 - 2020-01-04 Thanks for the quick reply. I just added the log link to my previous post. So what should be the correct behavior: slideshow starts with low contrast (when foreground elements are still present), then should become bright and high contrast after the foreground is gone? Also, what is the purpose of the "background diffusion" setting in your mod? I don't see any changes when I set it to different values. Here is an idea - is it possible to make the skin AS using to post pictures the most foreground one? Then all potential foreground image issues will be dealt with. EDIT: I found the following lines from my log file suspicious or potentially relevant (they all come from the log section when AS slideshow has already started): 2020-01-04 16:10:04.754 T:7074 ERROR: EXCEPTION: Invalid setting type 2020-01-04 16:10:04.757 T:7074 DEBUG: [Artist Slideshow] ArtistSlideshow.Image set to /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.artistslideshow/resources/images/black-hd.png 2020-01-04 16:10:04.795 T:7049 DEBUG: ffmpeg[7F781970]: [swscaler] No accelerated colorspace conversion found from yuv420p to bgra. 2020-01-04 16:10:06.713 T:7047 DEBUG: Caching image 'smb://192.168.0.2/E/PHOTOS-LILY/IMG_9541.jpg' to '3/3be9a0a3.jpg': 2020-01-04 16:10:06.849 T:7047 DEBUG: cached image 'special://masterprofile/Thumbnails/3/3be9a0a3.jpg' size 727x720 2020-01-04 16:10:14.543 T:7015 DEBUG: ------ Window Deinit (Custom_1109_TopBarOverlay.xml) ------ The ERROR message is important I think - I wonder what's causing it? Then the image black-hd.png - what does it do? Can it be masking my images somehow? Not sure why I get the message "colorspace conversion found from yuv420p to bgra" for each of my images. All my images regular RGB jpeg files. And then again this weird downscaling report, for each of my images being cached (scaled down to 720p). RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-04 (2020-01-04, 18:17)pulsar124 Wrote: Thanks for the quick reply. I just added the log link to my previous post.That black image is set during slideshow transition and removed as soon as anything is added to the slideshow. So there is no way I can think of it would be interfering with your display. Again, what is done with the image is completely dependent on the skin. Whatever remaining issue you have is either skin related or Android related. I have never, in all my years using Kodi, seen the cache being down scaled, but then again I've never used Android. I know that neither Estuary nor my Estuary mod scale or load low contrast images first. I understand that you would like help trying to resolve your issue, and what I'm trying to tell you is that you need to go to the right place to try and figure this out. Because I've never been able to duplicate your issue on any other platform, you might consider instead posting something to the Android sub-forum: https://forum.kodi.tv/forumdisplay.php?fid=164 Alternatively you could try posting in the Estuary skin sub-forum: https://forum.kodi.tv/forumdisplay.php?fid=260 Just please don't post the same problem in both places. Pick one and see if anyone can help you. If they can't you can try the other sub-forum. RE: Artist Slideshow addon (with skin and addon integration) - pulsar124 - 2020-01-04 Ok, at least I fixed the downscaling issue, by creating advancedsettings.xml file with the following content: <advancedsettings version="1.0"> <imageres>9999</imageres> <fanartres>9999</fanartres> <imagescalingalgorithm>nearest_neighbor</imagescalingalgorithm> </advancedsettings> Now the cached images have the proper (unchanged) size. RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-04 New Beta Available (3.0.1~beta15) - In daemon mode you can now change AS settings without having to restart Kodi - fix for runaway loop if there is only one image in an artist's slideshow Available from my beta repo as usual. That first one is something that's really been an issue since, well, forever. I figured while I was fixing other stuff it was a good time to fix that too. RE: Artist Slideshow addon (with skin and addon integration) - pulsar124 - 2020-01-04 I will post this to one of the suggested Kodi forums, but want to clarify one more thing first. I found this info online: <color name="Background">ff000000</color> <color name="FanartFade">8Fffffff</color> <color name="FloorFade">D9000000</color> Where exactly these parameters are set? Perhaps changing one ore more of them will solve my low contrast issue? Perhaps making FanartFade fully transparent (like this: 00ffffff?) will do the trick? RE: Artist Slideshow addon (with skin and addon integration) - scott967 - 2020-01-04 (2020-01-04, 20:03)pulsar124 Wrote: I will post this to one of the suggested Kodi forums, but want to clarify one more thing first.They are typically in a skin's color themes (folder "colors"), either in "defaults.xml" or in a specific color theme xml file which then is exposed as a UI setting. I don't think addons can override this in xml windows/dialogs (though AS doesn't use xml coding). But once defined the skin then uses the color by name rather than the ARGB in any control that can use a color/textcolor/diffusecolor etc. ---------------- beta 13 has restored the notification function I had used (personally) in v 2. Thanks for that. scott s. . RE: Artist Slideshow addon (with skin and addon integration) - scott967 - 2020-01-04 (2020-01-03, 01:58)pkscout Wrote:(2020-01-03, 01:21)MB1968 Wrote: I'm in the same boat. I'm using the AeonMQ7 Leia mod skin. I've tried almost every combination of setting in the ASS addon, but none of them work in Kodi 18.5 on Android. The slideshow won't display the fanart images in the Kodi Artist Information folder, or fanarts from a custom location Even the fallback slideshow option does not work. Unmatched paren is a skin typo. Inform Wanilton or whomever is doing the MQ7 mod. Should be string.isempty(window(visualisation).property(artistslideshow.artworkready)) Can't do anything about script.module.metadatautils exception without a full log. I also see the ERROR: EXCEPTION: Invalid setting type but I don't see anything wrong in settings.xml. TBH I don't understand what Kodi debug log is logging when addon settings are used (there's the old settings and new settings and they've been a moving target). scott s. . RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-05 (2020-01-04, 22:19)scott967 Wrote: I also see the ERROR: EXCEPTION: Invalid setting type but I don't see anything wrong in settings.xml. TBH I don't understand what Kodi debug log is logging when addon settings are used (there's the old settings and new settings and they've been a moving target). I have a wrapper for the xbmcadd.Addon().getSetting stuff (i.e. getSettingInt, etc) so that I can use the same call in older versions of Kodi and newer ones. Apparently if you use getSettingInt to get a setting that doesn't exist (and there's a particular case in my code where that is true, it's a long reason), Python throws a Type Error. In the wrapper I trap for that error and then return a default value, but Kodi logs that Invalid Type anyway. If you use the older getSetting, it returns an empty string if the setting isn't found and no error is logged. I rewrote the wrapper to stop using getSettingInt and instead just try and force getSetting into an int (which is what I was doing for older Kodi versions anyway). If the int conversion fails it generates a python Value Error. Since I trap for that and return the default value, Kodi doesn't log anything about any errors. So basically the solution is to stop using the newer getSettingInt, getSettingNumber, or getSettingBool so you get fewer log entries with errors. '-) RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-05 New Beta Available (3.0.1~beta16) - fixes to eliminate Setting Type Error in Kodi logs Available as usual from my beta repo. Barring any other reports of issues, I will be submitting a PR to the main Kodi repo on Monday. Not that it will really matter, but the actual version will be 3.1.0. There were enough fixes and changes here to warrant a minor version bump rather than just a maintenance version bump. RE: Artist Slideshow addon (with skin and addon integration) - bluezed - 2020-01-05 Hi @pkscout First of all thank you very much for all your hard work on this Addon, I've been using it for many years now I have one question though, and I'm not sure if it's to do with the App, the Skin or something completely different so I'm sorry if this is nothing to do with the App... I usually listen to radio stations through the TuneIn2017 addon and on full screen the Artist Slideshow picks up on the Artist and Title and shows the correct fanart for the artist currently playing. It works with most radio stations but for example Kerrang! Radio shows the artist and title in the opposite order, so first Title and then Artist, and with that the Artist Slideshow does not find anything or an incorrect Artist. Or at least that's what it looks like... Is that something that can be changed or adjusted in Artist Slideshow or is that an issue with the Skin (Aeon Nox Silvo) or something that one just have to live with? I already contacted the author of TuneIn2017 and he did some investigating with the result that it's outside his control. Here's his reply: Link to Post Thank you very much! RE: Artist Slideshow addon (with skin and addon integration) - pulsar124 - 2020-01-05 I posted my issue on the Estuary sub-forum (no reply so far). A question for pkscout: can you please describe what is the correct behaviour of your add-on AS? Do fanart images start with low contrast (when the foreground stuff is still present), and then are displayed correctly after the foreground elements go away? RE: Artist Slideshow addon (with skin and addon integration) - pkscout - 2020-01-05 (2020-01-05, 14:12)bluezed Wrote: Hi @pkscoutI've added an option for version 3.1.0 (which should be coming out soon) to more aggressively check a stream title for an artist that will return artists that are in the second position. To do that I had to assume both the first and second positions were artists, so some things aren't quite going to work right in AS if the artist is in the second position. Namely:
RE: Artist Slideshow addon (with skin and addon integration) - bluezed - 2020-01-05 (2020-01-05, 20:06)pkscout Wrote: I've added an option for version 3.1.0 (which should be coming out soon) to more aggressively check a stream title for an artist that will return artists that are in the second position. To do that I had to assume both the first and second positions were artists, so some things aren't quite going to work right in AS if the artist is in the second position. Namely: Wow, sounds great! Looking forward to trying it out. Thank you very much! 😀 RE: Artist Slideshow not functioning on my Kodi 16.1 - Caesarius - 2020-01-06 (2020-01-03, 19:04)pkscout Wrote: AS 2.1.5 should be in the main Kodi repo for Kodi 16 (under Program Addons). It's been quite awhile since I used Kodi 16 though, so if it isn't there for some reason, you can grab this zip:Hi, Thanks a lot for your help! I have Artis Slideshow now on my Minix Player and on my Dune Player- perfect! Cheers Caesar |