Kodi Community Forum
Arctic: Zephyr 2 - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Arctic: Zephyr - Reloaded (https://forum.kodi.tv/forumdisplay.php?fid=221)
+---- Thread: Arctic: Zephyr 2 (/showthread.php?tid=339791)



RE: Arctic: Zephyr 2 - onesane - 2019-08-21

Hey Jurial -

The Small Landscape aspect/view isn't working for me on submenus on my basic horizontal home screen. It displays as Poster instead. I'm on the latest release - 0.9.43-alpha5. I do have the home screen set up so you have to press down twice to get into that full view (Is it that portion called the hub? Maybe I'm describing it with the wrong terms). Anyway, any ideas?


RE: Arctic: Zephyr 2 - drinfernoo - 2019-08-21

(2019-08-21, 04:40)onesane Wrote: Hey Jurial -

The Small Landscape aspect/view isn't working for me on submenus on my basic horizontal home screen. It displays as Poster instead. I'm on the latest release - 0.9.43-alpha5. I do have the home screen set up so you have to press down twice to get into that full view (Is it that portion called the hub? Maybe I'm describing it with the wrong terms). Anyway, any ideas?

https://github.com/jurialmunkey/skin.arctic.zephyr.2/issues/91


RE: Arctic: Zephyr 2 - Sjors125 - 2019-08-21

(2019-08-21, 00:19)jurialmunkey Wrote:
(2019-08-19, 10:11)denist Wrote: Hi,

Mist say this skin is very slick and prefer it over the old v1. Quick question I am using the Move Db help as widgets the in theatres including widgets. One thing that skin helper did was have a trailer button the movie sb helper does not have this when I press info. Is there any plans on cleaning up that side of things where if I push on the image or tittle of movie that it plays the trailer and if I push info it will bring up more information of the movie as it does now. Hop Le you understand what I mean.

Thanks.

I'm working on adding trailers to TMDb helper. It is still a work in progress Wink  

Would that be only when in an info box, or also pre-movie?


RE: Arctic: Zephyr 2 - drinfernoo - 2019-08-21

(2019-08-21, 00:16)jurialmunkey Wrote: The info button on the osd shows images because it looks up the info online using tmdb helper if the item isn't in the library.

Why is there a distinction? Couldn't the information dialog use online lookup for a field in the event that field isn't filled? For instance, if the cast, studio, or something similar weren't filled in, it would use TheMovieDb Helper to do so.


RE: Arctic: Zephyr 2 - jurialmunkey - 2019-08-21

(2019-08-21, 07:34)drinfernoo Wrote:
(2019-08-21, 00:16)jurialmunkey Wrote: The info button on the osd shows images because it looks up the info online using tmdb helper if the item isn't in the library.

Why is there a distinction? Couldn't the information dialog use online lookup for a field in the event that field isn't filled? For instance, if the cast, studio, or something similar weren't filled in, it would use TheMovieDb Helper to do so.
If the cast list was completely empty, I could show a different list in its place. The problem is that the list isn't empty, there just aren't cast images and I can't edit info/properties of a listitem in a different list. It's the same reason why skin helper sets window properties for the info it pulls. Plus I'd need to make an individual request for every item in the list.

Even checking if the list is empty is problematic because I can only check after the window is loaded. So that means the backup list will always be there (and doing online requests), it will just be hidden.


RE: Arctic: Zephyr 2 - jurialmunkey - 2019-08-21

(2019-08-21, 06:05)Sjors125 Wrote:
(2019-08-21, 00:19)jurialmunkey Wrote:
(2019-08-19, 10:11)denist Wrote: Hi,

Mist say this skin is very slick and prefer it over the old v1. Quick question I am using the Move Db help as widgets the in theatres including widgets. One thing that skin helper did was have a trailer button the movie sb helper does not have this when I press info. Is there any plans on cleaning up that side of things where if I push on the image or tittle of movie that it plays the trailer and if I push info it will bring up more information of the movie as it does now. Hop Le you understand what I mean.

Thanks.

I'm working on adding trailers to TMDb helper. It is still a work in progress Wink  

Would that be only when in an info box, or also pre-movie?
I don't understand what you mean by "pre movie".


RE: Arctic: Zephyr 2 - Sjors125 - 2019-08-21

(2019-08-21, 10:06)jurialmunkey Wrote:
(2019-08-21, 06:05)Sjors125 Wrote:
(2019-08-21, 00:19)jurialmunkey Wrote: I'm working on adding trailers to TMDb helper. It is still a work in progress Wink  

Would that be only when in an info box, or also pre-movie? 
I don't understand what you mean by "pre movie". 
Pre-movie I mean is when starting a movie, you get some trailers before that, just like in cinemas.


RE: Arctic: Zephyr 2 - drinfernoo - 2019-08-21

(2019-08-21, 09:49)jurialmunkey Wrote:
(2019-08-21, 07:34)drinfernoo Wrote:
(2019-08-21, 00:16)jurialmunkey Wrote: The info button on the osd shows images because it looks up the info online using tmdb helper if the item isn't in the library.

Why is there a distinction? Couldn't the information dialog use online lookup for a field in the event that field isn't filled? For instance, if the cast, studio, or something similar weren't filled in, it would use TheMovieDb Helper to do so.
If the cast list was completely empty, I could show a different list in its place. The problem is that the list isn't empty, there just aren't cast images and I can't edit info/properties of a listitem in a different list. It's the same reason why skin helper sets window properties for the info it pulls. Plus I'd need to make an individual request for every item in the list.

Even checking if the list is empty is problematic because I can only check after the window is loaded. So that means the backup list will always be there (and doing online requests), it will just be hidden.

Would it be worth simply doing the lookup regardless? For users opening information on add-on content, it seems that it's far more likely that the add-on hasn't set the cast, than that it has.


RE: Arctic: Zephyr 2 - jurialmunkey - 2019-08-21

(2019-08-21, 15:41)Sjors125 Wrote:
(2019-08-21, 10:06)jurialmunkey Wrote:
(2019-08-21, 06:05)Sjors125 Wrote: Would that be only when in an info box, or also pre-movie? 
I don't understand what you mean by "pre movie". 
Pre-movie I mean is when starting a movie, you get some trailers before that, just like in cinemas.

I don't see what that has to do with tmdb helper. Tmdb doesn't provide movies to watch, it just provides metadata about movie info.

Plus isn't that what the cinemavision addon already does?


RE: Arctic: Zephyr 2 - jurialmunkey - 2019-08-21

(2019-08-21, 16:09)drinfernoo Wrote:
(2019-08-21, 09:49)jurialmunkey Wrote:
(2019-08-21, 07:34)drinfernoo Wrote: Why is there a distinction? Couldn't the information dialog use online lookup for a field in the event that field isn't filled? For instance, if the cast, studio, or something similar weren't filled in, it would use TheMovieDb Helper to do so.
If the cast list was completely empty, I could show a different list in its place. The problem is that the list isn't empty, there just aren't cast images and I can't edit info/properties of a listitem in a different list. It's the same reason why skin helper sets window properties for the info it pulls. Plus I'd need to make an individual request for every item in the list.

Even checking if the list is empty is problematic because I can only check after the window is loaded. So that means the backup list will always be there (and doing online requests), it will just be hidden.

Would it be worth simply doing the lookup regardless? For users opening information on add-on content, it seems that it's far more likely that the add-on hasn't set the cast, than that it has.
I'd like to respect the api by making as few calls as necessary.

Plus cast is a tricky one because it is the only list built in to the info dialog, which gives me much less control over it.

And anyway, as I said before, the issue is that these addons don't set images for the cast members, not that the cast list is empty.

That's an issue that those addons should fix. It is so much easier to do on the addon side of things than with a secondary addon in the skin afterwards. Plus those addons have already pulled the metadata to get info about the cast, they just haven't bothered to parse it correctly and set the images.

I'm really not interested in plugging holes in badly built addons that don't know how to parse metadata correctly.


RE: Arctic: Zephyr 2 - onesane - 2019-08-21

(2019-08-21, 05:33)drinfernoo Wrote:
(2019-08-21, 04:40)onesane Wrote: Hey Jurial -

The Small Landscape aspect/view isn't working for me on submenus on my basic horizontal home screen. It displays as Poster instead. I'm on the latest release - 0.9.43-alpha5. I do have the home screen set up so you have to press down twice to get into that full view (Is it that portion called the hub? Maybe I'm describing it with the wrong terms). Anyway, any ideas?

https://github.com/jurialmunkey/skin.arctic.zephyr.2/issues/91 
Oops. Thanks!


RE: Arctic: Zephyr 2 - Sjors125 - 2019-08-22

(2019-08-21, 22:51)jurialmunkey Wrote:
(2019-08-21, 15:41)Sjors125 Wrote:
(2019-08-21, 10:06)jurialmunkey Wrote: I don't understand what you mean by "pre movie". 
Pre-movie I mean is when starting a movie, you get some trailers before that, just like in cinemas. 

I don't see what that has to do with tmdb helper. Tmdb doesn't provide movies to watch, it just provides metadata about movie info.

Plus isn't that what the cinemavision addon already does? 
Haha, maybe I just didn't understand what your add-on is doing Wink
As there was discussion about trailers, I wondered if they where only viewable in the movie info dialog, or pre-movie too.
There are indeed other add-ons that do just that.


RE: Arctic: Zephyr 2 - denist - 2019-08-23

(2019-08-21, 00:19)jurialmunkey Wrote:
(2019-08-19, 10:11)denist Wrote: Hi,

Mist say this skin is very slick and prefer it over the old v1. Quick question I am using the Move Db help as widgets the in theatres including widgets. One thing that skin helper did was have a trailer button the movie sb helper does not have this when I press info. Is there any plans on cleaning up that side of things where if I push on the image or tittle of movie that it plays the trailer and if I push info it will bring up more information of the movie as it does now. Hop Le you understand what I mean.

Thanks.

I'm working on adding trailers to TMDb helper. It is still a work in progress Wink

Awesome cannot wait. I see you are a fellow Aussie and use the Matt’s addons for our streaming channels Smile

Thanks.


RE: Arctic: Zephyr 2 - Eddie Strike - 2019-08-23

Where you able to reproduce my issue with TV show fanarts?

Here's how it looks on Aura vs on AZ2: https://imgur.com/a/KALao0L


RE: Arctic: Zephyr 2 - jurialmunkey - 2019-08-23

(2019-08-23, 09:38)Eddie Strike Wrote: Where you able to reproduce my issue with TV show fanarts?

Here's how it looks on Aura vs on AZ2: https://imgur.com/a/KALao0L
Intentional. If the widget contains episodes then the landscape widget will show episode thumbs.