Release - After Watch - Printable Version

Release After Watch - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Service Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=152)
+---- Thread: Release After Watch (/showthread.php?tid=162770)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-11, 20:42)AnonTester Wrote: problem is the xbmc.validatePath call in line 25 which strips the rest of the path.

Description of what validatePath does here and it doesn't appear that this is a particularly useful function:
https://alwinesch.github.io/group__python__xbmc.html#ga7d325903d7bc797f993c9df791d22c44

Fascinating stuff. It seems like you encountered a bug which seems to be there (in Kodi) for at least 9 years.. This specific line will remove all of the remaining path when a double slash is found: https://github.com/xbmc/xbmc/blob/379f5f9903527385200289edd556a4a1ed895668/xbmc/Util.cpp#L1034
A simple fix for this would be using this instead:

cpp:
 result.erase(result.begin() + x);

On the other hand, your link gives this exactly as an example, Z://something becomes Z:. But why on earth would you want that? It makes more sense to strip double slashes and keep the rest of the path Confused

So I agree with you there is no need to validate through this (broken) function and will push out a fix soon. Thanks for mentioning!

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-11, 23:33)Haris1977 Wrote: Thanks.

I 've just seen an other error too: While i get the delete notification (in tv episodes) when i hit delete - > yes nothing happens (tv episode is not deleted)

(i should have tested that before)

Did you restart Kodi after the previous error? It's probably in a 'undefined' state now Tongue

Just tested it here with alternate method enabled (same as yours when using nfs paths) and it still works fine. I think that on exceptions things are only fixed when restart Kodi (or probably disable / enable the add-on will also work). If you keep getting this error, please post a debug log.

RE: After Watch - jvandenbroek - 2019-02-12

New version, hopefully I fixed al screw-ups now Blush

https://github.com/jvandenbroek/jvandenbroek-kodi-repo/raw/master/script.service.afterwatch/script.service.afterwatch-1.0.6.zip

RE: After Watch - Haris1977 - 2019-02-12

Yes i did restart kodi and (or) enabled/disabled addon. I get an error “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019”

But the file (mkv + jpg) is still there, i can watch it..

RE: After Watch - Haris1977 - 2019-02-12

I also tried (again) to delete a movie and i get a message “ you do not have permissions to move/delete this file”

Very strange..

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-12, 00:42)Haris1977 Wrote: Yes i did restart kodi and (or) enabled/disabled addon. I get an error “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019”

But the file (mkv + jpg) is still there, i can watch it..

Same with just released version? If so, please revert to version 1.0.4 for the time being, I'll investigate tomorrow. And if you could post a debug log with all lines included from the first line containing [After Watch] after you get this error, that would be really helpful :-) Also let me know if version 1.0.4 does actually work for you, might be some other issue not related to the updates..

RE: After Watch - Haris1977 - 2019-02-12

(2019-02-12, 00:53)jvandenbroek Wrote:
(2019-02-12, 00:42)Haris1977 Wrote: Yes i did restart kodi and (or) enabled/disabled addon. I get an error “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019”

But the file (mkv + jpg) is still there, i can watch it..

Same with just released version? If so, please revert to version 1.0.4 for the time being, I'll investigate tomorrow. And if you could post a debug log with all lines included from the first line containing [After Watch] after you get this error, that would be really helpful :-) Also let me know if version 1.0.4 does actually work for you, might be some other issue not related to the updates..

I reverted back to 1.04 but to no avail. I get the “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019” in Tv episodes and the "you do not have permissions to move/delete this file” in Movies.

Here is my kodi log file

https://www81.zippyshare.com/v/lsKelPtc/file.html

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-12, 01:12)Haris1977 Wrote:
(2019-02-12, 00:53)jvandenbroek Wrote:
(2019-02-12, 00:42)Haris1977 Wrote: Yes i did restart kodi and (or) enabled/disabled addon. I get an error “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019”

But the file (mkv + jpg) is still there, i can watch it..

Same with just released version? If so, please revert to version 1.0.4 for the time being, I'll investigate tomorrow. And if you could post a debug log with all lines included from the first line containing [After Watch] after you get this error, that would be really helpful :-) Also let me know if version 1.0.4 does actually work for you, might be some other issue not related to the updates..
I reverted back to 1.04 but to no avail. I get the “[Errno 2] No such file or directory:’nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019” in Tv episodes and the "you do not have permissions to move/delete this file” in Movies.

Here is my kodi log file

https://www81.zippyshare.com/v/lsKelPtc/file.html

Found it, will fix tomorrow. Thanks for testing!

RE: After Watch - jvandenbroek - 2019-02-12

Fix for delete error on alt method: https://github.com/jvandenbroek/jvandenbroek-kodi-repo/raw/master/script.service.afterwatch/script.service.afterwatch-1.0.7.zip
Sorry for the inconvenience!

RE: After Watch - Haris1977 - 2019-02-12

(2019-02-12, 12:51)jvandenbroek Wrote: Fix for delete error on alt method: https://github.com/jvandenbroek/jvandenbroek-kodi-repo/raw/master/script.service.afterwatch/script.service.afterwatch-1.0.7.zip
Sorry for the inconvenience!

Thanks, it finally works now Smile

My only issue is still the 'Remove empty directories' for TV Episodes (that's where i need it) that still doesnt work for me

My kodi log file (i dont get any errors from the addon):

https://www67.zippyshare.com/v/rPv3MsBH/file.html

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-12, 13:14)Haris1977 Wrote:
(2019-02-12, 12:51)jvandenbroek Wrote: Fix for delete error on alt method: https://github.com/jvandenbroek/jvandenbroek-kodi-repo/raw/master/script.service.afterwatch/script.service.afterwatch-1.0.7.zip
Sorry for the inconvenience!
Thanks, it finally works now

My only issue is still the 'Remove empty directories' for TV Episodes (that's where i need it) that still doesnt work for me

My kodi log file (i dont get any errors from the addon):

https://www67.zippyshare.com/v/rPv3MsBH/file.html

Are you 100% sure there are no files left? This line

Code:
13:09:50.421 T:1648309104  NOTICE: [After Watch] xbmcvfs.rmdir: del_empty=1, length=1, count=0, source=nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019

implies there must be 1 other file left. When you use the delete function in Kodi, it probably just removes all files in it.

RE: After Watch - Haris1977 - 2019-02-12

(2019-02-12, 13:31)jvandenbroek Wrote:
(2019-02-12, 13:14)Haris1977 Wrote:
(2019-02-12, 12:51)jvandenbroek Wrote: Fix for delete error on alt method: https://github.com/jvandenbroek/jvandenbroek-kodi-repo/raw/master/script.service.afterwatch/script.service.afterwatch-1.0.7.zip
Sorry for the inconvenience!
Thanks, it finally works now

My only issue is still the 'Remove empty directories' for TV Episodes (that's where i need it) that still doesnt work for me

My kodi log file (i dont get any errors from the addon):

https://www67.zippyshare.com/v/rPv3MsBH/file.html

Are you 100% sure there are no files left? This line

Code:
13:09:50.421 T:1648309104 NOTICE: [After Watch] xbmcvfs.rmdir: del_empty=1, length=1, count=0, source=nfs://192.168.1.110/Videos/Series Haris/Life in the Tomb 2019
implies there must be 1 other file left. When you use the delete function in Kodi, it probably just removes all files in it.

As you can see here https://www33.zippyshare.com/v/oqZMQuL9/file.html i have enabled the "Show hidden files" option on my win7 server. I only see 2 files (the *.jpg one is my custom thumbnail image). The above image depicts my win7 SMB share (no extra files in it). The problem may be in my server's nfs software though.

So when "after watch addon" deletes both of them, my main "Life in the Tomb 2019" folder still remains empty on my server.

PS: Here is a screenshot of my nfs software (if y want to take a look)

https://www90.zippyshare.com/v/wmxAHqWe/file.html

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-12, 15:11)Haris1977 Wrote: As you can see here https://www33.zippyshare.com/v/oqZMQuL9/file.html i have enabled the "Show hidden files" option on my win7 server. I only see 2 files (the *.jpg one is my custom thumbnail image). The above image depicts my win7 SMB share (no extra files in it). The problem may be in my server's nfs software though.

So when "after watch addon" deletes both of them, my main "Life in the Tomb 2019" folder still remains empty on my server.

PS: Here is a screenshot of my nfs software (if y want to take a look)

https://www90.zippyshare.com/v/wmxAHqWe/file.html

You still have hide system protected files hidden, however I doubt such file would exist in this folder. So yes, really strange it stills seems to think there is 1 file left. Could you install this zip and repeat the delete function? This time I've added debug info which should show the detected file name, which might help us solve this mystery. Could you try this zip (same version number, just install over it the current one): https://vandenbroek.xyz/stuff/script.service.afterwatch.zip

RE: After Watch - Haris1977 - 2019-02-12

Ok, here is my /storage/.kodi/temp/kodi.log file (with new zip addon)

https://www118.zippyshare.com/v/rgYsUj0l/file.html

RE: After Watch - jvandenbroek - 2019-02-12

(2019-02-12, 17:05)Haris1977 Wrote: Ok, here is my /storage/.kodi/temp/kodi.log file (with new zip addon)

https://www118.zippyshare.com/v/rgYsUj0l/file.html

Thanks, this helps. It indeed doesn't detect any files left (no file named after =), but it does count one. I need to figure out if this has to do with using nfs:// (and/or smb://) paths, or something Windows related. I assume you're running Kodi also on Windows, correct? Not just the file server.

Edit: Hmm guess that's not the case, seems like you're using LibreELEC looking at the reported version in your log. Will need to setup a similar setup here and test it with nfs:// paths. Guess that call will just always return an empty item, regardless whether any files are left. To be continued Cool

Edit 2: I've just tested it on LibreELEC with a test library located at nfs://, just like your setup, with only 1 set of files in it (mkv, jpg etc named the same). This does work as expected here, removes the empty directory and reports 0 left over files. So it seems specific to your setup since it reports 1 file left over, it's just really unclear to me why that would be. Maybe the used NFS server (mine is just standard Linux, yours is kind a 'exotic' Wink

) does report something different back to the client, which Kodi stores as an empty file name. So I don't think there is much I can do at this point, unless we know why that empty file name is reported back (that would require packet inspection with something like Wireshark, but it's not worth the effort if you're not familiar with it).