+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Release Kodi Selective Cleaner addon support (/showthread.php?tid=369984)
RE: Kodi Selective Cleaner addon support - HeresJohnny - 2024-06-04
You probably misread... there is a "Clean all" option but no "Analyse all" option.
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-04
(2024-06-04, 15:38)HeresJohnny Wrote: You probably misread... there is a "Clean all" option but no "Analyse all" option.
Correct. I am looking at an Analyze All option. I need feedback on the preferred output format (i.e. CSV, Text etc).
Thanks,
Jeff
RE: Kodi Selective Cleaner addon support - kittmaster - 2024-06-04
The problem/assumption with those formats is you're assuming we are on a PC/MAC where we can "Save/SaveAs", navigate, open, review, and then decide etc.
If you're on a Fire device, like: My Airstream Trailer, My living Room TV, My bedroom TV, My Kitchen TV, My Billiards Room TV... there is only the hand held remote to contend with and it makes it difficult to work with trying to save it as a physical format and open. If it did do that way, you'd have to initiate it as an auto launch/open after generation, allow user to use/navigate, then auto delete on close to ensure the files don't fill up the limited flash drive space those devices have for each time the application is initiated for that function.
Isn't there a way to create that file as you need it, read/parse it to the screen, and delete it on action/cancel?
IMHO, it really needs to be onscreen like each individual one you do now, there isn't a way to build each, and then concatenate them all together for a use case? It isn't like you are going to selectively "clear" an individual once you do a "view all" option, most will just run the clear all and be on their way. We just want to SEE what is invalid and it intends to remove... and then be able to cancel out if we know something is amiss and then use the individual ones you have in place otherwise. That is why I mention above to build it as behind the scenes, build, parse, combine, view, delete on action/cancel.
It seems Kodi allows array data (or static memory), each log would/should be a giant array of each log indexed from 0 to the end and then just pump it to the screen like you do for each individual...
I realize I'm short handing it, but that is the 30,000 foot view of how I see it based on all the work you've already done and "should" be an incremental step... but then again, I could be wrong.
Respectfully,
Chris.
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-05
(2024-06-04, 17:14)kittmaster Wrote: The problem/assumption with those formats is you're assuming we are on a PC/MAC where we can "Save/SaveAs", navigate, open, review, and then decide etc.
That wasn't the assumption I was making but I really appreciate your feedback. The assumption I was making is that folks, who might have lots of database issues, might not want to scroll through screens and screens of output and instead might want it in some type of output file for searching and analysis. How about another possibility where I provide an option in the addon setting to output an Analyze All function to either a file or the screen ? That way folks can choose. Without digging through the code but just thinking quickly about it, a text file output seems to make sense which would be easy to direct to the screen or a text file based upon the setting.
Thoughts everyone ?
Jeff
RE: Kodi Selective Cleaner addon support - HeresJohnny - 2024-06-05
As one of those users who orginally requested this component, personally I have no interest in extended analysis options. The per table option is enough for me and I feel your valuable time would be better spent furthering the development of music table cleaning. This is just one man's opinion, of course, and in the end the developer decides what is important to him.
RE: Kodi Selective Cleaner addon support - Meth0d - 2024-06-06
Speaking of Database, any idear what its trying to tell me with these (~80) messages while cleaning:
2024-06-06 20:24:26.101 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd12052f0>
2024-06-06 20:24:26.143 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1ccd518>
2024-06-06 20:24:26.180 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1c34220>
2024-06-06 20:24:26.225 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd19fa1e8>
2024-06-06 20:24:26.266 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1200c30>
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-06
(2024-06-06, 20:32)Meth0d Wrote: Speaking of Database, any idear what its trying to tell me with these (~80) messages while cleaning:
2024-06-06 20:24:26.101 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd12052f0>
2024-06-06 20:24:26.143 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1ccd518>
2024-06-06 20:24:26.180 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1c34220>
2024-06-06 20:24:26.225 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd19fa1e8>
2024-06-06 20:24:26.266 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1200c30>
Not offhand. That is odd. I may have instrumented a log message incorrectly. That's referencing a pointer vs. the underlying data of the pointer. Can you post the entire Kodi file to pastebin and let me see the entire session so I can try to figure it out ? And what clean function did you do, a table or All ?
Thanks,
Jeff
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-06
(2024-06-06, 20:32)Meth0d Wrote: Speaking of Database, any idear what its trying to tell me with these (~80) messages while cleaning:
2024-06-06 20:24:26.101 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd12052f0>
2024-06-06 20:24:26.143 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1ccd518>
2024-06-06 20:24:26.180 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1c34220>
2024-06-06 20:24:26.225 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd19fa1e8>
2024-06-06 20:24:26.266 T:1091 info <general>: KSCleaner db info: mysql <mysql.connector.connection.MySQLConnection object at 0xd1200c30>
Ok. I figured it out. This is an erroneous log message where I was instrumenting the code when adding the following feature in v1.0.6:
- Changed cleaning seasons from displaying season name to associated TV Show names
Thanks for reporting this. I'll remove these messages in the next version.
Jeff
RE: Kodi Selective Cleaner addon support - ManilaByNight - 2024-06-14
Can a feature to detect duplicate movies (and TV) for Android users be included? This is a feature for Kodi that can be of very much help for non-techies like me.
I posted this in the other thread and it was suggested that I ask this question here.
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-15
I have received a few asks for Kodi Selective Cleaner v1.0.7. Here's a list of requests so far with a slight feature description and comments. These are in the order I received them and not in any other order.
Add an analyze all option - In addition to the Clean All function in the Video Database Analyzer this would add an analyze all function which would output the results to either the screen or a text / CSV file based upon an addon setting option.
Music database analyzer - This would add the ability to analyze the Kodi music database similar to the current video database analyzer.
NFO file creator - Currently when you browse the Kodi database via Movies, TV Shows etc. when you get to the lower element you get a Feature Not Available message. This NFO file creator would add a menu option to allow you to create a stand-alone NFO file for the video database element you are positioned on.
Duplicate video detection - A new menu option would be added which would allow for detecting duplicate movies, videos, TV episodes etc.. in your Kodi database. This would be based upon the existing duplicate detection capabilities in the Mezzmo Kodi addon without the prevention capability.
For the NFO file creation the main questions are where would be the best to write them (i.e. a common folder for all or in the source location of the video / media file) ? Also which specific NFO file types ? For duplicate detection my main question is what constitutes a duplicate database entry (i.e. file name only, file name with extension, uniqueid etc..) ?
Please let me know your thoughts on the features with regards to functionality and order of preference (or not at all for some features above. I'll give folks a week to provide comments and then I'll start looking at the effort involved for each request.
Thanks,
Jeff
RE: Kodi Selective Cleaner addon support - kittmaster - 2024-06-15
(2024-06-15, 22:18)jbinkley60 Wrote: I have received a few asks for Kodi Selective Cleaner v1.0.7. Here's a list of requests so far with a slight feature description and comments. These are in the order I received them and not in any other order.
Add an analyze all option - In addition to the Clean All function in the Video Database Analyzer this would add an analyze all function which would output the results to either the screen or a text / CSV file based upon an addon setting option.
Music database analyzer - This would add the ability to analyze the Kodi music database similar to the current video database analyzer.
NFO file creator - Currently when you browse the Kodi database via Movies, TV Shows etc. when you get to the lower element you get a Feature Not Available message. This NFO file creator would add a menu option to allow you to create a stand-alone NFO file for the video database element you are positioned on.
Duplicate video detection - A new menu option would be added which would allow for detecting duplicate movies, videos, TV episodes etc.. in your Kodi database. This would be based upon the existing duplicate detection capabilities in the Mezzmo Kodi addon without the prevention capability.
For the NFO file creation the main questions are where would be the best to write them (i.e. a common folder for all or in the source location of the video / media file) ? Also which specific NFO file types ? For duplicate detection my main question is what constitutes a duplicate database entry (i.e. file name only, file name with extension, uniqueid etc..) ?
Please let me know your thoughts on the features with regards to functionality and order of preference (or not at all for some features above. I'll give folks a week to provide comments and then I'll start looking at the effort involved for each request.
Thanks,
Jeff
1 - Add an analyze all option (Since this was my request LOL) >> Nothing to add as most ideas have been presented
2 - Duplicate video detection >> This one has to be handled very carefully. Example Aliens (1986), Aliens (The Cocoon Cut) (1986), Aliens (Director's Cut) (1986), when parsed, it can't stop at just "Aliens" and say oh, there are 3 and nuke 2. So that is just an example.
3 - Music database analyzer - Features as requested by requester
4 - NFO file creator - This will need to have conditional logic checking. For those that don't have NFO's, build as you/they need/see fit... otherwise, like myself, I use Media Companion that is entirely NFO driven to import all data into Kodi an don't want any modifications made to the file by any extension externally since Media Companion is the Master to control all Meta for Kodi import.
That is my input based on your request.
Regards,
Chris
RE: Kodi Selective Cleaner addon support - Karellen - 2024-06-15
(2024-06-15, 22:18)jbinkley60 Wrote: For the NFO file creation the main questions are where would be the best to write them (i.e. a common folder for all or in the source location of the video / media file) ?I think that if you allow writing to a different location than what Kodi expects, you may cause confusion for some users not understanding why Kodi is not reading their off-location nfo files.
RE: Kodi Selective Cleaner addon support - ManilaByNight - 2024-06-16
(2024-06-15, 22:33)kittmaster Wrote:(2024-06-15, 22:18)jbinkley60 Wrote: I have received a few asks for Kodi Selective Cleaner v1.0.7. Here's a list of requests so far with a slight feature description and comments. These are in the order I received them and not in any other order.
Add an analyze all option - In addition to the Clean All function in the Video Database Analyzer this would add an analyze all function which would output the results to either the screen or a text / CSV file based upon an addon setting option.
Music database analyzer - This would add the ability to analyze the Kodi music database similar to the current video database analyzer.
NFO file creator - Currently when you browse the Kodi database via Movies, TV Shows etc. when you get to the lower element you get a Feature Not Available message. This NFO file creator would add a menu option to allow you to create a stand-alone NFO file for the video database element you are positioned on.
Duplicate video detection - A new menu option would be added which would allow for detecting duplicate movies, videos, TV episodes etc.. in your Kodi database. This would be based upon the existing duplicate detection capabilities in the Mezzmo Kodi addon without the prevention capability.
For the NFO file creation the main questions are where would be the best to write them (i.e. a common folder for all or in the source location of the video / media file) ? Also which specific NFO file types ? For duplicate detection my main question is what constitutes a duplicate database entry (i.e. file name only, file name with extension, uniqueid etc..) ?
Please let me know your thoughts on the features with regards to functionality and order of preference (or not at all for some features above. I'll give folks a week to provide comments and then I'll start looking at the effort involved for each request.
Thanks,
Jeff
1 - Add an analyze all option (Since this was my request LOL) >> Nothing to add as most ideas have been presented
2 - Duplicate video detection >> This one has to be handled very carefully. Example Aliens (1986), Aliens (The Cocoon Cut) (1986), Aliens (Director's Cut) (1986), when parsed, it can't stop at just "Aliens" and say oh, there are 3 and nuke 2. So that is just an example.
3 - Music database analyzer - Features as requested by requester
4 - NFO file creator - This will need to have conditional logic checking. For those that don't have NFO's, build as you/they need/see fit... otherwise, like myself, I use Media Companion that is entirely NFO driven to import all data into Kodi an don't want any modifications made to the file by any extension externally since Media Companion is the Master to control all Meta for Kodi import.
That is my input based on your request.
Regards,
Chris
Perhaps for duplicate video detection, title name detection after Kodi scrapes would be the option? Just my thoughts.
Would it be possible to add a column showing the path/location of the duplicate files for ease of locating them in multi hard drive server setups.
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-16
(2024-06-15, 22:53)Karellen Wrote: I think that if you allow writing to a different location than what Kodi expects, you may cause confusion for some users not understanding why Kodi is not reading their off-location nfo files.
Thanks for the feedback on this. Since I don't use the Kodi scrapers, NFO files and library management tools with my Kodi setups I am not always familiar with the normal usage and recommendations. This s helpful.
Jeff
RE: Kodi Selective Cleaner addon support - jbinkley60 - 2024-06-16
(2024-06-16, 00:32)ManilaByNight Wrote: Perhaps for duplicate video detection, title name detection after Kodi scrapes would be the option? Just my thoughts.
I am not looking to make it event based but you can run Kodi Selective Cleaner anytime you want on demand. If I implement this feature it will likely be based upon the major video categories (i.e. movies, episodes and music videos.), as well as an All option. As far as the duplicate detection I might be willing to do a couple of matches based upon the underlying filename and the Kodi title. I could see situations for both. Thoughts ? Maybe also sort title dupe checking ?
(2024-06-16, 00:32)ManilaByNight Wrote: Would it be possible to add a column showing the path/location of the duplicate files for ease of locating them in multi hard drive server setups.
Yes, that would likely be very easy to implement. I do it somewhat today with the Mezzmo Kodi addon. It's just simply a question of what data you want to see and the output format (i.e. screen, CSV, text file etc..). In this case I use the record number but it could just as easily be the full filename and path.
Thanks,
Jeff