+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Artwork Downloader (/showthread.php?tid=114633)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
- Martijn - 2011-11-15
Problem like paddycarey sayd.
Could you try this one:
https://github.com/downloads/Machine-Sanctum/script.artwork.downloader/script.artwork.downloader.zip
- paddycarey - 2011-11-15
PunkyMatt Wrote:Code:<setting id="limit_extrafanart_max" value="20,000000" />
<setting id="limit_extrafanart_rating" value="5,000000" />
This looks like the problem right there. Your locale uses "," instead of "." as a decimal separator. Should be a simple fix, thanks for reporting.
- User 52808 - 2011-11-15
Machine-Sanctum Wrote:There should be any
in your settings. Strange.Code:,
Could you try this one:
https://github.com/downloads/Machine-Sanctum/script.artwork.downloader/script.artwork.downloader.zip
paddycarey Wrote:This looks like the problem right there. Your locale uses "," instead of "." as a decimal separator. Should be a simple fix, thanks for reporting.
yeah that "," seemed strange to me when I looked into settings.xml to paste it here. I've checked settings for another script (cinema experience), and it has the same "," for decimal number so I tought it was normal.
But now I remember that cinema experience stopped working recently too, must be the same problem.
Thanks, I'm gonna try your new version as soon as my girlfriend has stopped playing with the Wii
and report back here.Do you think it's someting that needs to be fixed at script level, XBMC settings level (I'm using French as international settings) or is it something to fix systemwide ?
- Martijn - 2011-11-15
PunkyMatt Wrote:Do you think it's someting that needs to be fixed at script level, XBMC settings level (I'm using French as international settings) or is it something to fix systemwide ?Well if it fixes it it should stay in there just in case. Wasn't a major thing so.
Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.
Seems to me that this can cause more problems somewhere so maybe post your problem in the right section (maybe the PVR section) to get this looked at by the dev's.
- paddycarey - 2011-11-15
Should be something we can easily fix in the script. It's normal for some locales to use , instead of .
Not sure if it's always been this way or it was recently changed in xbmc.
- paddycarey - 2011-11-15
Machine-Sanctum Wrote:Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.
did you change your settings after the language switch? if you didn't then you won't have noticed a difference i don't think.
- User 52808 - 2011-11-15
Machine-Sanctum Wrote:Well if it fixes it it should stay in there just in case. Wasn't a major thing so.
Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.
Seems like a big problem for me, I've just checked I have these "," everywhere, even in xbmc guisettings.xml.
I compared it with my backed up guisettings.xml from before I upgrade to pre-Eden, and the Dharma one doesn't have the ","
for example
Code:
Dharma guisettings.xml
...
<defaultvideosettings>
<interlacemethod>0</interlacemethod>
<scalingmethod>1</scalingmethod>
<noisereduction>0.000000</noisereduction>
<sharpness>0.000000</sharpness>
<viewmode>0</viewmode>
<zoomamount>1.000000</zoomamount>
<pixelratio>1.000000</pixelratio>
...
<locale>
<charset>DEFAULT</charset>
<country>France</country>
<language>French</language>
<timezone>Europe/Paris</timezone>
<timezonecountry>France</timezonecountry>
</locale>
...
Eden guisettings:
...
<defaultvideosettings>
<deinterlacemode>0</deinterlacemode>
<interlacemethod>1</interlacemethod>
<scalingmethod>1</scalingmethod>
<noisereduction>0,000000</noisereduction>
<postprocess>false</postprocess>
<sharpness>0,000000</sharpness>
<viewmode>0</viewmode>
<zoomamount>1,000000</zoomamount>
<pixelratio>1,000000</pixelratio>
...
<locale>
<charset>DEFAULT</charset>
<country>France</country>
<language>French</language>
<timezone>Europe/Paris</timezone>
<timezonecountry>France</timezonecountry>
</locale>
...So this must be an XBMC problem, not a script problem.
- Martijn - 2011-11-15
PunkyMatt Wrote:Seems like a big problem for me, I've just checked I have these "," everywhere, even in xbmc guisettings.xml.
I compared it with my backed up guisettings.xml from before I upgrade to pre-Eden, and the Dharma one doesn't have the ","
So this must be an XBMC problem, not a script problem.
So you should definitely post this bug somewhere or create a trac bug ticket for this. Does this happen to only that build version or several?
Did it fix the issue for you or haven't you got the chance to try?
- User 52808 - 2011-11-15
Machine-Sanctum Wrote:So you should definitely post this bug somewhere or create a trac bug ticket for this. Does this happen to only that build version or several?
Did it fix the issue for you or haven't you got the chance to try?
didn't try yet, I can't get my girlfriend to stop playing on the Wii
It's the first pre Eden build I try, I installed it yesterday
- User 52808 - 2011-11-15
I just did a quick test, and everything's working fine if I change my XBMC languages to english.
I'll investigate further when I'll have some time and post a bug report when I'm sure the problem is not caused by me.
- Rastan - 2011-11-15
Machine-Sanctum Wrote:Thank you all for your comments.
So no issues so far
Now I am surprised
Thanks for the amazing plugin. Love all the new aditions you guys are making. One thing I noticed almost immediately after scraping is that I have posters unticked under movie settings, but it still downloads the poster.jpg anyway. Its not that big of a deal for me but thought I shoudl let you know.
- Martijn - 2011-11-15
Rastan Wrote:Thanks for the amazing plugin. Love all the new aditions you guys are making. One thing I noticed almost immediately after scraping is that I have posters unticked under movie settings, but it still downloads the poster.jpg anyway. Its not that big of a deal for me but thought I shoudl let you know.
Will look into that. It may just be a glitch of the dialog but none the less should be fixed.
EDIT:
You are right. Will fix.
- Martijn - 2011-11-16
Artwork Downloader - Eden11.0 ONLY: version 0.4.2.RC2
Available from download section.
Bug fixes:
- fixes downloading artwork not enabled for that mediatype
- Possible localization error (dot or comma). This a XBMC bug http://trac.xbmc.org/ticket/12215
- rich_stwrt - 2011-11-16
Have not had a chance to try this yet, will try a little later tonight when i can reclaim the TV from the family.
But, based on the features you have listed, I see one more that would be incredibly useful.
As far as TV shows, XBMC will always default to 'folder.jpg' as the artwork for the show. Some skins (like confluence) assume this is a banner, and let you set an option to use 'poster.jpg' as the artwork. Conversely, some skins (simplicity is the one i am familiar with) assume 'folder.jpg' is a poster and allow you to set an option to use 'banner.jpg'.
Since it does not appear the base code is going to move away from using 'folder.jpg' anytime in the near future, it would be useful as I am downloading the artwork to be able to either name the banner or the poster files 'folder.jpg' as they are downloaded. Even better would be to make a copy of the selected file (banner or poster) and name the copy 'folder.jpg'.
Or (and I'm really dreaming big here) how about the ability to bulk change the 'folder.jpg' to either a banner or poster.
Interestingly, I don't think there is an external scraper out there that has this functionality... if you could accomplish this you would be on the cutting edge.
Thanks for listening.
- Martijn - 2011-11-16
rich_stwrt Wrote:But, based on the features you have listed, I see one more that would be incredibly useful.
....
Interestingly, I don't think there is an external scraper out there that has this functionality... if you could accomplish this you would be on the cutting edge.
Thanks for listening.
It was already planned just not yet implemented. It will eventually, i just need to find the best way on how to do this and how this option needs to be shown in the settings.
Ember can do this in bulk mode.