Kodi Community Forum
Video does NOT play with some .m3u files - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Video Support (https://forum.kodi.tv/forumdisplay.php?fid=264)
+--- Thread: Video does NOT play with some .m3u files (/showthread.php?tid=370986)

Pages: 1 2

RE: Video does NOT play with some .m3u files - ultraman - 2023-01-02

After more testing I found the "problematic" code which makes different behaviour.
@CastagnaIT: Could you look? Looks like previously playlist was always treated as music playlist even if selected from Video window. Now this is not true anymore.

https://github.com/xbmc/xbmc/commit/40f5992102fc3299b2c07fdea2ee011803f4a28d#diff-116fe3583aebce74e1139ea69013e7489c848e02355191da026c4c552ec434db

sample m3u
cpp:
#EXTM3U

#EXTINF:123, Sample 1

http://127.0.0.1/extension_test.php

#EXTINF:123, Sample 2

http://127.0.0.1/extension_test.php


RE: Video does NOT play with some .m3u files - CastagnaIT - 2023-01-02

(2023-01-02, 18:49)ultraman Wrote: After more testing I found the "problematic" code which makes different behaviour.
@CastagnaIT: Could you look? Looks like previously playlist was always treated as music playlist even if selected from Video window. Now this is not true anymore.

https://github.com/xbmc/xbmc/commit/40f5992102fc3299b2c07fdea2ee011803f4a28d#diff-116fe3583aebce74e1139ea69013e7489c848e02355191da026c4c552ec434db

sample m3u
cpp:
#EXTM3U

#EXTINF:123, Sample 1

http://127.0.0.1/extension_test.php

#EXTINF:123, Sample 2

http://127.0.0.1/extension_test.php

i will try check
from video nav should be played video type not music type
its unclear why/how GUI influence the playlist type detection only for this particular case

RE: Video does NOT play with some .m3u files - ultraman - 2023-01-02

(2023-01-02, 19:09)CastagnaIT Wrote: from video nav should be played video type not music type
its unclear why/how GUI influence the playlist type detection only for this particular case
Don't forget this is still playlist with video links.
True: it should be clear how things should work. Like what is correct behaviour: before this change or with it. Maybe previously it was just a coincidence that it worked Smile

RE: Video does NOT play with some .m3u files - emveepee - 2023-01-02

(2023-01-02, 19:09)CastagnaIT Wrote: i will try check
from video nav should be played video type not music type
its unclear why/how GUI influence the playlist type detection only for this particular case
I think it is because the logic only uses the hint when it is both isVideo() && isAudio()  The hint should probably also be used when it is neither. 

Martin

RE: Video does NOT play with some .m3u files - CastagnaIT - 2023-01-02

(2023-01-02, 19:17)ultraman Wrote:
(2023-01-02, 19:09)CastagnaIT Wrote: from video nav should be played video type not music type
its unclear why/how GUI influence the playlist type detection only for this particular case
Don't forget this is still playlist with video links.
True: it should be clear how things should work. Like what is correct behaviour: before this change or with it. Maybe previously it was just a coincidence that it worked Smile

yeah i tried a first investigation
and i confirm there is something weird also on kodi v19.4 (and old versions)
my PR has only highlighted this problem(?) on v19.5 (and v20)

you can reproduce the same problem(?) also on v19.4 in this way:
go to Kodi Player settings -> Music -> and disable: "Play next song automatically"
when this setting is disabled make kodi to play the video item from a different code path that raise the setInfo warning

i will need go more deeper to try understand what happens

this setting above also highlight that the GUI class on 19.4 is wrongly mixed (music instead video) that my PR has fixed
 
Quote:I think it is because the logic only uses the hint when it is both isVideo() && isAudio()  The hint should probably also be used when it is neither
Perhaps, but what i want to understand why with one method works and other one not

RE: Video does NOT play with some .m3u files - CastagnaIT - 2023-01-03

i made a fix PR https://github.com/xbmc/xbmc/pull/22381
someone can test and give a feedback?
if needed i can provide a test build just let me know for what system (android, windows, mac)

RE: Video does NOT play with some .m3u files - knb_limbiko - 2023-01-03

(2023-01-03, 15:06)CastagnaIT Wrote: i made a fix PR https://github.com/xbmc/xbmc/pull/22381
someone can test and give a feedback?
if needed i can provide a test build just let me know for what system (android, windows, mac)

Could you please share test build for Windows?

RE: Video does NOT play with some .m3u files - emveepee - 2023-01-03

(2023-01-03, 15:06)CastagnaIT Wrote: i made a fix PR https://github.com/xbmc/xbmc/pull/22381
someone can test and give a feedback?
if needed i can provide a test build just let me know for what system (android, windows, mac)

I have master running here an that change works and it uses the hint.  Note the changed code is not touched if it the m3u is in a Music folder instead it it gets the MIME type  and it then uses the VideoPlayer or PAPlayer
 
Code:
2023-01-03 09:56:49.158 T:12788   debug <general>: CCurlFile::XFILE::CCurlFile::GetMimeType - <http://172.16.3.236:9981/stream/channelid/1652894646?profile=pass> -> video/mp2t

I do get the same annoying click I read about here https://discourse.coreelec.org/t/a-crackling-loud-click-when-starting-a-network-radio-stream/19867 with PAPlayer,  but that's a problem in Matrix too.

Martin

RE: Video does NOT play with some .m3u files - CastagnaIT - 2023-01-03

Windows64 test build: http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20230103-8a53fadd-playlist_fix-x64.exe

"Favourite" menu has problem to play playlist file with a single path, i fixed it too late

Just to let you know, another way to workaround the problem to avoid modify each .m3u file
is play the playlist video item by using context menu "Play from here"

RE: Video does NOT play with some .m3u files - knb_limbiko - 2023-01-03

(2023-01-03, 18:50)CastagnaIT Wrote: Windows64 test build: http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20230103-8a53fadd-playlist_fix-x64.exe

"Favourite" menu has problem to play playlist file with a single path, i fixed it too late

Just to let you know, another way to workaround the problem to avoid modify each .m3u file
is play the playlist video item by using context menu "Play from here"
Works no problem. Thx

RE: Video does NOT play with some .m3u files - ultraman - 2023-01-03

(2023-01-03, 18:50)CastagnaIT Wrote: Just to let you know, another way to workaround the problem to avoid modify each .m3u file
is play the playlist video item by using context menu "Play from here"
Yes, but it is little annoying Smile

RE: Video does NOT play with some .m3u files - roisiano - 2023-01-03

Hello.

I confirm that IS WORKING with tvheadend .m3u files.

Thanks and kind regards