v22 I can't get PVR recordings to play - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32) +--- Forum: Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=26) +---- Forum: PVR (https://forum.kodi.tv/forumdisplay.php?fid=136) +---- Thread: v22 I can't get PVR recordings to play (/showthread.php?tid=380163) Pages:
1
2
|
RE: I can't get PVR recordings to play - ksooo - 2025-01-18 > Compiled the PR with the fix and working as before @A600 thanks for letting me know. RE: I can't get PVR recordings to play - A600 - 2025-01-23 @ksooo I noticed that with the pvr.iptvsimple recordings, playback actions related to the queue playlist (play from here, play next, continue watching,...) fail. It can easily be reproduced with "Play from here" or just adding the recording to the queue and trying to play it from the queue playlist. Use the same m3u I posted before with iptvsimple. From the queue playlist the recording fails to be played but it plays without problems using "Play recording" from the "Recording Information" dialog: This is the debug log with the latest master that already includes the [video][music] Fix playback of PVR recordings provided by add-ons implementing URL-based playback PR: kodi.log RE: I can't get PVR recordings to play - ksooo - 2025-01-23 Please open an issue at github. RE: I can't get PVR recordings to play - ksooo - 2025-01-23 @A600 could you give this patch a try: ``` diff --git a/xbmc/PlayListPlayer.cpp b/xbmc/PlayListPlayer.cpp index f9aba33733..95c0e85a3d 100644 --- a/xbmc/PlayListPlayer.cpp +++ b/xbmc/PlayListPlayer.cpp @@ -354,7 +354,13 @@ bool CPlayListPlayer:lay(int iSong, m_bPlaybackStarted = false; const auto playAttempt = std::chrono:teady_clock::now(); - bool ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection); + + bool ret{false}; + if ((MUSIC::IsAudio(*item) || VIDEO::IsVideo(*item)) && !item->IsPVR()) + ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection); + else + ret = g_application.PlayMedia(*item, player, m_iCurrentPlayList); + if (!ret) { CLog::Log(LOGERROR, "Playlist Player: skipping unplayable item: {}, path [{}]", m_iCurrentSong, ``` RE: I can't get PVR recordings to play - A600 - 2025-01-23 (Yesterday, 21:09)ksooo Wrote: @A600 could you give this patch a tryPerfect! A million thanks. RE: I can't get PVR recordings to play - ksooo - 2025-01-23 (Yesterday, 21:48)A600 Wrote:(Yesterday, 21:09)ksooo Wrote: @A600 could you give this patch a tryPerfect! A million thanks. Does this mean you have tested the patch and it works? RE: I can't get PVR recordings to play - A600 - 2025-01-23 Yes. Tested and working flawlessly. RE: I can't get PVR recordings to play - ksooo - 2025-01-24 @A600 https://github.com/xbmc/xbmc/pull/26346 RE: I can't get PVR recordings to play - A600 - 2025-01-24 (Today, 09:18)ksooo Wrote: https://github.com/xbmc/xbmc/pull/26346 Tested and no regressions detected. RE: I can't get PVR recordings to play - ksooo - 2025-01-24 > Tested and no regressions detected. But I have. That PR needs a bit more love from my end. RE: I can't get PVR recordings to play - A600 - 2025-01-24 @ksooo After more testings I found a problem. With this m3u that has 4 recordings: Code: #EXTM3U if I play the folder after the first recording (Recording 1) is finished, the next recording played is still the same Recording 1 so it seems the playlist doesn't advance. Latest master with the PR applied: kodi.log RE: I can't get PVR recordings to play - ksooo - 2025-01-24 > after the first recording (Recording 1) is finished, the next recording played is still the same Recording 1 so it seems the playlist doesn't advance. That's the same regression I found, yes. |