Quote:2021-06-14 17:13:54.507 T:9936 ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'ModuleNotFoundError'>
Error Contents: No module named 'YoutubeDLWrapper'
Traceback (most recent call last):
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\main.py", line 56, in onClick
self.main.downloadPlaying()
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\main.py", line 99, in downloadPlaying
from lib import YDStreamExtractor
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\YDStreamExtractor.py", line 6, in
import YoutubeDLWrapper
ModuleNotFoundError: No module named 'YoutubeDLWrapper'
-->End of Python script error report<--

(2021-06-14, 20:32)Steph09 Wrote: I'm having the same issue since upgrading to Kodi 19. Whenever I click the 'download currently playing video' button nothing happens.

This is what the log says.

Quote:2021-06-14 17:13:54.507 T:9936 ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'ModuleNotFoundError'>
Error Contents: No module named 'YoutubeDLWrapper'
Traceback (most recent call last):
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\main.py", line 56, in onClick
self.main.downloadPlaying()
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\main.py", line 99, in downloadPlaying
from lib import YDStreamExtractor
File "C:\Users\stefm\AppData\Roaming\Kodi\addons\script.module.youtube.dl\lib\YDStreamExtractor.py", line 6, in
import YoutubeDLWrapper
ModuleNotFoundError: No module named 'YoutubeDLWrapper'
-->End of Python script error report<--

1. I do not like addons putting exported code in lib, but rather a child directory with something identifying it what it belongs to. I'm concerned that the namespace (top level python path) could get a bit cluttered.
   
2. Along with the previous change, the imports had to change as well. Sigh. Sorry.
   
3. There were some who were using an older version on python 2 kodi, and I suppose wanted the door open to continue updating it.
   

1. The port to the new yt-dlp lib is not so bad.
   
2. The problem is that there seem to be a backlog of problems in the YouTubeDL wrapper code. Many of these appear to be due to the Python 3 migration. I have found places where strings are being converted to hex and back when they don't need to. It is also common to not specify encoding options on file operations.
   
3. My big accomplishment today was to be able to download something playing on Youtube using the YouTubeDL-Control app. Never mind that the file name is very long garbage, etc. The main thing is that it sort of worked.
   

python:


from urllib.parse import urlencode



filename = "non-ääsci"

url = "example.xyz/video/12345"



# Download path

target_dir = xbmcvfs.translatePath("special://temp").encode("utf-8", "surrogateescape")

filepath = os.path.join(target_dir, filename.encode("utf-8", "surrogateescape"))



# Download remote file.

res = requests.get(url, stream=True)



# Open filename (utf-8 encoded) and write downloaded data as binary data.

with open(filepath, "ab") as file:

    for chunk in res.iter_content(chunk_size=1024**2):

        file.write(chunk)



# Create list item entry for downloaded file.

list_item = xbmcgui.ListItem(label=filename.encode("utf-8", "surrogateescape"))

# From memory it is best to give unicode to urlencode

attrs = {"local_file_playback": filepath.decode("utf-8", "surrogateescape")}

param_string = urlencode(attrs, encoding="utf-8", errors="surrogateescape")

callback_url =  f"plugin://{addon_id}/?{param_string}"

listing = (callback_url, list_item, False)