v17 - Grid for Krypton - Printable Version

v17 Grid for Krypton - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Skin Archive (https://forum.kodi.tv/forumdisplay.php?fid=179)
+----- Forum: Grid (https://forum.kodi.tv/forumdisplay.php?fid=280)
+----- Thread: v17 Grid for Krypton (/showthread.php?tid=318152)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74

RE: Grid - Public beta available - Designer - 2017-08-25

Again not an issue but just a thought. For the ratings in "Slide" view, have you considered adding the star from "List" view to give that number more context? Or possibly moving it to the end of the row so it's not right by all the other numbers? I feel like it works better for a quick read. I know these little things in design are subjective.

RE: Grid - Public beta available - kingogondo - 2017-08-25

@Jeroen

I don't get the 1.1.2 Update. Nvidia Shield TV 2015. Kodi 17.4.

Updated the Repo, 1.1.1 is the last Update.

Language Flage Colour Flat fails to install.

Again, Thank you for your work and especially for your support here.

RE: Grid - Public beta available - VikkiXavier - 2017-08-25

Gallery images appear at a bit Low Quality (as you can see in the image below), unless I press the entire button to view on full screen of course. Is this a skin issue, or is this supposed to be like this, Jeroen?

RE: Grid - Public beta available - Luke Cage - 2017-08-25

@Jeroen
v1.1.2 : Looks like you have a typo on line 8 of special://profile/addons/skin.grid/xml/Variables.xml, the opening "[" (just before method Skin.HasSetting) should be removed.

Code:
<value condition="Player.HasAudio + [Skin.HasSetting(home.nowplaying) + System.HasAddon(script.artistslideshow)">$INFO[Window(Visualisation).Property(ArtistSlideshow)]</value>

Corresponding log entries :

Code:
03:12:39.871 T:139673051220032   ERROR: Unmatched [

03:12:39.871 T:139673051220032   ERROR: Error parsing boolean expression Player.HasAudio + [Skin.HasSetting(home.nowplaying) + System.HasAddon(script.artistslideshow)

RE: Grid - Public beta available - Jeroen - 2017-08-25

(2017-08-24, 22:27)TheLastOfUs Wrote: I noticed a few people having issues with the animated background of grid

Yeah, I haven't gotten to looking into this one yet. It's on my list Smile

(2017-08-24, 23:01)Designer Wrote: In category view, the progress bar lines up with the clock but on the homescreen it is shifted up and to the right. It's lined up on initial load but if I go into movies and then back to the homescreen, it shifts.

Check. Cheers!

Quote:This one is not so much an issue but more of a consistency thing. Any thought to adding "Finishes At xx:xx" to TV episodes like you have for movies?

That's definitely an oversight. Will add, thanks.

(2017-08-24, 23:33)ellega Wrote: wall type view is planned in a future ?

Not very likely, but you never know.

(2017-08-25, 00:02)maxtherabbit Wrote: I found a way to make that PVR guide info header look nicer.

Sorry, I forgot to extend the fix for this for "normal" episodes to PVR items.

You don't need three lines for that btw Smile

When you make the localized string a part of the infolabel, the localized string will only display if the accompanying infolabel exists, like so:

PHP Code:
$INFO[ListItem.Episode,$LOCALIZE[20359] ] 

That way you don't need to have a fallback for each of the three "scenario's" Smile

(2017-08-25, 00:50)manuelriver36 Wrote: With the latest update, the widget background is displayed correctly on Android TV / Nvidia Shiled, thanks for the update

Good to know, cheers !

(2017-08-25, 01:17)Designer Wrote: Again not an issue but just a thought. For the ratings in "Slide" view, have you considered adding the star from "List" view to give that number more context? Or possibly moving it to the end of the row so it's not right by all the other numbers? I feel like it works better for a quick read. I know these little things in design are subjective.

I like that actually, I'll put it on my list.

(2017-08-25, 01:43)kingogondo Wrote: Language Flage Colour Flat fails to install.

Just to be clear, that add-on is not needed for Grid. Actually it is not used by Grid at all.

(2017-08-25, 03:50)VikkiXavier Wrote: Gallery images appear at a bit Low Quality (as you can see in the image below), unless I press the entire button to view on full screen of course. Is this a skin issue, or is this supposed to be like this, Jeroen?

Yeah, noticed that too. I'm not sure why exactly that is happening. Basically I am just loading the artwork provided by Artwork Downloader in a simple list control. There's really not that much that I could do differently.

Yet when I use a single image control in a test to display just one of the available images the quality is much better. I don't think it's a skin issue, but either Kodi or Artwork Downloader displays these at lower quality when they are used in a list control.

There is a solution for it (sort of), which is to not use the standard infolabel for this (the same as used in the library to show fanart, posters, etc) but the direct relative path to the artwork. This willl show the images at higher quality, but it will make this feature dependant on your local filesystem. Which is something I never like to do as it means it will not work for people who use different ways to organize their artwork. It will also not work for people who have set their artwork to de stored centrally (so not in the filepath of the movie or show). I might look into creating setting for this, but I really don't want the skin to end up with 200 skin toggles. Also, I i believe there are plans to integrate extended artwork support into Kodi, which could make all of that impossible or not needed again.
So, I would like a solution for it, but for now its a longer term thing.

(2017-08-25, 03:57)Luke Cage Wrote: Looks like you have a typo

Yup. Fixed (not on repo). Cheers

RE: Grid - Public beta available - Jeroen - 2017-08-25

Grid 1.1.3 available on the repo with a bunch of fixes. Also, special thanks to @RealJohnGalt for optimizations and enhancements to the colorbox support in this release Smile

RE: Grid - Public beta available - VikkiXavier - 2017-08-25

(2017-08-25, 07:49)Jeroen Wrote:
(2017-08-25, 03:50)VikkiXavier Wrote: Gallery images appear at a bit Low Quality (as you can see in the image below), unless I press the entire button to view on full screen of course. Is this a skin issue, or is this supposed to be like this, Jeroen?

Yeah, noticed that too. I'm not sure why exactly that is happening. Basically I am just loading the artwork provided by Artwork Downloader in a simple list control. There's really not that much that I could do differently.

Yet when I use a single image control in a test to display just one of the available images the quality is much better. I don't think it's a skin issue, but either Kodi or Artwork Downloader displays these at lower quality when they are used in a list control.

There is a solution for it (sort of), which is to not use the standard infolabel for this (the same as used in the library to show fanart, posters, etc) but the direct relative path to the artwork. This willl show the images at higher quality, but it will make this feature dependant on your local filesystem.

I know you're a busy person ,but could you kindly elaborate the implementation of "direct relative path to the artwork" so I could work it out myself

RE: Grid - Public beta available - Jeroen - 2017-08-25

(2017-08-25, 09:00)VikkiXavier Wrote: I know you're a busy person ,but could you kindly elaborate the implementation of "direct relative path to the artwork" so I could work it out myself

Right now in DialogVideoInfo.xml you'll see a block of code that starts with

Code:
<!--gallery-->

<control type="group" id="9998">

A bit lower it will call the fanart (twice):

Code:
<texture>$INFO[ListItem.Thumb]</texture>

(which is actually a to be deprecated way, I should have used ListItem.Art(thumb) here, but it still works the same Smile

)

This will pull in the fanart as it is made available through the database.

Replacing this line with:

Code:
<texture>$INFO[Container(9998)ListItem(0).FileNameAndPath]</texture>

Will skip the database and pull the images directly from the actual place you stored it (your harddrive, removable drive, network share, etc)

RE: Grid - Public beta available - VikkiXavier - 2017-08-25

Wow. Thank you for the swift reply, jery. Will do so first thing i return home

RE: Grid - Public beta available - lstar337 - 2017-08-25

(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 1. Option to set a different image for each menu item (as is possible in reFocus).
2. Option to disable the pan-zoom fanart visual effect on the home screen but keep it for library views.
1. Unlikely, sorry
2. Maybe

No worries, and thanks.

(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 3. In the library, make keyboard letter presses jump to the corresponding section in the library.
Not possible, skins don't have this kind of control over key presses.

Really? I have seen this functionality used in other skins for a while now. Undecided

(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 4. In the paused status bar, find a way to incorporate the 'finish time' of the movie.
Tried something like that before, didn't really work out that well. Maybe at some point.

I remember this in reFocus (though not the later versions) and it was a nice touch.

(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 2. (this is just my opinion) I hate the flashing clock. (sorry )
Flashing is a big word for a slowly blinking clock

Lol, I now realise how that looks when read quickly! So no option to disable the blinking dots?

RE: Grid - Public beta available - VikkiXavier - 2017-08-25

Just help me out with one more issue please. How do i view the trailer in dialogvidinfo? This is last request of mine. Please help me out wit this

RE: Grid - Public beta available - Jeroen - 2017-08-25

(2017-08-25, 10:32)lstar337 Wrote:
(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 3. In the library, make keyboard letter presses jump to the corresponding section in the library.
Not possible, skins don't have this kind of control over key presses.
Really? I have seen this functionality used in other skins for a while now.

All I know of is a scrollbar like column of letters you can focus on and then press to skip to a particular section in a library. Which, without having investigated it, would seem to be useless for non latin character based languages.
And there's the SHIFT+<character>, which is standard Kodi functionality.

If you're talking about just pressing any letter, I am very curious to know which skins have this sort of superpower. Apart from that it would break default keyboard shortcuts (what would happen if you press I? Does the video/music information screen open? Or does it jump to a library section?)

The only control over keypresses skins have:

<onleft>, <onright>, <onup>, <ondown>

And in some situations:

<onback>, <oninfo>, select

That's it..

i can't imagine wer're talking about the same thing.

Quote:I remember this in reFocus (though not the later versions) and it was a nice touch.

Well, I'm not saying it's technically impossible to do. It's just that Grid != reFocus and the fact that reFocus had certain things doesn't mean they will be there in Grid too.
The finish time is shown in the fullscreen info, which is just 1 keypress away,

(2017-08-24, 19:15)Jeroen Wrote:
(2017-08-24, 16:07)lstar337 Wrote: 2. (this is just my opinion) I hate the flashing clock. (sorry )
Flashing is a big word for a slowly blinking clock

Quote:Lol, I now realise how that looks when read quickly! So no option to disable the blinking dots?

No, sorry. There's just has to be a limit to customization at some point. As said, I don't want the skin to end up with 200 skin toggles and have a visibility switch for anything you see on screen.

RE: Grid - Public beta available - lstar337 - 2017-08-25

(2017-08-25, 10:57)Jeroen Wrote: All I know of is a scrollbar like column of letters you can focus on and then press to skip to a particular section in a library. Which, without having investigated it, would seem to be useless for non latin character based languages.
And there's the SHIFT+<character>, which is standard Kodi functionality.

If you're talking about just pressing any letter, I am very curious to know which skins have this sort of superpower. Apart from that it would break default keyboard shortcuts.

i can't imagine wer're talking about the same thing.

Duh, yes you are right and I am an idiot! Rofl

It is Shift+letter!! Rofl

(2017-08-25, 10:57)Jeroen Wrote: Well, I'm not saying it's technically impossible to do. It's just that Grid != reFocus and the fact that reFocus had certain things doesn't mean they will be there in Grid too.

Quite right.

(2017-08-25, 10:57)Jeroen Wrote: The finish time is shown in the fullscreen info, which is just 1 keypress away,

Yeah, just realised this too. It's all I was after tbh, just didn't know it was there!

(2017-08-24, 19:15)Jeroen Wrote: No, sorry. There's just has to be a limit to customization at some point. As said, I don't want the skin to end up with 200 skin toggles and have a visibility switch for anything you see on screen.

Fair enough. Maybe I can put a square of black tape over the corner of the screen. Wink

RE: Grid - Public beta available - maxtherabbit - 2017-08-25

(2017-08-25, 07:49)Jeroen Wrote:
(2017-08-25, 00:02)maxtherabbit Wrote: I found a way to make that PVR guide info header look nicer.
Sorry, I forgot to extend the fix for this for "normal" episodes to PVR items.

You don't need three lines for that btw

When you make the localized string a part of the infolabel, the localized string will only display if the accompanying infolabel exists, like so:

PHP Code:
$INFO[ListItem.Episode,$LOCALIZE[20359] ]

That way you don't need to have a fallback for each of the three "scenario's"

This is what I was trying to fix.

I've updated my fix based on version 1.1.3, now with bold episode titles.

Code:
<value condition="Window.IsActive(pvrguideinfo) + String.IsEmpty(ListItem.Season) + String.IsEmpty(ListItem.Episode)">$INFO[ListItem.EpisodeName,[B],[/B]]</value>

<value condition="Window.IsActive(pvrguideinfo) + [String.IsEmpty(ListItem.Season) | String.IsEmpty(ListItem.Episode)]">$INFO[ListItem.EpisodeName,[B],[/B] - ]$INFO[ListItem.Season,$LOCALIZE[20373] ,]$INFO[ListItem.Episode,$LOCALIZE[20359] ,]</value>

<value condition="Window.IsActive(pvrguideinfo) + !String.IsEmpty(ListItem.Season) + !String.IsEmpty(ListItem.Episode)">$INFO[ListItem.EpisodeName,[B],[/B] - ]$INFO[ListItem.Season,$LOCALIZE[20373] ,$COMMA ]$INFO[ListItem.Episode,$LOCALIZE[20359] ,]</value>

RE: Grid - Public beta available - Jeroen - 2017-08-25

(2017-08-25, 10:38)VikkiXavier Wrote: Just help me out with one more issue please. How do i view the trailer in dialogvidinfo? This is last request of mine. Please help me out wit this

You're going to have to add a videocontrol to the window

http://kodi.wiki/view/Video_Control