+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Subtitle Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=143)
+---- Thread: Release service.subtitles.subscene (/showthread.php?tid=184854)
RE: service.subtitles.subscene - snyft - 2020-04-06
(2020-04-06, 11:37)juuser Wrote:(2020-04-06, 08:16)snyft Wrote: Does not work on latest Matrix nightly.
Can you provide errors, which are logged into Kodi log file?
2020-04-06 13:27:02.608 T:9888 DEBUG: CAddonInstaller: installing from zip 'G:\service.subtitles.subscene-1.8.2.zip'
2020-04-06 13:27:02.639 T:5328 DEBUG: CAddonInstallJob[service.subtitles.subscene]: requires xbmc.python version 2.14.0 which is not available
2020-04-06 13:27:02.639 T:5328 ERROR: CAddonInstallJob[service.subtitles.subscene]: The dependency on xbmc.python version 2.14.0 could not be satisfied.
RE: service.subtitles.subscene - juuser - 2020-04-06
(2020-04-06, 13:35)snyft Wrote:It is probably caused by this: https://github.com/jarmo/service.subtitles.subscene/blob/master/addon.xml#L6-L8(2020-04-06, 11:37)juuser Wrote:(2020-04-06, 08:16)snyft Wrote: Does not work on latest Matrix nightly.
Can you provide errors, which are logged into Kodi log file?
2020-04-06 13:27:02.608 T:9888 DEBUG: CAddonInstaller: installing from zip 'G:\service.subtitles.subscene-1.8.2.zip'
2020-04-06 13:27:02.639 T:5328 DEBUG: CAddonInstallJob[service.subtitles.subscene]: requires xbmc.python version 2.14.0 which is not available
2020-04-06 13:27:02.639 T:5328 ERROR: CAddonInstallJob[service.subtitles.subscene]: The dependency on xbmc.python version 2.14.0 could not be satisfied.
You probably have other version of xbmc.python installed (probably a newer one?). I'm not too familiar with Kodi plugins as to know if it is possible to set a more "relaxed" version requirement to the plugin. @AnonTester maybe you know how to solve this problem so that this plugin would work in more situations?
RE: service.subtitles.subscene - AnonTester - 2020-04-07
Kodi comes bundled with python and does not use python that may be installed on the system. Kodi 18 and before came with Python 2, early Kodi 19 alphas as well, the more recent ones come with Python 3.
The change to Python 3 required pretty much all addons to be adjusted to be compatible with both Python 2 and 3. Earlier this year Team Kodi decided to classify all addons as incompatible that do not specifically require Python 3, regardless whether they work with Python 2 and 3 or not. Addon devs now have to either maintain 2 versions with different version numbers, abandon Kodi 18 support or just concentrate on Kodi 18 until Kodi 19 has been released.
The addon.xml file as referenced by @juuser is where the python requirement is set and what Kodi 19 looks at. If the python version is not at least 3.0.0, it will refuse to install the addon. Editing the addon.xml file will solve this. However, this addon also requires the kodi-vfs-libarchive and/or kodi-vfs-rar addons to be installed in a compatible version to be able to extract subtitles from rar files. Those addons broke recently and have not been upgraded yet.
RE: service.subtitles.subscene - snyft - 2020-04-07
(2020-04-07, 00:20)AnonTester Wrote: Kodi comes bundled with python and does not use python that may be installed on the system. Kodi 18 and before came with Python 2, early Kodi 19 alphas as well, the more recent ones come with Python 3.I edited the xml file for 3.0.0 and it still did not install.
The change to Python 3 required pretty much all addons to be adjusted to be compatible with both Python 2 and 3. Earlier this year Team Kodi decided to classify all addons as incompatible that do not specifically require Python 3, regardless whether they work with Python 2 and 3 or not. Addon devs now have to either maintain 2 versions with different version numbers, abandon Kodi 18 support or just concentrate on Kodi 18 until Kodi 19 has been released.
The addon.xml file as referenced by @juuser is where the python requirement is set and what Kodi 19 looks at. If the python version is not at least 3.0.0, it will refuse to install the addon. Editing the addon.xml file will solve this. However, this addon also requires the kodi-vfs-libarchive and/or kodi-vfs-rar addons to be installed in a compatible version to be able to extract subtitles from rar files. Those addons broke recently and have not been upgraded yet.
RE: service.subtitles.subscene - AnonTester - 2020-04-07
You edited the line with the python version requirement and not the addon version itself? What's the error message you get? If it's the same error message, then the addon.xml wasn't changed properly.
RE: service.subtitles.subscene - snyft - 2020-04-10
(2020-04-07, 16:36)AnonTester Wrote: You edited the line with the python version requirement and not the addon version itself? What's the error message you get? If it's the same error message, then the addon.xml wasn't changed properly.
Edit: I'm dumb and did not save the edit or something. It works fine. Sorry.
RE: service.subtitles.subscene - AnonTester - 2020-04-10
You're not dumb. Mistakes can happen. It's all good and glad you got it working. Thanks for confirming!
RE: service.subtitles.subscene - juuser - 2020-04-14
(2020-04-07, 00:20)AnonTester Wrote: Kodi comes bundled with python and does not use python that may be installed on the system. Kodi 18 and before came with Python 2, early Kodi 19 alphas as well, the more recent ones come with Python 3.So, what would you suggest as a plugin maintainer to do at this point? Maybe one possible solution would be to create a separate branch in git for Kodi 18 and leave it intact, but create a separate version for Kodi 19 only having Python 3 compatible code in it and release it separately? Does that sound like a reasonable plan to move forward even before Kodi 19 is released officially?
The change to Python 3 required pretty much all addons to be adjusted to be compatible with both Python 2 and 3. Earlier this year Team Kodi decided to classify all addons as incompatible that do not specifically require Python 3, regardless whether they work with Python 2 and 3 or not. Addon devs now have to either maintain 2 versions with different version numbers, abandon Kodi 18 support or just concentrate on Kodi 18 until Kodi 19 has been released.
The addon.xml file as referenced by @juuser is where the python requirement is set and what Kodi 19 looks at. If the python version is not at least 3.0.0, it will refuse to install the addon. Editing the addon.xml file will solve this. However, this addon also requires the kodi-vfs-libarchive and/or kodi-vfs-rar addons to be installed in a compatible version to be able to extract subtitles from rar files. Those addons broke recently and have not been upgraded yet.
RE: service.subtitles.subscene - AnonTester - 2020-04-14
See https://forum.kodi.tv/showthread.php?tid=351745 for the updated requirements. As the code is py2 and 3 compatible, the only change between Kodi 18 and 19 is the addon.xml file and if you maintain repositories, the version numbers need to be different.
It's up to you if maintaining multiple branches in git makes sense just for that. You could keep a single branch but just create 2 'release' zip files for each kodi version.
RE: service.subtitles.subscene - juuser - 2020-04-14
(2020-04-14, 11:52)AnonTester Wrote: See https://forum.kodi.tv/showthread.php?tid=351745 for the updated requirements. As the code is py2 and 3 compatible, the only change between Kodi 18 and 19 is the addon.xml file and if you maintain repositories, the version numbers need to be different.
It's up to you if maintaining multiple branches in git makes sense just for that. You could keep a single branch but just create 2 'release' zip files for each kodi version.
My main idea behind that was that if Python3 is the only way moving forward with Kodi then having Python2 code from code maintainability point of view does not make much sense. But I agree that let's not do that before Kodi 19 is officially out and your proposed solution to just have a different zip files with different addons make much more sense. I will create that and let here know when it's done.
RE: service.subtitles.subscene - juuser - 2020-04-18
Starting from version 1.9.0 a separate release is created having "kodi19" in its filename. Download 1.9.0 from here: https://github.com/jarmo/service.subtitles.subscene/releases/tag/1.9.0
RE: service.subtitles.subscene - User 99401 - 2020-04-19
(2020-04-18, 22:12)juuser Wrote: Starting from version 1.9.0 a separate release is created having "kodi19" in its filename. Download 1.9.0 from here: https://github.com/jarmo/service.subtitles.subscene/releases/tag/1.9.0
Excellent!! tested on v19 and works well (of course...)
Will this be pushed to repo eventually? as there are so many versions of Subscene out there...
thanks!!
service.subtitles.subscene - rsmq111 - 2020-04-19
(2020-04-18, 22:12)juuser Wrote: Starting from version 1.9.0 a separate release is created having "kodi19" in its filename. Download 1.9.0 from here: https://github.com/jarmo/service.subtitles.subscene/releases/tag/1.9.0
update number not changed
service.subtitles.subscene - rsmq111 - 2020-04-19
(2020-04-18, 22:12)juuser Wrote: Starting from version 1.9.0 a separate release is created having "kodi19" in its filename. Download 1.9.0 from here: https://github.com/jarmo/service.subtitles.subscene/releases/tag/1.9.0
films, research is excellent
But series are bad research
RE: service.subtitles.subscene - User 99401 - 2020-04-20
(2020-04-19, 10:56)rsmq111 Wrote:seems to stop working again.(2020-04-18, 22:12)juuser Wrote: Starting from version 1.9.0 a separate release is created having "kodi19" in its filename. Download 1.9.0 from here: https://github.com/jarmo/service.subtitles.subscene/releases/tag/1.9.0
films, research is excellent
But series are bad research
Search is OK, however when download it says no srt file in it...