(2021-07-18, 17:43)pkscout Wrote: Just an FYI that there is a release coming soon to fix the IMDB ratings (IMDB updated their web site, which broke the HTML scrape to get the ratings).  Special thanks to gumida for reporting this and submitting a patch to fix it.  Please note this fix will be available for Matrix only. No further updates are being done for Leia.

(2022-07-01, 07:01)D-m-x Wrote:

(2021-07-18, 17:43)pkscout Wrote: Just an FYI that there is a release coming soon to fix the IMDB ratings (IMDB updated their web site, which broke the HTML scrape to get the ratings).  Special thanks to gumida for reporting this and submitting a patch to fix it.  Please note this fix will be available for Matrix only. No further updates are being done for Leia.

Hi @pkscout,

I know this post is almost a year old but I installed this yesterday on Leia and tried for half an hour why IMDb ratings are not working until I found this. Explains it pretty well I guess 😁

Question: Since the fix seems easy https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/commit/073c089dbb7ea1336c33e63dae7af6489dcc2bb2 is it possible to just edit the lib file at runtime in the add-ons folder + reboot for Kodi to pick it up? Or wouldn't this work? I'm mainly asking because there's also a .pyo file I'm the same folder.

Thanks, appreciate any answer 😄

python:


elif image_type == 'logos':

  destination = 'clearlogo'

(2022-08-12, 06:24)monisriz Wrote: @pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

(2022-08-12, 15:52)pkscout Wrote:

(2022-08-12, 06:24)monisriz Wrote: @pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

I'll find some time to fix the logo destination and then take a deeper look at the SVG thing.

(2022-08-12, 21:03)monisriz Wrote:

(2022-08-12, 15:52)pkscout Wrote:

(2022-08-12, 06:24)monisriz Wrote: @pkscout Just switched to this scraper and was doing some test runs before scraping the actual library. Noticed an issue when trying to get tv show logos from TMDB. I think there's a missing check for image_type in set_show_artwork() function.

python:


elif image_type == 'logos':

  destination = 'clearlogo'

Did a quick test with the above change and it seems to work and the logos from TMDB show up under 'clearlogos' when going to "Choose Art". Without the above change the TMDB logos only show up if you whitelist "logos" in TV artwork settings but I don't think the logos would work since Kodi is looking for clearlogo.png and not logos.png. Used with Artwork Dump the saved file is also named as logos.png.

Secondly, TMDB logos section sometimes also have *.svg logos. From what I know Kodi doesn't accept SVGs and only works with PNGs. So a file type check is probably needed to weed out those SVGs. For example, TMDB has a SVG only and Fanart has PNG then choose the logo from Fanart instead. Or if TMDB has SVG and PNG both then choose PNG and disregard SVG.

I'll find some time to fix the logo destination and then take a deeper look at the SVG thing.

Here's the PR for the change discussed above.
https://github.com/xbmc/metadata.tvshows.themoviedb.org.python/pull/83

(2022-08-17, 11:34)monisriz Wrote: So how do I update to the version with these changes?

(2022-08-17, 11:50)Karellen Wrote:

(2022-08-17, 11:34)monisriz Wrote: So how do I update to the version with these changes?

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

(2022-08-17, 15:02)monisriz Wrote:

(2022-08-17, 11:50)Karellen Wrote:

(2022-08-17, 11:34)monisriz Wrote: So how do I update to the version with these changes?

Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

(2022-08-17, 18:16)pkscout Wrote:

(2022-08-17, 15:02)monisriz Wrote:

(2022-08-17, 11:50)Karellen Wrote: Click on either the Matrix or Nexus link. Download the Zip file, then install via zip in Kodi.

Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

It will when there is an actual official update.  Since I can't test these changes on Matrix (as mentioned before, my development environment is all Nexus now), I need someone to make sure it both works as expected and doesn't cause other issues.  Once that is confirmed I will push the update to the scraper repo, after which auto updating will happen.

(2022-08-17, 19:42)monisriz Wrote:

(2022-08-17, 18:16)pkscout Wrote:

(2022-08-17, 15:02)monisriz Wrote: Ok.. so the TMDB TV Show scrapper won't update on it's own like other addons do when there's an update?

It will when there is an actual official update.  Since I can't test these changes on Matrix (as mentioned before, my development environment is all Nexus now), I need someone to make sure it both works as expected and doesn't cause other issues.  Once that is confirmed I will push the update to the scraper repo, after which auto updating will happen.

Did a quick test against 7-8 tv shows. Didn't see the "logos" section under "Choose Art". TMDB logos seem to be appearing correctly under clearlogo section.
Also tested with a show that had both svg and png files and only png showed up in the clearlogo preview area.