+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: PVR & Live TV Support (https://forum.kodi.tv/forumdisplay.php?fid=167)
+---- Forum: Windows Media Center (WMC) (https://forum.kodi.tv/forumdisplay.php?fid=205)
+---- Thread: Commercial Skip broken in Kodi 18? (/showthread.php?tid=338806)
RE: Commercial Skip broken in Kodi 18? - giant25 - 2019-01-14
(2019-01-14, 00:21)krustyreturns Wrote: What I have is working with the edl example you gave me. Do you know if the delimiters between the fields are always tabs as in the file you sent me?I've only seen them as tab delimited. I use Comskip as well, and I assume that's the most popular setup. Glad it's working for you. I tried another Win10 machine I have, same dll errors. You on Win 10?
RE: Commercial Skip broken in Kodi 18? - sbthomas - 2019-01-14
I cannot get the test version to enable either. Kodi sees it at the correct version but it cannot be enabled. When I monitored it using processmonitor, it attempts to load MSVCP140D.dll which is the debug version of the MS C++ dll and fails. Krusty, can you try to recompile in "release" mode and see if that helps? I have MSVCP140.dll all over my PC but no MSVCP140D.dll.
RE: Commercial Skip broken in Kodi 18? - krustyreturns - 2019-01-14
OK, I replaced it with a release version.
RE: Commercial Skip broken in Kodi 18? - sbthomas - 2019-01-14
Installed it from zip file and it enables successfully. In addition, I tested a few recordings with edl files and they work as well! Thank you sooo much for the update. Now fingers crossed we can get it in to 18.
RE: Commercial Skip broken in Kodi 18? - giant25 - 2019-01-14
New version works for me, too! I just put the files into the addons directory, edl files all worked. Thanks for getting this done!
RE: Commercial Skip broken in Kodi 18? - Klojum - 2019-01-14
(2019-01-14, 04:42)sbthomas Wrote: Now fingers crossed we can get it in to 18.You can try to squeeze it in via a Github PR , although 18 Final is very close, or the 18.1 version will take care of it.
RE: Commercial Skip broken in Kodi 18? - krustyreturns - 2019-01-14
Thanks @sbthomas for figuring out what the problem was and all you guys for testing. I will submit the PR tomorrow.
RE: Commercial Skip broken in Kodi 18? - mrfrankmrfrank - 2019-01-14
I upgraded to 18 beta version
at some point feels like six months ago and lost commercial skipping then. I've missed having commercial skipping all these months but kept hoping "the community" would figure it out. I am beyond grateful that you guys have figured it out!! looking forward to commercial skipping working again. As always, thank you to everyone and especially @krustyreturns
RE: Commercial Skip broken in Kodi 18? - krustyreturns - 2019-01-14
Just fyi: https://github.com/kodi-pvr/pvr.wmc/pull/65
RE: Commercial Skip broken in Kodi 18? - mrfrankmrfrank - 2019-01-21
refreshes github 3 times a day for a week to see if i can download the android addon..haha
RE: Commercial Skip broken in Kodi 18? - krustyreturns - 2019-01-23
Nothing seems to be happening with this. Both sbthomas and I have left a comment on the PR and pointed them to this thread but so far the kodi team has not touched it.
RE: Commercial Skip broken in Kodi 18? - giant25 - 2019-01-23
(2019-01-23, 03:35)krustyreturns Wrote: Nothing seems to be happening with this. Both sbthomas and I have left a comment on the PR and pointed them to this thread but so far the kodi team has not touched it.I think you're on double secret probation....
RE: Commercial Skip broken in Kodi 18? - krustyreturns - 2019-01-23
That takes me back. I wish I had known it before I changed the code.
Commercial Skip broken in Kodi 18? - ksooo - 2019-01-23
I was waiting for someone to confirm the fix which finally happened just 4 days ago. So, blaming team Kodi not caring about the PR is note quite fair. Currently, I do not have enough spare time to deal every day with Kodi, sorry.
RE: Commercial Skip broken in Kodi 18? - sbthomas - 2019-01-23
No worries. I just don't know enough about the process to know if someone is waiting on us PVR guys or if we're waiting on Kodi devs. Thanks for all the hard work. Please let us know here if we have any further actions. I responded to your comments on github. thanks again.
Hopefully @krustyreturns knows how to squash the request into one commit.