+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: PVR & Live TV Support (https://forum.kodi.tv/forumdisplay.php?fid=167)
+---- Forum: VDR (https://forum.kodi.tv/forumdisplay.php?fid=169)
+---- Thread: Beta Artwork support and other improvements (/showthread.php?tid=363935)
RE: Artwork support and other improvements - MarkusEh - 2022-03-26
Hi Dis.
Please initialize also
call.event = NULL;
~Markus
RE: Artwork support and other improvements - -Dis - 2022-03-27
Thanks, now it works. What you think should tvscraper related settings be in VDR vnsiserver settings and not in Kodi client? Kodi client doesn't have any knowledge backend addons so calling setting menu to tvscraper is confusing.
Maybe in future there's alternative ways to send artwork etc. to Kodi client.
RE: Artwork support and other improvements - MarkusEh - 2022-03-27
> Thanks, now it works
Glad to hear. I improved the documentation, and write an error message to syslog to find such thing easier.
I'm also now initializing the "cScraperMovieOrTv" // OUT parameters, so the caller has only to take care of the //IN parameters before the call.
Changes are in git.
> What you think should tvscraper related settings
Which kind of tvscraper related settings do you plan?
RE: Artwork support and other improvements - -Dis - 2022-03-27
(2022-03-27, 13:48)MarkusEh Wrote: Which kind of tvscraper related settings do you plan?
Same settings what are now in Kodi client settings (epg artwork, recordings artwork, actors etc.). So user can decide what is send to Kodi.
Or is one on/off setting for TVScraper integration enough? Or one for artworks and one for other info (actors, writer, directors etc.)
RE: Artwork support and other improvements - MarkusEh - 2022-03-27
My proposal: No user setting.
The system figures out, if tvscraper is available. If yes, everything available will be sent to kodi, including the artwork URLs.
We do some performance tests, but I don't think that end users will have performance issues.
So why should anyone want to turn it off?
RE: Artwork support and other improvements - -Dis - 2022-03-27
Good point. One reason for turning off actors etc would be if there's a lot of incorrect data. But I don't think that is real issue.
So yes I will delete all settings
RE: Artwork support and other improvements - -Dis - 2022-03-27
New version are now available on Github.
VNSI Server: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_backendresume
VNSI Client Kodi Matrix: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume_matrix
VNSI Client Kodi Nexus: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume_nexus
RE: Artwork support and other improvements - MarkusEh - 2022-03-28
Thank you!
Works very well!
Some small improvements:
In file "settings.xml", in timeout setting, could you increase "maximum" to something large, like 100? I have lots of recordings, and I had to increase it to about 30.
For the actors, can you avoid new lines and just concatenate them in one line like Actor1, Actor2, ...
RE: Artwork support and other improvements - MarkusEh - 2022-03-28
In git https://github.com/MarkusEh/vdr-plugin-tvscraper, there is a bug fix.
Now, for TV shows also season posters are available.
RE: Artwork support and other improvements - -Dis - 2022-03-28
Thank you for making changes to TVScraper.
(2022-03-28, 21:17)MarkusEh Wrote: In file "settings.xml", in timeout setting, could you increase "maximum" to something large, like 100? I have lots of recordings, and I had to increase it to about 30.
Maybe in future with separate PR.
(2022-03-28, 21:17)MarkusEh Wrote: For the actors, can you avoid new lines and just concatenate them in one line like Actor1, Actor2, ...
It's already made this way but I think Kodi is converting it to new lines. Also I don't see any directors or writers although data is send to Kodi and I have confirmed that tag.GetDirector() will return director(s) set by tag.SetDirector(). Maybe bug in Kodi? https://github.com/xbmc/xbmc/blob/0ee022c29b95097bdecb8d55df91906874d9ce2e/addons/skin.estuary/xml/DialogPVRInfo.xml#L52
Now we have to figure it out how to get these changes to vnsiserver. I don't want to maintain it myself so I made PR to https://github.com/mdre77/vdr-plugin-vnsiserver
RE: Artwork support and other improvements - MarkusEh - 2022-03-29
https://github.com/mdre77/vdr-plugin-vnsiserver seems to be dead. We might bring the vdr plugin to https://github.com/vdr-projects/ .
Question is: How can we make the KODI addon part of the official KODI delivery?
RE: Artwork support and other improvements - -Dis - 2022-03-29
I can make PR to https://github.com/kodi-pvr/pvr.vdr.vnsi and I can also make PR to vnsiserver when it is is moved to vdr-projects. Then we maybe have to wait until PR to pvr.vdr.vnsi is approved before merging changes to vnsiserver.
RE: Artwork support and other improvements - MarkusEh - 2022-04-21
Hi,
I get the following error:
Quote:2022-04-21 16:29:04.543 T:1846 INFO <general>: Loading skin file: /usr/share/kodi/addons/pvr.vdr.vnsi/resources/skins/skin.estuary/xml/Admin.xml, load type: LOAD_ON_GUI_INIT
2022-04-21 16:29:05.402 T:1846 ERROR <general>: AddOnLog: pvr.vdr.vnsi: CVertexShader::Compile: 0:1(10): error: GLSL 1.50 is not supported. Supported versions are: 1.00 ES
2022-04-21 16:29:05.403 T:1846 ERROR <general>: AddOnLog: pvr.vdr.vnsi: GL: Error compiling vertex shader
2022-04-21 16:29:12.947 T:1846 INFO <general>: Loading skin file: /usr/share/kodi/addons/pvr.vdr.vnsi/resources/skins/skin.estuary/xml/Admin.xml, load type: LOAD_ON_GUI_INIT
2022-04-21 16:29:12.986 T:1846 ERROR <general>: AddOnLog: pvr.vdr.vnsi: CVertexShader::Compile: 0:1(10): error: GLSL 1.50 is not supported. Supported versions are: 1.00 ES
2022-04-21 16:29:12.987 T:1846 ERROR <general>: AddOnLog: pvr.vdr.vnsi: GL: Error compiling vertex shader
How can this be fixed? Or can I ignore this?
~ Markus
RE: Artwork support and other improvements - -Dis - 2022-04-21
Sorry I don't have any idea what is causing that error. In what situation you get this and does it also happen vnsi.client without any modifications?
Edit. You tried to use VDR OSD? I don’t think it worked for a long time. At least for me it haven't work. I remember reading from somewhere that it depends what skin you are using in VDR.
https://github.com/kodi-pvr/pvr.vdr.vnsi/issues/141
RE: Artwork support and other improvements - -Dis - 2022-06-29
I'm looking testers for these new features (backend resume points and artwork).
Instructions and discussion can be found here https://www.vdr-portal.de/forum/index.php?thread/135110-artwork-and-backend-resume-support-testers-needed/