+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Artwork Downloader (/showthread.php?tid=114633)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
New features for comming release - Martijn - 2011-11-18
The add-on will include the same option as logo-downloader to choose the images yourself in solo mode.
This will be available for TV show & Movies (not all image types are supported yet by the provider sites)
TV Shows:
Movies:
- Hitcher - 2011-11-18
Does this now supersede Logo Downloader?
- Martijn - 2011-11-18
Hitcher Wrote:Does this now supersede Logo Downloader?
It will in the end
It was was decided with ronie (and with permission of ppic) that it was better to merge these add-on together into one.
There are still things that need to be worked out before it is fully supported. I will release some test version before adding it to the repo so skinners/users can test it out.
- ppic - 2011-11-18
this will free me some time to work on others things
- Martijn - 2011-11-18
ppic Wrote:this will free me some time to work on others thingsNot yet figured out how to get the second window with the image list.
The whole add-on structure is different so it takes some time to figure out so I may need some help if i can't get it to work.
- ppic - 2011-11-18
Machine-Sanctum Wrote:Not yet figured out how to get the second window with the image list.
The whole add-on structure is different so it takes some time to figure out so I may need some help if i can't get it to work.
i'm using the common dialog xml and push image inside because dialog available in python script do not allow us to use image position.
i know, it's weird, but it works
- Martijn - 2011-11-18
ppic Wrote:i'm using the common dialog xml and push image inside because dialog available in python script do not allow us to use image position.
i know, it's weird, but it works
Problem now is the getting the imagelist and displaying it. Because we use a different way to retrieve that list it takes some time to adapt it.
So just taking small step to get it to work.
- ppic - 2011-11-18
Machine-Sanctum Wrote:Problem now is the getting the imagelist and displaying it. Because we use a different way to retrieve that list it takes some time to adapt it.
check my code, you'll see how i've done, you just have to put the correct info in fields
- Martijn - 2011-11-18
ppic Wrote:check my code, you'll see how i've done, you just have to put the correct info in fields
Yeah i was already doing that. It just needed a lot of changes to fit it in our way of coding (except the 'class MainGui')
Well the image list retrieval now works. Deleted to much code in the process
Next piece of code adaption will be downloading it.
- ppic - 2011-11-18
is my coding strange ?
- User 52808 - 2011-11-18
ppic Wrote:is my coding strange ?
I didn't look at your code as I don't do python and xbmc scripting, but in my experience, there's nothing more personal than code (maybe I'm saying this cause of the last project I did, the code already written was so strange)
!
- Martijn - 2011-11-18
ppic Wrote:is my coding strange ?
I have no idea
Only learned programming python for 2 months now
Maybe ours is strange, who knows.
Here's my current progress on it: code
Some things are just done differently and cause we also support movies it is a bit more extensive. There's still a lot of code cleaning to be done and maybe some things can be done much easier. Still finding out new things (for me at least).
PunkyMatt Wrote:I didn't look at your code as I don't do python and xbmc scripting, but in my experience, there's nothing more personal than code (maybe I'm saying this cause of the last project I did, the code already written was so strange)That's is definitely true. Every one has his own way of doing things.
I only took two minors of coding (JAVE/C++) and the one thing they kept saying is: break apart in modules/classes and always put comments in your coding so others can follow what is happening.
- User 52808 - 2011-11-18
Machine-Sanctum Wrote:I have no idea
...
and always put comments in your coding so others can follow what is happening.
oh yeah always comment that's right.
but it's also true (at least for commercial project with strong deadlines) that you never have time to comment !
- arnie420p - 2011-11-19
Nice work lads, good to see you are keeping busy with this. Just gonna take the new version for a spin
- BigNoid - 2011-11-19
Machine-Sanctum Wrote:The add-on will include the same option as logo-downloader to choose the images yourself in solo mode.Great!
This will be available for TV show & Movies (not all image types are supported yet by the provider sites)