Kodi Community Forum
v17 Grid for Krypton - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Skin Archive (https://forum.kodi.tv/forumdisplay.php?fid=179)
+----- Forum: Grid (https://forum.kodi.tv/forumdisplay.php?fid=280)
+----- Thread: v17 Grid for Krypton (/showthread.php?tid=318152)



RE: Grid - peppe_sr - 2017-09-20

(2017-08-17, 17:06)Jeroen Wrote:
(2017-08-17, 09:30)peppe_sr Wrote: Hi Jeroen i see the italian localization is at 0% I'll be on it as soon as possible. I'm on holiday atm ;-)

No rush, enjoy your holiday Cool

Italian translation completed! if someone find something weird i'm here.
Peppe


RE: Grid - Jeroen - 2017-09-20

(2017-09-20, 17:01)peppe_sr Wrote:
(2017-08-17, 17:06)Jeroen Wrote:
(2017-08-17, 09:30)peppe_sr Wrote: Hi Jeroen i see the italian localization is at 0% I'll be on it as soon as possible. I'm on holiday atm ;-)

No rush, enjoy your holiday Cool

Italian translation completed! if someone find something weird i'm here.
Peppe

Awesome, thanks! I'll merge it in tonight Cool


RE: Grid - Jeroen - 2017-09-20

(2017-09-20, 14:36)Luke Cage Wrote: In the Add-Ons menu (custom-1110-Addons.xml) the totals often cause a terrible lag in navigating the menu.
Is there a way to turn them off in the skin options ?
I looked for it but couldn't find any. So I'm commenting/deleting them after each update of the skin. (I use sed for this.)

These lines :
Code:
<label2>$INFO[Window(Home).Property(SkinHelper.TotalVideoAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalAudioAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalPicturesAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalProgramAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalAddons),, $LOCALIZE[31073]]</label2>

The system is my HTPC, which is an Intel Core2 Quad Q9550 with 8GB RAM, 2 SSDs, and RX 480, running Arch Linux + KDE/Plasma and Kodi.

Also,
when I choose an addon from Video (MyVideoNav.xml) or Music (MyMusicNav.xml) Kodi, Grid, or the add-on hangs for no apparent reason on the busydialog (DialogBusy.xml) throbber. Twice I let it sit (while doing something) else. And after about 1 hour, and about 1 hour 30 minutes, it was still hung and showing the busy throbber.
Any idea if this is in Grid, or Kodi ? I already established that addon is not even entered (by adding a line, that's logging "It's me!" to the Kodi log, as the first statement to execute at addon entry). It never appears in the log.
I have to lookup the PID number of Kodi (/usr/lib/kodi/kodi.bin) and kill it.

And this is with every add-on? Very strange, can't say I have seen this behaviour myself, and my HTPC is quite comparable to your system hardware wise. Skins don't really get involved when it comes to selecting a node, or in this case entering an add-on. So if this were to be skin related, it would have to be something happening on unloading the previous window or loading the next window. But if there's nothing showing up in the logs relating to a skin xml my guess is as good as yours really.

Does the selected viewtype make any difference?


RE: Grid - Raitsa - 2017-09-20

One thing I find strange in Grid is Youtube sorting.
Every view shows duration nicely except for sorted by date which does not show video duration anywhere.

Jeroen: hopefully it is possible to add duration to the sorted by date-view too, please.

Sorted by date (missing duration):
Image

Sorted by duration:
Image


RE: Grid - Jeroen - 2017-09-20

(2017-09-20, 20:33)Raitsa Wrote: One thing I find strange in Grid is Youtube sorting.
Every view shows duration nicely except for sorted by date which does not show video duration anywhere.

Jeroen: hopefully it is possible to add duration to the sorted by date-view too, please.

There's no such thing as youtube sorting to the skin, the skin just displays ListItem.Label2 on the second line here. When the sorting is set to "Date added" this is changed from duration to date added, this is not controlled by the skin. If I would add the duration here, ListItem.Label2 would still be displayed in the other sorting options, and it would show duration twice.


RE: Grid - Luke Cage - 2017-09-20

(2017-09-20, 19:46)Jeroen Wrote:
(2017-09-20, 14:36)Luke Cage Wrote: In the Add-Ons menu (custom-1110-Addons.xml) the totals often cause a terrible lag in navigating the menu.
Is there a way to turn them off in the skin options ?
I looked for it but couldn't find any. So I'm commenting/deleting them after each update of the skin. (I use sed for this.)

These lines :
Code:
<label2>$INFO[Window(Home).Property(SkinHelper.TotalVideoAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalAudioAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalPicturesAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalProgramAddons),, $LOCALIZE[31073]]</label2>
<label2>$INFO[Window(Home).Property(SkinHelper.TotalAddons),, $LOCALIZE[31073]]</label2>

The system is my HTPC, which is an Intel Core2 Quad Q9550 with 8GB RAM, 2 SSDs, and RX 480, running Arch Linux + KDE/Plasma and Kodi.

Also,
when I choose an addon from Video (MyVideoNav.xml) or Music (MyMusicNav.xml) Kodi, Grid, or the add-on hangs for no apparent reason on the busydialog (DialogBusy.xml) throbber. Twice I let it sit (while doing something) else. And after about 1 hour, and about 1 hour 30 minutes, it was still hung and showing the busy throbber.
Any idea if this is in Grid, or Kodi ? I already established that addon is not even entered (by adding a line, that's logging "It's me!" to the Kodi log, as the first statement to execute at addon entry). It never appears in the log.
I have to lookup the PID number of Kodi (/usr/lib/kodi/kodi.bin) and kill it.

And this is with every add-on? Very strange, can't say I have seen this behaviour myself, and my HTPC is quite comparable to your system hardware wise. Skins don't really get involved when it comes to selecting a node, or in this case entering an add-on. So if this were to be skin related, it would have to be something happening on unloading the previous window or loading the next window. But if there's nothing showing up in the logs relating to a skin xml my guess is as good as yours really.

Does the selected viewtype make any difference?

No, the selected viewtype doesn't make any difference.

It was more of a question to get a shortcut to where the hanging throbber problem might be. Maybe you'd seen it yourself at one stage or another. I'll research it a little bit more this weekend (hopefully).
The hanging throbber issue has been there since the beginning (for me). But it's so random. The weird thing is that it never happens when I use Estuary. I only have Estuary, Estouchy, and Grid skins installed. I have the Youtube, Youtube-DL, URL Resolver, and my own video add-on installed. And the mandatory and optional addons of Grid, and also the addons which Kodi installs of course.
And FilmOn.tv, FilmOn Simple, SoundCloud and TuneIn Radio (these last 4 might be illegal/banned).


RE: Grid - Jeroen - 2017-09-21

I would be really surprised id the busy dialog was actually the problem rather than a visual manifestation of the actual problem as the busy dialog is a really simple dialog.

Sure, I have experienced the busy dialog stop animation on occassion but that's usually when an add-on can't load the content, the website or service is down or things like that. That normally just takes a couple of seconds through.

Do you see a spike in CPU usage?


RE: Grid - Luke Cage - 2017-09-21

I realise that it's not the busy dialog. Like you say, the problem is that the busy dialog hides what's really happening. That's why I had hoped that you had maybe encountered it before while you were designing and developing. And could give me a hint to shorten debug effort. My hardware or OS or whatever might be an edge case that wasn't catered for.
I wish that the skin debug info would also show what script (if any) was called/running. Or that there was a separate/dedicated toggle for scripts.

Yes, there is always a spike in core #2 (the third one) visible on screen when it starts/happens, when I have debug logging switched on. Up to 80+%.

I'll give it a shot on Sunday.


RE: Grid - akya - 2017-09-23

I am on Kodi 17.4 and Grid 1.2.34 and the list view looks a bit messed up.
Code:
https://i.imgur.com/AA3ssKD.jpg



RE: Grid - Jeroen - 2017-09-23

Yup confirmed, will fix asap.


RE: Grid - Jeroen - 2017-09-24

Should be ok again


RE: Grid - amornik - 2017-09-24

(2017-09-24, 14:58)Jeroen Wrote: Should be ok again

I don't see any update...and .34 still has this visual bug.
what do we do? Smile


RE: Grid - Jeroen - 2017-09-24

Try again please


RE: Grid - akya - 2017-09-24

(2017-09-24, 14:58)Jeroen Wrote: Should be ok again

Yup, all good. Thanks.


RE: Grid - Jeroen - 2017-09-25

Grid 1.2.38 is available and has a change I would like to explain further. One of the issues that still needed to be solved is that, depending on the icon(set) you choose or is provided by the backend, the icons did not always fit properly in the frame on the right in list view.

The root cause of this problem is that there is no standard or even guidelines when it comes to these icons. They can be any size or have any aspect ratio or opacity level

The other difficulty here is that in the PVR, Kodi makes no difference between channel logo's and preview thumbnails. The area in which they are to be displayed in Grid is obviously best suited for 16:9 thumbails. However, f the skin actually would be able to know what type of image it is, I would be able to create a fallback construction where the skin shows a preview / fanart landscape image if available, or a channel logo when a thumbnail is not available. Currently there is no way to do this without distorting either the channel logo or preview thumbnail.

So I have added an option that allows you to choose between icons and thumbnails. If you choose the latter scraped PVR artwork will be shown if available. If not available it will show the channel logo instead, against a fallback texture and possibly distorted.

If you choose icons, it will show the channel logos using correct proportions and alignment. It will also use colorbox to set the space around the icon to a matching color. However using this option it will not show any scraped thumbnail images. I think it looks pretty cool though, see the screens below for an example.

This is the best I can make this at the moment, this really is a Kodi limitation.

Special thanks to joostzilla for testing PVR functions Smile and the screenshots Smile

Oh, and the skin option for this is in skin settings > artwork > PVR > Listview artwork type

Also, as this option uses colorbox, which unfortunately does not work with Android, this will not look great on that platform. If you are not running on Android and don't have colorbox installed, the same applies.

Image

Image

Image