(2015-09-16, 12:52)KenV99 Wrote:

(2015-09-15, 21:00)Piers Wrote: OK, I tested your most recent master. Here's a log including the issues (line 357): http://pastey.org/view/635396d4

I've reverted back to the repository version, it works again. So it's definitely an issue with the most recent add-on. Happy to help with further testing.

I think that new error may be linked to the fact that you are running with 'restricted rights' (see line 9 in your log).
Are you running in portable mode? Does the user that you are running as have rw privileges to the actual addon directory?

The issue is that the addon needs to dynamically set the choices of the names of the profiles on the Settings page that you gave in the Ambibox Windows program since you can name the profiles whatever you want. Kodi does not provide anyway to dynamically change these choices other than programmatically editing the settings.xml file which appears to reside in a directory that the python api no longer has rw privileges. I don't yet understand what has caused the change for some to no longer have rw rights for this file.

I need to do more research on this issue because I can't recreate it on my systems.

I pushed another update to github to provide more logging of why this might fail. Hopefully it will also allow you to move on even if the addon isn't able to add your profiles to the settings screen. This is temporary fix for now...
Please post back a log.

Thanks for your help in squashing this bug.

(2015-09-17, 14:51)bruncolio Wrote: Not to derail, but is ambibox dead? The download site isn't working for me, and having searched around it looks to have been down for months now. Can't find a mirror either...

(2015-09-16, 21:27)Piers Wrote: Here's a very long debug log: http://pastey.org/view/56e5de7f

What I've noticed is that, sometimes, the light isn't disabled after a video has finished. There doesn't appear to be a pattern - it happens at seemingly random instances. This could be a Lightpack issue, which is unlikely, or, most likely, an issue with the connection between Ambibox and your add-on.

It also occurred on the previous version.

Edit:
What you can rule out: permissions - this has no bearing on the previously reported issue.

(2015-09-17, 14:59)KenV99 Wrote:

(2015-09-17, 14:51)bruncolio Wrote: Not to derail, but is ambibox dead? The download site isn't working for me, and having searched around it looks to have been down for months now. Can't find a mirror either...

I went to the site after I clean installed Windows 10 and downloaded it on 9/9/2015 at 9:55am EDT. So cerainly not down for months...
If the site remains down, I'll email the author later today.

I uploaded the current to github temporarily for you: https://github.com/AmbiBox/kodi.script.ambibox/releases/download/v2.1.7/AmbiBox_setup_2.1.7.zip

(2015-09-17, 18:55)KenV99 Wrote:

(2015-09-16, 21:27)Piers Wrote: Here's a very long debug log: http://pastey.org/view/56e5de7f

What I've noticed is that, sometimes, the light isn't disabled after a video has finished. There doesn't appear to be a pattern - it happens at seemingly random instances. This could be a Lightpack issue, which is unlikely, or, most likely, an issue with the connection between Ambibox and your add-on.

It also occurred on the previous version.

Edit:
What you can rule out: permissions - this has no bearing on the previously reported issue.

I pushed another update. I hope the restricted mode error is solved at this point due to the changes in which I present the profiles.
Please make sure you go into settings and set the default profile to None and change the video settings to your preferred settings after you update.

The next time the lights don't shut off, if you can, please post a log. Because the screen capture routine runs in separate thread, it's possible that issue is somewhere there that it occasionally misses turning them off. These multithreading bugs are often difficult to track down and reproduce because I have yet to find a way of creating a VM to simulate a lower powered system so I only have my own HTPC and desktop to test on and both are i7 quadcores running at 3.5 and 4.2 GHz.

Thanks again for your help.

(2015-09-19, 17:59)Piers Wrote: I'm starting to notice more and more "KodiDirect Fail" notices. The only solution is to restart Kodi and AmbiBox. Log: http://pastey.org/view/4d156764

(2015-09-19, 20:10)KenV99 Wrote:

(2015-09-19, 17:59)Piers Wrote: I'm starting to notice more and more "KodiDirect Fail" notices. The only solution is to restart Kodi and AmbiBox. Log: http://pastey.org/view/4d156764

Is that occurring while you are watching and the LEDs should be working or only at the end of playing?

Those fails in the log occur for me occasionally when I am stopping the video. Again, since it is threaded, I think what happens is that the thread that is driving the LEDs shows a failure due to the fact that the RenderCapture buffer is emptied and returns CAPTURE_STATE_FAILED before the Player fires the onPlaybackStopped event which in turns sets a signal in the other thread to stop capturing. In the code I try to catch that possibility by checking Player.isPlaying(), but again, I think there may be a lag between what occurs in the RenderCapture buffer and that function returning false.

(2015-09-20, 06:55)Piers Wrote: Here's more unusual behaviour. Disabling the add-on is causing Kodi to crash, http://pastey.org/view/d5407f2e

That's all I could get before I needed to terminate the process.

(2015-09-20, 14:49)KenV99 Wrote:

(2015-09-20, 06:55)Piers Wrote: Here's more unusual behaviour. Disabling the add-on is causing Kodi to crash, http://pastey.org/view/d5407f2e

That's all I could get before I needed to terminate the process.

I pushed a github update.

That crash behavior seems to have started in Isengard. I am not sure what changed in Kodi to cause it. The only way I seem to be able to eliminate that is by calling sys.exit without any house-keeping to terminate threads and delete objects. Stuff I usually do to eliminate memory leaks and abandoned threads. Shouldn't cause much problems unless someone repeatedly enables and disables without restarting Kodi.

As far as the KodiDirect Fail issue goes I also updated the loop with a 250ms pause to see if the player has stopped before generating a Fail message. Please see if this works for you now.

Thanks again for your help.

EDIT:
If you continue to get Fail messages at this point during playback and not just when stopping I would try lowering the throttle to see if that decreases the probability that the addon requests a video frame and the Kodi RenderCapture buffer cannot provide it.