Amet Wrote:debug log?

ronie Wrote:the song in question is Bruce Springsteen - Born To Run
it's trying (and fails) to fetch this url:
http://lyricwiki.org/index.php?title=Bruce%20Springsteen%3ABorn%20to%20Run&action=edit
though the lyrics are available:
http://lyrics.wikia.com/index.php?title=Bruce_Springsteen:Born_To_Run

this is really a big issue to me, cause without the lyrics i can't sing-along

paco Wrote:This script REQUIRES correct capitalization to retrieve lyrics. 'Born to Run' will not work, but if you edit your tag to be 'Born To Run' it will.

ronie Wrote:how many do you want ? ;-)

issues observed with 0.7.5 so far
- while the script is searching for lyrics, it displays 'choose your song from the list'
- can't find lyrics for several songs that used to work with previous versions of the script.
- 50% of the time, i can't close the lyrics window !! help !!!

i think you've made some cu changes in the latest release. ;-p



edit:
here's a debug log

the song in question is Bruce Springsteen - Born To Run
it's trying (and fails) to fetch this url:
http://lyricwiki.org/index.php?title=Bruce%20Springsteen%3ABorn%20to%20Run&action=edit
though the lyrics are available:
http://lyrics.wikia.com/index.php?title=Bruce_Springsteen:Born_To_Run

this is really a big issue to me, cause without the lyrics i can't sing-along



another edit:
since it's no fun listening to music this way i might as well make some screens for you

can't close window and it doesn't auto close at the end of the song:


speaks for itself, no further comment needed:

ZorMonkey Wrote:Couple things. I'm a python novice, but I think this is right.

In gui.py, this looks backwards:

Code:

if (artist.find( "\'" )) or (song.find( "\'", )):
            quote = False
        else:
            quote = True

it should probably be

Code:

if (artist.find( "\'" )) or (song.find( "\'")):
            quote = True
        else:
            quote = False

Right?

ZorMonkey Wrote:But even better, I had better luck ignoring that bit and instead modifying the lyricwiki_format function in the LyricsFetcher class to this:

Code:

def lyricwiki_format(self, text):
        titleCase =lambda value: re.sub("([a-z])'([A-Z])", lambda m: m.group(0).lower(), value.title())
        return urllib.quote(str(unicode(titleCase(text))))

I got that lambda magic from http://bugs.python.org/issue7008. Its not perfect, but it catches a lot. I also modified the get_lyrics_thread function to only use lyricwiki_format, and also hopefully improved detecting failed searches. Here's my full function:

Code:

def get_lyrics_thread(self, artist, title,quote):
        try:
            url = "http://lyricwiki.org/index.php?title=%s:%s&fmt=js" % (self.lyricwiki_format(artist), self.lyricwiki_format(title))
            
            song_search = urllib.urlopen(url).read()
            if song_search.find("Click here to start this page!") >= 0:
                error = "Lyrics not found"
                return error
            
            song_title = song_search.split("<title>")[1].split("</title>")[0]
            print song_title
            song_clean_title = self.unescape(song_title.replace(" Lyrics - LyricWiki - Music lyrics from songs and albums",""))
            print "Title:[" + song_clean_title+"]"
            lyricpage = urllib.urlopen("http://lyricwiki.org/index.php?title=%s&action=edit" % (urllib.quote(song_clean_title),)).read()
            print ("http://lyricwiki.org/index.php?title=%s&action=edit" % (urllib.quote(song_clean_title),))
            
            content = re.split("<textarea[^>]*>", lyricpage)[1].split("</textarea>")[0]
            if content.startswith("#REDIRECT [["):
                addr = "http://lyricwiki.org/index.php?title=%s&action=edit" % urllib.quote(content.split("[[")[1].split("]]")[0])
                    content = urllib.urlopen(addr).read()
            try:
                lyrics = content.split("&lt;lyrics&gt;")[1].split("&lt;/lyrics&gt;")[0]
            except:
                lyrics = content.split("&lt;lyric&gt;")[1].split("&lt;/lyric&gt;")[0]
            return lyrics
        except:
            error = "Fetching lyrics failed"
            return error

It hasn't been tested very rigorously yet, but it's now finding lyrics that it wasnt before. Mostly it seems better because it's now title casing everything, so simple cases like "XTC:River of Orchids" is working.

Amet Wrote:Sorry for the screw up in 0.7.6, I had it working fine on my side. Dont have too much time to play with it now so I am just reverting the code to previous working version.

When I get some time I will try to fix up all the issues.

Zeljko

ronie Wrote:you know where to find me if you need someone to do some more testing. ;-)

Quote:

Quote:Originally Posted by ZorMonkey View Post
Couple things. I'm a python novice, but I think this is right.

In gui.py, this looks backwards:

Code:
<snip>
Right?

No, if we find " ' " in a song or artist name we dont want it to be capitalized but still urllib.quote it.

Code:

def lyricwiki_quote(self, text):
        return urllib.quote(str(unicode(text)))

admittedly the naming could have been better

ZorMonkey Wrote:Looking at it again, yeah, that makes sense (although, yeah, the naming could be better ) But somehow "fixing" that made it work better I thought. Ah well, I was looking at it too late at night, so who knows what I was doing.

Amet Wrote:but all that will go away when your code is implemented, thanks again

dny238 Wrote:Amet, where is the latest code? In the SVN or did I see something about private releases of the beta versions?

Amet Wrote:no private beta releases, its just the standing joke I have with ronie.

as for the code, it will be added in the next release, if I have some time over the weekend I will try to do it then.

SVN repo installer has the latest version.

Zeljko