(2012-03-27, 02:26)robweber Wrote:

(2012-03-27, 00:36)Radikaltimes Wrote: is there a way to add clean library to the process?

Adding the function to clean the database is pretty trivial. The problem I found when trying to add this earlier is that there is no way to tell if a database clean operation is happening (like you can with scanning) so it is possible to hose up the xbmc process by executing it while another is already running. I did a test case with a cron expression set to run fairly often, like every 10 minutes, and locked up xbmc. Granted you wouldn't set them off that close together, but what happens if a clean operation takes 1-2 hours and another kicks off?

I've thought about how to get around this and the best I can think of is to only allow the clean database function to execute minimum once every 24 hours. Another option you have is add a setting to the advancedsettings file that does a clean immediately following an update. http://wiki.xbmc.org/index.php?title=AdvancedSettings.xml#.3Cvideolibrary.3E

I guess that was just a really long way of saying that I've been working on it. Having a variable to check like there is with scanning to tell if it is running or not would be a big help.

(2012-03-29, 23:10)paddycarey Wrote: Hi,

I have a problem where sometimes my network shares don't come up and so on an update library (i have it set to autoclean on update for various reasons) i lose my db.

Would it be possible to add an option to settings to check for the existance of a specified path before doing the scan?

I have it hardcoded in my local copy of the script now but the option may be useful to others.

I just use a simple

Code:

if not xbmcvfs.exists(some_path):
    #skip scan

to check before letting the update run.

(2012-03-30, 11:24)paddycarey Wrote: One option might be to use the JSON api to get a list of all the configured shares (pretty sure this can be done) and then attempt to write/delete/touch/whatever a small file on each one to make sure they're up. This obviously requires having write access to the shares.

Does the JSON API give a different response when attempting to list a share if it's down as opposed to empty? If so then that would be one simple way to implement this.

(2012-03-30, 16:20)robweber Wrote: Seems pretty simple right? Well the advancedsettings cleanonupdate entry is going to try to clean the library after each of those "run libraryupdate" commands. So even if only 1 out of 4 sources is connected, the clean DB process is going to run and wipe out the other three.

This method of updating the database is also highly inefficient. The default UpdateLibrary(video) command will go through all the sources first, then execute the clean command (based on your advanced settings entry). The code above will run the UpdateLibrary(video,path) command on each path separately, and then run the clean command after each individual update. Updating your library with 2 sources would require waiting through an entire clean operation between each path update.

(2012-03-30, 18:11)paddycarey Wrote: AFAIK the clean on update will only clean the part of the library that was specified in the update call, e.g. when i update and clean the whole library the clean operation seems to take about 3 minutes but if i only update my tv path then the clean operation only takes a few seconds.

I realise it's a bit inefficient but when the library's only being updated every few hours does it make a lot of difference for those extra few seconds? That being said, if you think your other solution will work better then i'm all for it. The only issue i've encountered doing it that way is that a standalone cleanlibrary call seems to much longer than the same call when run automatically after update.

One simple way to reduce the inefficiency might be to do something like:

Code:

for share in shares:
    if share_up:
        mark share as online
    else:
        mark share as offline

if all_shares_up:
    update whole library
else:
    for shares in alive_shares:
        update share

This way you still check that the shares are all up but don't have to run individual update calls if none are down.

---

One other note, as far as I can tell, when a cleanlibrary is run with cleanonupdate, library.isscanning will return true until that clean has finished.

(2012-04-12, 15:03)LoL Wrote: Is working excellent for me!

Really enjoy the "single video path" scan: could there be an option to add more paths with each their own timers?

Thx!

(2012-04-17, 10:31)LoL Wrote: For me 2-3 would be enough i think. But just in case, wouldn't it be possible to code it so as a user you always have the possibility to add another.

I'm really enjoying the single path update man, its so much faster and feels cleaner