xbmcmomomo Wrote:I have some tracks that dont have mp3 id tags.

(the same as when artist tag is missing).

Is it possible to just search on the filename

eg: Life_on_your_own.mp3

to do a search on :

http://lyrics.wikia.com/Special:Search?search=life+on+your+own&go=1

then just scrape the first result (it is most likely to be the correct one!!).

<ul class='mw-search-results'>
<li><a href="http://lyrics.wikia.com/wiki/The%20Human%20League%3ALife%20On%20Your%20Own"
</li>

dny238 Wrote:If you want some improvements to the capitalization script hack I did a few days ago here they are.

PHP Code:

if ( len(lyrics) < 100):
                        song = song.title()
                        artist = artist.title() 


replace .capitalize with .title
also, upcase the artist as well as the song. I've had both fail.
Rob

Amet Wrote:how is that different than the code thats already in lyricsScraper.py?

Code:

def lyricwiki_format(self, text):
        return urllib.quote(str(unicode(text).title()))

dny238 Wrote:That's a great question. if there is already something there attempting to upper case the song title before it searchs the wiki, I wonder why it's not working.

I haven't looked up this line in the code yet, are you calling it on the URL?

Code:

//Your original output....
13:04:34 T:2868177808 M:609550336  NOTICE: Title:[Deniece Williams:Let's Hear It for the Boy]
13:04:42 T:2868177808 M:609558528  NOTICE: http://lyricwiki.org/index.php?title=Deniece%20Williams%3ALet%27s%20Hear%20It%20for%20the%20Boy&action=edit
//when the lookup fails, my additional code outputs this.
13:04:42 T:2868177808 M:609558528  NOTICE: Search failed for show: Capitalizing Let's Hear It For The Boy Deniece William
s
13:04:46 T:2868177808 M:609566720  NOTICE: Title:[Deniece Williams:Let's Hear It For The Boy]
13:04:53 T:2868177808 M:609583104  NOTICE: http://lyricwiki.org/index.php?title=Deniece%20Williams%3ALet%27s%20Hear%20It%
20For%20The%20Boy&action=edit

I'll look that function over the next time I get a chance, much rather use something built in.
Rob

Amet Wrote:no, it gets called for song name and artist, the problem comes in when we try to do it on "let's hear it for the boy" it becomes "Let'S Hear It For The Boy".

Zeljko

Amet Wrote:no, it gets called for song name and artist, the problem comes in when we try to do it on "let's hear it for the boy" it becomes "Let'S Hear It For The Boy".

Zeljko

ZorMonkey Wrote:That's what my old change was supposed to address:

Code:

def lyricwiki_format(self, text):
        titleCase =lambda value: re.sub("([a-zA-Z])'([A-Z])", lambda m: m.group(0).lower(), value.title())
        return urllib.quote(str(unicode(titleCase(text))))

The old regex was "([a-z])'([A-Z])" until I came across an "I've" that was being changed to "I'Ve"

dny238 Wrote:Are you guys always upper casing stuff? I figured we'd try the default title and 'try again' with capitalization if there was a lookup issue. Maybe that's unnecessarily complex.

Quote:Quick question, what are you doing with songs with Featuring Jay-Z in them? Is there a standard approach to that type of thing on LyricsWiki?

Quote:2nd question, whose issue is it that i'm seeing HTML encoding on tracks like http://lyrics.wikia.com/index.php?title=Carrie%20Underwood:Before%20He%20Cheats&action=edit? &quot; is visible and there are double quotes sometimes.

dny238 Wrote:ZorMonkey,
Question for you about scripts. It seems like there could be a threading issue somewhere. Let me setup the scene.
1) I have a directory of songs I've never played before
2) I play the first song, and the system gets its lyrics and starts to get the next one.
3) Before the results are back I hit next 2x, skipping over the song which is currently being loaded.
4) I want to immediately see a "Fetching lyrics..." message, but I don't.
5) On my system it takes about 9 seconds. So for 9 seconds I'm stuck looking at the lyrics from the song 2 clicks ago.

Quote:PS. Found one bug, for some reason the I've became i've.
SCRAPER-DEBUG: LyricsFetcher.get_lyrics_thread Artist: Linkin Park, Title: What I've Done
14:59:55 T:2805619600 M:513093632 NOTICE: http://lyricwiki.org/index.php?title=Linkin%20Park:What%20i%27ve%20Done&fmt=js

ZorMonkey Wrote:Yeah, I hate that too. There are a few problem in there, which could possibly be solved with more threading, but I'm not sure yet. One big thing is that we have to do some weird stuff to get the artist and title for the currently playing song. After XBMC tells us that the song has changed it can take a while for it to tell us what that song is. Don't know why, but I want to blame XBMC for that. The skin knows what the song is immediately, so why wont XBMC tell us what the song is immediately? I dunno.

dny238 Wrote:All I want is to put up "Fetching Lyrics..." as soon as we possibly can. It doesn't bother me that it takes 10 seconds to respond. I'd be nice if it didn't... but i'm not greedy. Mostly I just want to take the wrong lyrics off the screen.

Rob