+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Subtitle Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=143)
+---- Thread: Release [service.subtitles.opensubtitles] (/showthread.php?tid=183114)
RE: [service.subtitles.opensubtitles] - mpie - 2014-11-11
Just remove the "not" in the if statement of that python file on line 42.
The array seems to empty all the time.
RE: [service.subtitles.opensubtitles] - tnuc - 2014-11-11
anyone that can reproduce this issue, please try with this fix -> https://github.com/amet/service.subtitles.opensubtitles/commit/7ce2a1f3d62b666615cf6468197ac8fdfac4c5f6
there was an issue with tabs being introduced in one of the PRs
RE: [service.subtitles.opensubtitles] - misa - 2014-11-11
(2014-11-11, 09:54)tnuc Wrote: anyone that can reproduce this issue, please try with this fix -> https://github.com/amet/service.subtitles.opensubtitles/commit/7ce2a1f3d62b666615cf6468197ac8fdfac4c5f6
there was an issue with tabs being introduced in one of the PRs
This fix is not working
(2014-11-11, 09:08)mpie Wrote: Just remove the "not" in the if statement of that python file on line 42.
The array seems to empty all the time.
Remove that line you mean?
RE: [service.subtitles.opensubtitles] - tnuc - 2014-11-11
this is like pulling teeth, noone can help you with that attitude... Debug Log or it didn't happen
(2014-11-11, 09:08)mpie Wrote: Just remove the "not" in the if statement of that python file on line 42.
The array seems to empty all the time.
you cant hash 'temp' item, there is a reason for that check
RE: [service.subtitles.opensubtitles] - misa - 2014-11-11
(2014-11-11, 10:35)tnuc Wrote: this is like pulling teeth, noone can help you with that attitude... Debug Log or it didn't happen
(2014-11-11, 09:08)mpie Wrote: Just remove the "not" in the if statement of that python file on line 42.
The array seems to empty all the time.
you cant hash 'temp' item, there is a reason for that check
http://pastebin.com/pKrBR3tP
PHP Code:
10:13:05 T:2552751184 DEBUG: ### [__main__] - action 'search' called
10:13:05 T:2552751184 DEBUG: ### [__main__] - VideoPlayer.OriginalTitle not found
10:13:05 T:2552751184 DEBUG: ### [OSUtilities] - Search String [ Lets+Be+Cops ]
10:13:06 T:2552751184 DEBUG: ### [__main__] - failed to connect to service for subtitle search
10:13:06 T:2552751184 DEBUG: LocalizeStrings: no translation available in currently set gui language, at path /storage/.xbmc/addons/service.subtitles.opensubtitles/resources/language/Dutch
10:13:06 T:2552751184 DEBUG: POParser: loaded 4 strings from file
Gotham 13.2 OE
RE: [service.subtitles.opensubtitles] - pedror - 2014-11-11
I forgot to mention that I'm using xbmc 13.2, both under linux (manjaro) and a raspberry pi (raspbian based), so maybe it's not the same in other versions/OSs...
Regarding the log, I had this:
Code:
22:02:02 T:139973890131712 DEBUG: ### [OSUtilities] - Search String [ Bones++S05E09 ]
22:02:02 T:139974279870208 ERROR: EXCEPTION: Window id does not exist
22:02:02 T:139973890131712 DEBUG: ### [__main__] - failed to connect to service for subtitle searchI then added some extra logging in OSUtilities.py and saw where the exception was (but not which one
) in the above line, so I just wrapped it in an exception handler and let it fall back.I did find it odd that there were tabs mixed with spaces, which python typically hates, so maybe that is the issue - I'm at work right now, so can't test it - but that may explain why, when I tried to directly call the service in a python console, I got an error, but not an exception (which would be handled fine by the original code). Maybe when I edited the file (using vi), it got fixed somehow and that's why it started working...
Regarding the item['temp'] thing, my best guess is that it is there to handle the cases where there is no local file available, so no hashing can be done, but this is the first time I have looked at any xbmc/kodi code/plugin/service, so it all looks weird to me...
RE: [service.subtitles.opensubtitles] - tnuc - 2014-11-11
misa try this -> https://github.com/amet/service.subtitles.opensubtitles/commit/d959022857f238431859ee852acbe8a8401954f3
RE: [service.subtitles.opensubtitles] - misa - 2014-11-11
(2014-11-11, 12:27)tnuc Wrote: misa try this -> https://github.com/amet/service.subtitles.opensubtitles/commit/d959022857f238431859ee852acbe8a8401954f3
Yessss...........working. Thanks Amet / Tnuc
RE: [service.subtitles.opensubtitles] - tnuc - 2014-11-11
please check with "normal" non streamed content, i'll wait few days to get it into official repo, just in case stuff is more broken than it was
RE: [service.subtitles.opensubtitles] - misa - 2014-11-11
(2014-11-11, 13:26)tnuc Wrote: please check with "normal" non streamed content, i'll wait few days to get it into official repo, just in case stuff is more broken than it was
I got some testers who did this already and is working very quick and good so far
RE: [service.subtitles.opensubtitles] - ripacid - 2014-11-11
(2014-11-11, 12:27)tnuc Wrote: misa try this -> https://github.com/amet/service.subtitles.opensubtitles/commit/d959022857f238431859ee852acbe8a8401954f3
working, thank you!
RE: [service.subtitles.opensubtitles] - sabi1999 - 2014-11-11
(2014-11-11, 12:27)tnuc Wrote: misa try this -> https://github.com/amet/service.subtitles.opensubtitles/commit/d959022857f238431859ee852acbe8a8401954f3
Yes, I can confirm this is working for me as well. Thanks for the fix guys. Much appreciated!
RE: [service.subtitles.opensubtitles] - ponciak - 2014-11-11
(2014-11-11, 16:58)sabi1999 Wrote:(2014-11-11, 12:27)tnuc Wrote: misa try this -> https://github.com/amet/service.subtitles.opensubtitles/commit/d959022857f238431859ee852acbe8a8401954f3
Yes, I can confirm this is working for me as well. Thanks for the fix guys. Much appreciated!
I also confirm - now opensubtitles works fine. Thanks for good job !
RE: [service.subtitles.opensubtitles] - marszalek1 - 2014-11-11
Maybe someone send mi this file, because me still don't working, maybe I doing something wrong.
RE: [service.subtitles.opensubtitles] - misa - 2014-11-11
(2014-11-11, 18:39)marszalek1 Wrote: Maybe someone send mi this file, because me still don't working, maybe I doing something wrong.
https://copy.com/qdgjaCwEujceiX67
You can that file from there if you like