Beta - Simple Favourites - defeats addons that hide the context menu

Beta Simple Favourites - defeats addons that hide the context menu - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Beta Simple Favourites - defeats addons that hide the context menu (/showthread.php?tid=293511)

Pages: 1 2 3 4 5 6 7 8 9 10 11

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-16

(2018-09-26, 16:16)primaeval Wrote:
(2018-09-26, 16:08)jdig4240 Wrote: Hmm, maybe nothing. I was testing with Xonfluence 18. Superfavorites in folders dont want to open. But just tested with Eminence mod, and im not seeing the same issue. May be skin related.
It seemed to be ok in Estuary too.

Curious, what OS were you testing it on? Because on Windows 10 64-bit, latest Kodi Beta and nightlies I cant get Superfavourites to work at all.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-16

(2018-10-16, 20:58)jdig4240 Wrote:
(2018-09-26, 16:16)primaeval Wrote:
(2018-09-26, 16:08)jdig4240 Wrote: Hmm, maybe nothing. I was testing with Xonfluence 18. Superfavorites in folders dont want to open. But just tested with Eminence mod, and im not seeing the same issue. May be skin related.
It seemed to be ok in Estuary too.
Curious, what OS were you testing it on? Because on Windows 10 64-bit, latest Kodi Beta and nightlies I cant get Superfavourites to work at all.

The latest nightly I have is from 10 days ago and it works fine.
I enabled the global context menu, added BBC One from iplayerwww and it plays ok as a shortcut within SuperFavourites.
Here are the details

Code:
Starting Kodi (18.0-BETA4 Git:20181006-e67fb0d6e4). Platform: Windows NT x86 64-bit

Using Release Kodi x64 build

Kodi compiled Oct  7 2018 by MSVC 191225835 for Windows NT x86 64-bit version 10.0 (0x0A000004)

Running on Windows 7 SP1, kernel: Windows NT x86 64-bit version 6.1.7601

Maybe one of your addons is interfering with it.
Try a portable install with just SuperFavourites and one other addon.
kodi.exe -p

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-16

(2018-10-16, 21:14)primaeval Wrote:
(2018-10-16, 20:58)jdig4240 Wrote:
(2018-09-26, 16:16)primaeval Wrote: It seemed to be ok in Estuary too.
Curious, what OS were you testing it on? Because on Windows 10 64-bit, latest Kodi Beta and nightlies I cant get Superfavourites to work at all.
The latest nightly I have is from 10 days ago and it works fine.
I enabled the global context menu, added BBC One from iplayerwww and it plays ok as a shortcut within SuperFavourites.
Here are the details

Code:
Starting Kodi (18.0-BETA4 Git:20181006-e67fb0d6e4). Platform: Windows NT x86 64-bit Using Release Kodi x64 build Kodi compiled Oct 7 2018 by MSVC 191225835 for Windows NT x86 64-bit version 10.0 (0x0A000004) Running on Windows 7 SP1, kernel: Windows NT x86 64-bit version 6.1.7601

Maybe one of your addons is interfering with it.
Try a portable install with just SuperFavourites and one other addon.
kodi.exe -p

I see your running W7. Did you try windows 10? Not sure how it will make a difference though. Im gonna try right now. Fresh install. Only install SF and bbc or Crackle. Ill post log to show you. BTW, what version of SF are you using? The latest is .59 from Spoyers repo correct?

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-16

Ok, so same issue. Cleared Kodi folder in Roaming. Updated to latest nightly. Installed Spoyers repo/Installed SF .59/Installed iplayer you mentioned/installed Crackle as another example. Ran SF and set Global menu/Added BBC one to SF/Added Movies section from Crackle. Opened SF. Tried to open any of these SFs and failed everytime. Get ERROR: NEWADDON Unknown Video Info Key "label" Each time in log. Not surewhat is different from my setup besides Windows 10. Also I am not running the Windows Store version of Kodi. Im running the latest nightly installer 64-bit. Im at a loss why this doesnt work. Never an issue with 17.6.
Heres the log: https://pastebin.com/k6d6ZeK1

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

(2018-10-16, 23:29)jdig4240 Wrote: Ok, so same issue. Cleared Kodi folder in Roaming. Updated to latest nightly. Installed Spoyers repo/Installed SF .59/Installed iplayer you mentioned/installed Crackle as another example. Ran SF and set Global menu/Added BBC one to SF/Added Movies section from Crackle. Opened SF. Tried to open any of these SFs and failed everytime. Get ERROR: NEWADDON Unknown Video Info Key "label" Each time in log. Not surewhat is different from my setup besides Windows 10. Also I am not running the Windows Store version of Kodi. Im running the latest nightly installer 64-bit. Im at a loss why this doesnt work. Never an issue with 17.6.
Heres the log: https://pastebin.com/k6d6ZeK1

I haven't got win10. I tried it and went back to win7. I'd go back to win2000 if the drivers worked.
I'm using SF from the Kodi repo.
I used yesterday's nightly KodiSetup-20181016-0f435864-master-x64
I added the first movie from Crackle and it played in SF.
BBC One from iplayerwww worked too.

Try the Kodi repo version of SF.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

I installed SF 1.0.59 and that worked.

I tried win10 in a virtualbox VM and it worked too.
I copied over my portable install added CBBC from iplayerwww to SF and it ran.

Code:
44:32.499 T:4728  NOTICE: Starting Kodi (18.0-BETA4 Git:20181016-0f435864f1). Platform: Windows NT x86 64-bit

44:32.499 T:4728  NOTICE: Using Release Kodi x64 build

44:32.499 T:4728  NOTICE: Kodi compiled Oct 17 2018 by MSVC 191225835 for Windows NT x86 64-bit version 10.0 (0x0A000004)

44:32.499 T:4728  NOTICE: Running on Windows 10, kernel: Windows NT x86 64-bit version 10.0.14393

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

(2018-10-17, 08:48)primaeval Wrote: I installed SF 1.0.59 and that worked.

I tried win10 in a virtualbox VM and it worked too.
I copied over my portable install added CBBC from iplayerwww to SF and it ran.

Code:
07:44:32.499 T:4728 NOTICE: Starting Kodi (18.0-BETA4 Git:20181016-0f435864f1). Platform: Windows NT x86 64-bit 07:44:32.499 T:4728 NOTICE: Using Release Kodi x64 build 07:44:32.499 T:4728 NOTICE: Kodi compiled Oct 17 2018 by MSVC 191225835 for Windows NT x86 64-bit version 10.0 (0x0A000004) 07:44:32.499 T:4728 NOTICE: Running on Windows 10, kernel: Windows NT x86 64-bit version 10.0.14393

I see your adding direct links when your testing. Have you tried a folder? Like adding the movies folder from Crackle, or a section from iplayer rather than the direct link to the stream. I think thats where the problem is. I think iplayer is GEO lockedand why it failed for me. Adding a direct link to a movie in Crackle did work. But is seems adding any folder or directory or section of an addon or the whole addon doesnt work.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

SF folders fails for me too.
Somewhere in his code there must be a bit that needs to add the label or type of files in the folder.
I don't know where it is and his code is too complicated for me. That's why I wrote Simple Favourites.
If I need a head fuck sometime I'll see if I can find out what is wrong but don't hold your breath.

I found a couple of bugs with Video Favourites and fixed them in version 0.0.5.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

Here is a bodge for SF that lets you play folders from SF.
I don't know why the rest of the function is so complicated but there must be a reason.
So don't expect this to work in every case.

https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a

SF fails on the last function of activateWindowCommand

Code:
xbmc.executebuiltin('Container.Update(%s)' % plugin)

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

(2018-10-17, 17:08)primaeval Wrote: Here is a bodge for SF that lets you play folders from SF.
I don't know why the rest of the function is so complicated but there must be a reason.
So don't expect this to work in every case.

https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a

SF fails on the last function of activateWindowCommand

Code:
xbmc.executebuiltin('Container.Update(%s)' % plugin)

Cool, knew I wasnt crazy, lol. Ive tried with the same results on android and Xbox. Thanks for confirming! I will check out your bodge after work. Appreciate it!

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

(2018-10-17, 17:08)primaeval Wrote: Here is a bodge for SF that lets you play folders from SF.
I don't know why the rest of the function is so complicated but there must be a reason.
So don't expect this to work in every case.

https://github.com/primaeval/spoyser-repo/commit/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a

SF fails on the last function of activateWindowCommand

Code:
xbmc.executebuiltin('Container.Update(%s)' % plugin)

YESSSSSS! That definitely fixed the SF folders. They now open!! You da man! So what bugs do you expect there still might be?? Either way, ill check it out some more and test some various functions and ill let you know if i see anything unusual. Really appreciate it P!

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

I'm not sure what that activeWindowCommand does.
It might be if you launch the favourites via a context menu.
See if you can work it out.
https://github.com/primaeval/spoyser-repo/blob/cc54fbfb70afd889fe2dc4421915e68a5d6ba10a/plugin.program.super.favourites/player.py#L129

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

Well there is an option to manually create SF which you can choose the ActivateWindow command SF/context menu/Create new manual entry.

RE: Simple Favourites - defeats addons that hide the context menu - primaeval - 2018-10-17

That might be it. See if you can find where it breaks.

RE: Simple Favourites - defeats addons that hide the context menu - jdig4240 - 2018-10-17

Well that function seems to still work fine. Tried ActivateWindow/Window ID 10003/ FileManager.xml. Opened file manager fine from SF. Ill keep looking.