Kodi Community Forum
[BUG & FIX] HomeAddonsCommonLayout include - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Confluence (https://forum.kodi.tv/forumdisplay.php?fid=125)
+---- Thread: [BUG & FIX] HomeAddonsCommonLayout include (/showthread.php?tid=223611)



[BUG & FIX] HomeAddonsCommonLayout include - dnairb - 2015-04-06

There is a bug in the HomeAddonsCommonLayout include (found in the includes.xml file, from line 946).
The following sections are never invoked because the <visible> tags are wrong (lines 1038 and 1050):

Code:
            <control type="label">
                <left>1</left>
                <top>125</top>
                <width>180</width>
                <height>20</height>
                <font>font12</font>
                <textcolor>white</textcolor>
                <align>center</align>
                <aligny>center</aligny>
                <label>$INFO[ListItem.Label]</label>
                <visible>Control.HasFocus(9002)</visible>          <== Line 1038
            </control>
            <control type="label">
                <left>1</left>
                <top>125</top>
                <width>180</width>
                <height>20</height>
                <font>font12</font>
                <textcolor>grey2</textcolor>
                <align>center</align>
                <aligny>center</aligny>
                <label>$INFO[ListItem.Label]</label>
                <visible>!Control.HasFocus(9002)</visible>          <== Line 1050
            </control>

I believe that the 2 lines marked should read:

Code:
<visible>ControlGroup(9002).HasFocus</visible>

and

Code:
<visible>!ControlGroup(9002).HasFocus</visible>

respectively.


RE: [BUG & FIX] HomeAddonsCommonLayout include - ronie - 2015-04-06

thanx, we fixed that bug a few months ago:
https://github.com/xbmc/xbmc/commit/f185a3a6bd573f4888d7cc916730249a6b12a565


RE: [BUG & FIX] HomeAddonsCommonLayout include - dnairb - 2015-04-06

In Isengard, yes. In Helix? No. Despite the fact that there have 2 point releases of Kodi 14 since 12th January.

So, I published the above information so anybody using Helix with the Confluence skin, or derivatives, can fix it themselves.


RE: [BUG & FIX] HomeAddonsCommonLayout include - Martijn - 2015-04-06

Maybe you should have made that clear from your post that this for people who want to fix this in 14.2