+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Confluence (https://forum.kodi.tv/forumdisplay.php?fid=125)
+---- Thread: Solved movie set flag in listview. (/showthread.php?tid=223713)
movie set flag in listview. - un1versal - 2015-04-07
Essentially based on https://github.com/xbmc/xbmc/pull/6896
My progress is pitiful and pathetic due to lack in skinning skills
Lacking experience in skinning limits me, based on this PR above, I hacked around to tried to implement this into confluence.
See https://github.com/uNiversaI/kodi/commit/0a02a47f7d42c1d33d51193e37fc4cc608899eb1
Literally just copied the 3D flag implementation. I think.
**Before**
**After**
There are a few problems with this:
1) When you focus on the collection in list view, the flag disappears ***Battlestar Galactica Collection*** example
2) The flag is only visible in ***Media Info View 2*** I probably missed something somewhere if not the **3D** flag will have same issues.
3) Position is copied from 3D lfag implementation so it will overlap with 3D in some conditions.
For these 3 reason I dint PR this half hack as clearly my attempt is flawed but shows what is possible with the correct skinning skills. Would be nice to get it in and take listview a little closer when moviesets are listed.
Help please
If you are a Skinner and can help resolve the skinning implementation to PR to master kodi, it would be fantastic.
NEWS
This has now been merged and will be part of isengard.
See http://forum.kodi.tv/showthread.php?tid=223713&pid=1976799#pid1976799
RE: movie set flag in listview. - un1versal - 2015-04-07
I agree with da-anda's commentFully.
That flag (streamdetails) isnt added in my attempt https://github.com/uNiversaI/kodi/commit/0a02a47f7d42c1d33d51193e37fc4cc608899eb1 as Set.png isnt added to
skin.confluence/media/flagging/video the reason why it shows up on screenshots is because on my test I added it there to that location as well.
RE: movie set flag in listview. - un1versal - 2015-04-07
Seems this will be going somewhere after https://github.com/xbmc/xbmc/pull/6900 phil65 showing off his excellent skinner skills.
RE: movie set flag in listview. - Ned Scott - 2015-04-08
Nice!
RE: movie set flag in listview. - Danny3 - 2015-04-18
+1 I like the idea
RE: movie set flag in listview. - un1versal - 2015-04-18
Already been merged. to current development and for Isengard should have this already, Im using it since I only use development versions. Long overdue this bit 2 years later.
Now all we need is Movieset metadata and movieset poster scraping and database changes to get moviesets in-line with rest.
Thank you to mkorstiege for core changes and phil65 for the fantastic addition to confluence by removing skin code, hahahaha
RE: movie set flag in listview. - Danny3 - 2015-04-24
It would be nice if the icon can be different based collection completeness
I have collections with more than 5 movies and I have no way to tell If the collection has all movies
Ihave to go to the moviedb and seehow many movies should be in the collection
This takes some time
RE: movie set flag in listview. - un1versal - 2015-04-24
Thats not possible at the moment, and requires other work for scrapers, databases and core, which would be part of scraping the movieset metadata and is part of a feature request I made now nearly 2 years ago.