+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Feature Discussion (read-only) (https://forum.kodi.tv/forumdisplay.php?fid=183)
+--- Thread: Store skin theme and colours as skin variable (/showthread.php?tid=230318)
Store skin theme and colours as skin variable - Martijn - 2015-06-23
Currently theme and colour are stored as global settings and are reset when switching skins.
Ideally these should be moved to skin specific stored variables. This way switching skins you retain the theme/colour you choose for a specific skin.
Additionally these could be stored as skin specific settings as well:
- sounds
- startup window
- skin zoom
RE: Store skin theme and colours as skin variable - Koying - 2015-06-23
Maybe already answered, but is there a reason (beside historical) why the skin-specific data aren't stored in addon_data, like any plain addon?
If you experiment a bit with skins, guisettings.xml is spammed with skin settings forever, which, imo, doesn't belong there.
Furthermore, I don't know if it's related or my fault, but I more than often loose view settings when switching skins...
RE: Store skin theme and colours as skin variable - Martijn - 2015-06-23
(2015-06-23, 11:15)Koying Wrote: Maybe already answered, but is there a reason (beside historical) why the skin-specific data aren't stored in addon_data, like any plain addon?
If you experiment a bit with skins, guisettings.xml is spammed with skin settings forever, which, imo, doesn't belong there.
Furthermore, I don't know if it's related or my fault, but I more than often loose view settings when switching skins...
no one has ported it yet to be stored like other add-ons. so simply lack of time
There's some other thread where this was brought up as well. Ideally skin settings would indeed be completely stored in addon_data yes.
Same story as splitting up installed add-ons per profile.
viewsettings are stored in separate database so it could be that it stores the view ID specific to that skin. Switching to another skin might not have that view and it falls back to the default one. (don't shoot me if i'm wrong on this)
RE: Store skin theme and colours as skin variable - Montellese - 2015-06-23
View settings are saved per skin so you shouldn't loose those. But they are also per path.
Concerning skin settings there are (at least) two ways to move forward:
- Simply store the settings (in the same format) that we currently store in guisettings.xml into ther skin's addon data directory in a settings.xml file
- Force skinners to write a proper settings.xml like every other addon. That will allow us/them to also make use of the addon settings dialog but it will also limit their possibilities a lot.
The latter would completely unify the two settings systems but it would most likely be completely backwards incompatible for skins and would be a lot of work for skinners.
Also moving the whole addon settings system to the same system we now use for core settings is still on my TODO list and we're probably quite a bit closer now than we were with Helix (with the group titles/labels) but I think there are still features in the addon settings system that will be difficult / hacky to implement in the core settings system.
RE: Store skin theme and colours as skin variable - ronie - 2015-06-23
(2015-06-23, 14:16)Montellese Wrote: [*]Force skinners to write a proper settings.xml like every other addon. That will allow us/them to also make use of the addon settings dialog but it will also limit their possibilities a lot.
-1 for the reason you mentioned.
skin settings are very flexible and allow you to do just about anything.
addon settings on the other hand are limited and clumsy (especially the visible conditions).
RE: Store skin theme and colours as skin variable - Montellese - 2015-06-23
(2015-06-23, 14:21)ronie Wrote: -1 for the reason you mentioned.
skin settings are very flexible and allow you to do just about anything.
addon settings on the other hand are limited and clumsy (especially the visible conditions).
Yeah that's what I figured. But storing them in a settings.xml file in the skin's addon data instead of in guisettings.xml shouldn't be an issue right?
The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin (but that might already be the case right now, I don't really know).
RE: Store skin theme and colours as skin variable - Koying - 2015-06-23
(2015-06-23, 14:25)Montellese Wrote: The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin (but that might already be the case right now, I don't really know).
Not a (pure) downside, imo. At least, there would be a way to get rid of them.
Afaik, currently, just giving a skin a try makes those settings stick in guisettings forever.
RE: Store skin theme and colours as skin variable - ronie - 2015-06-23
(2015-06-23, 14:25)Montellese Wrote: But storing them in a settings.xml file in the skin's addon data instead of in guisettings.xml shouldn't be an issue right?yup that would be fine.
(2015-06-23, 14:25)Montellese Wrote: The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skinafaik we don't delete addon settings. ever.
Re: RE: Store skin theme and colours as skin variable - Martijn - 2015-06-23
(2015-06-23, 17:09)ronie Wrote:Indeed. Addons settings are kept forever, till user wipes his userdata of course. Uninstalling addons has no effect on this(2015-06-23, 14:25)Montellese Wrote: The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skinafaik we don't delete addon settings. ever.