(2021-08-20, 21:31)Tobby Wrote: Since there's no way to always get art in the original language like with title I'm wondering if there's a NFO tag to set the artwork language?

(2021-08-21, 02:55)pkscout Wrote: I'm looking at the API for TMDb, and it looks like there is a field for "original language."  I suppose in theory a setting could be added to the scraper to get art in the original language.  I might try it as an experiment with the TMDb TV Show scraper (since I manage that one).  If I can get it working, I can probably figure out a pull request for the TMDb movie scraper.  I don't have loads of time right now, so no promises.  Oh, and this would be for the default Python based scrapers in Kodi 19.

(2021-08-22, 21:17)Tobby Wrote:

(2021-08-21, 02:55)pkscout Wrote: I'm looking at the API for TMDb, and it looks like there is a field for "original language."  I suppose in theory a setting could be added to the scraper to get art in the original language.  I might try it as an experiment with the TMDb TV Show scraper (since I manage that one).  If I can get it working, I can probably figure out a pull request for the TMDb movie scraper.  I don't have loads of time right now, so no promises.  Oh, and this would be for the default Python based scrapers in Kodi 19.

That would be much appreciated. Thank you.

(2021-08-22, 22:24)pkscout Wrote:

(2021-08-22, 21:17)Tobby Wrote:

(2021-08-21, 02:55)pkscout Wrote: I'm looking at the API for TMDb, and it looks like there is a field for "original language."  I suppose in theory a setting could be added to the scraper to get art in the original language.  I might try it as an experiment with the TMDb TV Show scraper (since I manage that one).  If I can get it working, I can probably figure out a pull request for the TMDb movie scraper.  I don't have loads of time right now, so no promises.  Oh, and this would be for the default Python based scrapers in Kodi 19.

That would be much appreciated. Thank you.

Just as some expectation setting, I looked through the code for the TV show scraper, and it's going to be a good deal of work to change it to do this. I had forgotten that the TV show scraper asks for images at the same time it asks for the show info, so by the time I have the info on the original language it's too late.  I'd have to completely rework the image logic for that.

I *think* the movie scraper might just grab all the images and then sort out languages later, but I can't remember.  So, still on my list, but perhaps less likely than I had hoped.

(2021-08-22, 22:34)Tobby Wrote:

(2021-08-22, 22:24)pkscout Wrote:

(2021-08-22, 21:17)Tobby Wrote: That would be much appreciated. Thank you.

Just as some expectation setting, I looked through the code for the TV show scraper, and it's going to be a good deal of work to change it to do this. I had forgotten that the TV show scraper asks for images at the same time it asks for the show info, so by the time I have the info on the original language it's too late.  I'd have to completely rework the image logic for that.

I *think* the movie scraper might just grab all the images and then sort out languages later, but I can't remember.  So, still on my list, but perhaps less likely than I had hoped.

No matter the outcome I appreciate the effort. Thank you.

Also, today if my scraper is set to Swedish it downloads art in both English and Swedish. So the problem isn't really what it downloads, but which piece of art it chooses. I'm not sure it makes a difference, but maybe it's easier to have it choose the correct artwork to apply after downloading when it already collected the original language info.

(2021-08-23, 13:37)pkscout Wrote:

(2021-08-22, 22:34)Tobby Wrote:

(2021-08-22, 22:24)pkscout Wrote: Just as some expectation setting, I looked through the code for the TV show scraper, and it's going to be a good deal of work to change it to do this. I had forgotten that the TV show scraper asks for images at the same time it asks for the show info, so by the time I have the info on the original language it's too late.  I'd have to completely rework the image logic for that.

I *think* the movie scraper might just grab all the images and then sort out languages later, but I can't remember.  So, still on my list, but perhaps less likely than I had hoped.

No matter the outcome I appreciate the effort. Thank you.

Also, today if my scraper is set to Swedish it downloads art in both English and Swedish. So the problem isn't really what it downloads, but which piece of art it chooses. I'm not sure it makes a difference, but maybe it's easier to have it choose the correct artwork to apply after downloading when it already collected the original language info.

The scraper downloads English as the fallback (for everything, not just art) because many shows don't have translations (or other translations in the case of things like Japanese anime - TMDb is an English centric site, so everything at least has English).  So if what you're loading is always English shows and don't want the Swedish posters, then I could, in theory, have a setting for that (since I have both the English and Swedish posters already).  The problem is if, for instance, you were downloading Japanese anime, had your scraper set for Swedish, and still wanted the original language, the scraper wouldn't be able to do that without that larger rewrite.  And I feel like it I can't do both use cases I shouldn't do either.  But I'm going to ponder this awhile. Maybe a setting that says "always use English posters."

(2021-08-23, 13:45)Tobby Wrote:

(2021-08-23, 13:37)pkscout Wrote:

(2021-08-22, 22:34)Tobby Wrote: No matter the outcome I appreciate the effort. Thank you.

Also, today if my scraper is set to Swedish it downloads art in both English and Swedish. So the problem isn't really what it downloads, but which piece of art it chooses. I'm not sure it makes a difference, but maybe it's easier to have it choose the correct artwork to apply after downloading when it already collected the original language info.

The scraper downloads English as the fallback (for everything, not just art) because many shows don't have translations (or other translations in the case of things like Japanese anime - TMDb is an English centric site, so everything at least has English).  So if what you're loading is always English shows and don't want the Swedish posters, then I could, in theory, have a setting for that (since I have both the English and Swedish posters already).  The problem is if, for instance, you were downloading Japanese anime, had your scraper set for Swedish, and still wanted the original language, the scraper wouldn't be able to do that without that larger rewrite.  And I feel like it I can't do both use cases I shouldn't do either.  But I'm going to ponder this awhile. Maybe a setting that says "always use English posters."

Yeah, I see what you mean. Would it be possible to create a language tag for the nfo-file so I could choose the language manually or is that loads of work as well?

(2021-08-23, 18:45)pkscout Wrote:

(2021-08-23, 13:45)Tobby Wrote:

(2021-08-23, 13:37)pkscout Wrote: The scraper downloads English as the fallback (for everything, not just art) because many shows don't have translations (or other translations in the case of things like Japanese anime - TMDb is an English centric site, so everything at least has English).  So if what you're loading is always English shows and don't want the Swedish posters, then I could, in theory, have a setting for that (since I have both the English and Swedish posters already).  The problem is if, for instance, you were downloading Japanese anime, had your scraper set for Swedish, and still wanted the original language, the scraper wouldn't be able to do that without that larger rewrite.  And I feel like it I can't do both use cases I shouldn't do either.  But I'm going to ponder this awhile. Maybe a setting that says "always use English posters."

Yeah, I see what you mean. Would it be possible to create a language tag for the nfo-file so I could choose the language manually or is that loads of work as well?

nfo files get processed by Kodi not the scraper, so that would be a change to core Kodi code, and probably even more work.