Lyrics only downloaded partially - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27) +---- Forum: Lyrics Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=146) +---- Thread: Lyrics only downloaded partially (/showthread.php?tid=368183) |
Lyrics only downloaded partially - mr_blond18 - 2022-05-09 Recently I have been seeing lyrics that are only partially downloaded. It looks like this is especially happening with lyrics from genius.com, but I am not sure if it only happens there... Some still download ok, especially the ones which have timing info. As an example, this is a snippet of my log when lyrics are being (partially) downloaded: https://pastebin.ubuntu.com/p/s44YTY5x6w/ The subsequent lyrics file downloaded (userdata\addon_data\script.cu.lrclyrics\lyrics\Rammstein\Dicke Titten.txt) contains the following data: https://pastebin.ubuntu.com/p/9jVGnk9y8q/ If you visit the link that the plugin uses to download the lyrics you can see that only the first part is downloaded: https://genius.com/Rammstein-dicke-titten-lyrics Finally some system and kodi version info: https://pastebin.ubuntu.com/p/nwFmBcp3Ts/ Do you need more info to investigate? RE: Lyrics only downloaded partially - Klojum - 2022-05-09 (2022-05-09, 15:21)mr_blond18 Wrote: Do you need more info to investigate? How about simply providing the FULL Kodi debug log file instead of only a tiny header and a smart log part that you find interesting..? RE: Lyrics only downloaded partially - mr_blond18 - 2022-05-09 (2022-05-09, 15:57)Klojum Wrote:Ah ok, here it is:(2022-05-09, 15:21)mr_blond18 Wrote: Do you need more info to investigate? https://pastebin.ubuntu.com/p/prNhchbyhM/ In my original post I already extracted the relevant parts (according to my own analysis)... RE: Lyrics only downloaded partially - mr_blond18 - 2022-05-26 Alright, I got impatient and I looked into the issue myself... (not meant as criticism) It turns out the issue is in the script.cu.lrclyrics/lib/culrcscrapers/genius/lyricsScraper.py file. Apparently genius.com changed their website layout (lots of advertisements between the lyrics) and therefore wasn't properly scraped for lyrics. I fixed it with two changes:
I am not very experienced in programming, therefore I do not know if this works reliably... @ronie : can you check this code and see if you can fix this scraper properly? RE: Lyrics only downloaded partially - ronie - 2022-06-17 thx, the change looks ok to me. i'll add it to the next version. RE: Lyrics only downloaded partially - jabbermacy - 2022-06-30 hey guys, is this change LIVE yet? I have this issue all the time. ALSO, is there a key to force recheck if lyrics are wrong? |