+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Scrapers (https://forum.kodi.tv/forumdisplay.php?fid=60)
+--- Thread: The Movie Database Python scraping SVGs for clearlogos (/showthread.php?tid=372458)
The Movie Database Python scraping SVGs for clearlogos - realcopacetic - 2023-03-11
Hi, not sure if this is an issue anyone else has seen, but I'm using The Movie Database Python to scrape movies in Kodi 20.0. I recently noticed a clearlogo wasn't showing, but my fallback label also wasn't displaying.
I think this is because the clearlogo path scraped, for the movie Her (2013), is in svg format.
ListItem.Art(clearlogo) = https://image.tmdb.org/t/p/original/euFg9ZE59r6tWTq2vtjENupUdk7.svg
Indeed, that file is the first logo shown on the website: https://www.themoviedb.org/movie/152601-her/images/logos?language=en-GB
I can build resilience for this into my skin by igoring the path if it contains .svg, but I assume as Kodi doesn't support svg at all, this shouldn't be scraped?
Perhaps TMDB isn't supposed to accept svgs or perhaps it just wasn't a scenario that popped up before, but I just wanted to flag it here and see if this is something that should be raised as a bug fix for the scraper?
RE: The Movie Database Python scraping SVGs for clearlogos - Karellen - 2023-03-11
One for @rmrector
I don't think TMDB TV Shows has that problem as it doesn't scrape clearlogos from TMDB.
RE: The Movie Database Python scraping SVGs for clearlogos - pkscout - 2023-03-11
(2023-03-11, 20:26)Karellen Wrote: One for @rmrectorTMDB TV Shows does have code to do clear logos, so it should be grabbing them as long as the Kodi settings for image types is set to get them. If you scraped a show using 1.4.14 or earlier (Matrix) or 1.5.3 or earlier (Nexus), the scraper would have gotten the SVG file as well. I didn't know SVGs were even an option on TMDb, nor did I know Kodi didn't support them. Newer versions filter them out, but entries for the SVGs could still be in people's database depending on when they scrapped the show.
I don't think TMDB TV Shows has that problem as it doesn't scrape clearlogos from TMDB.
The bottom line is, I wouldn't spend time trying to filter them out at the skin level. If people have problems because they have SVGs in their clear logo list, just have them rescrape the show.
RE: The Movie Database Python scraping SVGs for clearlogos - Karellen - 2023-03-11
(2023-03-11, 21:32)pkscout Wrote: TMDB TV Shows does have code to do clear logosSorry, you are correct. I just tested.
I must have mis-remembered as I thought there was a time when clearlogos were not scraped from tmdb.
RE: The Movie Database Python scraping SVGs for clearlogos - realcopacetic - 2023-03-11
Cheers @pkscout. Will rescrape in that case
RE: The Movie Database Python scraping SVGs for clearlogos - pkscout - 2023-03-12
(2023-03-11, 21:50)Karellen Wrote:There probably was. That scraper evolved kind of quickly as I learned more about scraping.(2023-03-11, 21:32)pkscout Wrote: TMDB TV Shows does have code to do clear logosSorry, you are correct. I just tested.
I must have mis-remembered as I thought there was a time when clearlogos were not scraped from tmdb.
RE: The Movie Database Python scraping SVGs for clearlogos - rmrector - 2023-03-12
Yup, movie scraper is missing the code to filter out svg images. That's the first one I've seen for movies.
RE: The Movie Database Python scraping SVGs for clearlogos - realcopacetic - 2023-06-23
(2023-03-12, 17:32)rmrector Wrote: Yup, movie scraper is missing the code to filter out svg images. That's the first one I've seen for movies.
Just wanted to note that I saw on TMDB that the preference is now for SVGs, so this issue could become more common. If you hover over the ? next to format on clearlogos, the message reads: 'SVG's and PNG's are supported. SVG's are preferred since they are resolution independent." - So it may be something to consider filtering out at some point in the near future.
RE: The Movie Database Python scraping SVGs for clearlogos - Karellen - 2023-06-23
(2023-06-23, 14:05)realcopacetic Wrote: So it may be something to consider filtering out at some point in the near future.Already done for the movie scraper... https://github.com/xbmc/metadata.themoviedb.org.python/pull/185
Not sure if its done for the tv show scraper... Maybe @pkscout knows.
RE: The Movie Database Python scraping SVGs for clearlogos - realcopacetic - 2023-06-23
ah great sorry for missing the update @Karellen. In my haste to post I didn't think to actually check!
RE: The Movie Database Python scraping SVGs for clearlogos - pkscout - 2023-06-24
(2023-06-23, 22:34)realcopacetic Wrote: ah great sorry for missing the update @Karellen. In my haste to post I didn't think to actually check!The TMBb TV Show scraper also filters out SVG files already.