Kodi Community Forum
Solved [NVRMND] Skin doesn't respect visible flags in system/settings.xml - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: OS independent / Other (https://forum.kodi.tv/forumdisplay.php?fid=228)
+---- Thread: Solved [NVRMND] Skin doesn't respect visible flags in system/settings.xml (/showthread.php?tid=376357)

Pages: 1 2

[NVRMND] Skin doesn't respect visible flags in system/settings.xml - izprtxqkft - 2024-02-20

Settings categories still show up even if you edit the system/settings.xml file and add a tag <visible>false</visible>

to reproduce, edit settings.xml in system, go to a catagory such as PVR here https://github.com/xbmc/xbmc/blob/master/system/settings/settings.xml#L1625
add a flag <visible>false</visible>
open kodi and go to settings, pvr (or the one you added the flag to) is still visible and when you open it only the settings inside are hidden

expected behavior would be to have the item removed from settings like "Games" is when settings gamesgeneral.enable=false

RE: Skin doesn't respect visible flags in system/settings.xml - Hitcher - 2024-02-20

Visible tags are for skin XML files and will have no affect in settings.xml.

RE: Skin doesn't respect visible flags in system/settings.xml - izprtxqkft - 2024-02-20

(2024-02-20, 18:26)Hitcher Wrote: Visible tags are for skin XML files and will have no affect in settings.xml.

look, i already know nobody wants to acknowledge my issue reports but at least do me the favor of not calling me an idiot

as i can see here visible is used in settings.xml https://github.com/xbmc/xbmc/blob/master/system/settings/settings.xml#L1596

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

Works ok here

Image

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

Also why post this in Estuary section, has nothing to do with the skin.

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

Or do you actaully mean you want to hide the Sections? if so that's not possible, the visible tag only works on Categories within each Section.

[Edit] That's if you're editing the System -> settings.xml which contain the Kodi core settings.

RE: Skin doesn't respect visible flags in system/settings.xml - Hitcher - 2024-02-20

What I meant was it's not an Estuary issue if that tag doesn't work.

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

If you want to hide a Section completely then yes you can do that from the skin, but that a different settings.xml in that case you want the skin one, so for PVR it's this you'd need to edit https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/Settings.xml#L83-L87

[edit] So to hide PVR

xml:
					<item>

						<label>$LOCALIZE[14204]</label>

						<onclick>ActivateWindow(PVRSettings)</onclick>

						<visible>false</visible>

						<icon>icons/settings/livetv.png</icon>

					</item>

Image

RE: Skin doesn't respect visible flags in system/settings.xml - Hitcher - 2024-02-20

Actually just tested this out myself and while you can't hide sections in settings.xml you can hide categories.

RE: Skin doesn't respect visible flags in system/settings.xml - izprtxqkft - 2024-02-20

(2024-02-20, 20:37)jjd-uk Wrote: Works ok here

yes precisely that

(2024-02-20, 20:38)jjd-uk Wrote: Also why post this in Estuary section, has nothing to do with the skin.

because i expect that if in the settings gui and the entire category is hidden then the icon would be hidden as well
the way it behaves here https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/Settings.xml#L95 which hides the Games icon entirely if games is disabled
and that would have to be added to the skin in the same way

(2024-02-20, 20:47)Hitcher Wrote: What I meant was it's not an Estuary issue if that tag doesn't work.

same as answer above, the skin does not have a visible condition flag for when a setting category is not visible


the real question i suppose would be "is there even a flag that the skin can use to hide those the way games is hidden?"

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

You are confusing 2 entirely different files both named settings.xml

RE: Skin doesn't respect visible flags in system/settings.xml - izprtxqkft - 2024-02-20

(2024-02-20, 22:04)jjd-uk Wrote: You are confusing 2 entirely different files both named settings.xml

simplified:
if a setting category is hidden (visible false) via kodi settings then why is the skin showing it and ignoring the visible flag

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-20

The skin is not ignoring anything, as I've shown Categories are hidden just fine when a visible tag is is added to the System > settings.xml however if it's the Sections you wish to hide that can be done from the entirely different and separate Estuary settings.xml again as I've shown. Everything is operating as it should be, you simply have to modify the right file.

RE: Skin doesn't respect visible flags in system/settings.xml - izprtxqkft - 2024-02-20

(2024-02-20, 22:45)jjd-uk Wrote: The skin is not ignoring anything, as I've shown Categories are hidden just fine when a visible tag is is added to the System > settings.xml however if it's the Sections you wish to hide that can be done from the entirely different and separate Estuary settings.xml again as I've shown. Everything is operating as it should be, you simply have to modify the right file.

that's about what i expected

"displaying things that are marked <visible>false</visible> is completely normal"

and the next time i'm doing some CSS and i see an element displayed on the page that has "display: none" set i will just look through the javascript instead of the CSS because that makes more sense

RE: Skin doesn't respect visible flags in system/settings.xml - jjd-uk - 2024-02-21

Well perhaps you should explain exactly what you're trying to do then and provide screenshots, because I'm fed up wasting my time trying to help you while guessing at exactly what you want to achieve. Done the right way nothing is ignored, you can't just randomly insert code anywhere and expect it to do something.