[activoice]

In Confluence the Ending time of the video being played back only displays on the OSD screen, but not the Info screen.  I want it to display on the Info Screen...  I got it working but not sure if the place where I made the change is the correct place or not... (It works but maybe I should have made the change somewhere else)

I edited VideoFullScreen.XML and went to line 336 which controls the label for the ending time
<label>$LOCALIZE[31049] $INFO[Player.FinishTime]</label>

Then I updated line 342 from this
<visible>!Window.IsVisible(VideoOSD) + !VideoPlayer.Content(LiveTV)</visible>

to this, to comment out the line... 
<!-- <visible>!Window.IsVisible(VideoOSD) + !VideoPlayer.Content(LiveTV)</visible>-->

So now I see the Ending Time of the video on both the OSD and Info screens.


Is that the correct way of making that change or is there a better way?

[DaVu]

The end time for the OSD was already added by me some time ago: https://github.com/xbmc/skin.confluence/pull/52

If you don't see that, then you might use an older version of confluence.

The section you edited might work, but does not seem to be correct if you ask me. You could edit this line: https://github.com/xbmc/skin.confluence/...n.xml#L342

and change it to:

<visible>[Player.ShowInfo | Window.IsVisible(VideoOSD)] + !VideoPlayer.Content(LiveTV)</visible>

By adding the "Player.ShowInfo" we add a visibility state of the finish time to: "it's either visible if the Info page or the Windows 'VideoOSD' is visible/active". Using that should give you this while on the video info section:

https://i.imgur.com/Ai5Xny1.png

By commenting out the line you suggested, it's also visible at a Live-TV stream where an end time doesn't make sense as the end time is not meant for a single show on the livetv stream. So I would suggest, the better way to go is adding the "Player.ShowInfo" as a visibility condition

If you are familiar with github, feel free to PR it. If not, I will as I like the idea. But it was your idea, so I will not steal it

[jjd-uk]

It seems it's gone missing from the info OSD since the Confluence version for Krypton as it used be be there before with needing that Player.ShowInfo viability condition, so not sure why it doesn't display anymore without digging to into changes between Krypton and Leia. At the moment DaVu's solution seems the best way forward.

[activoice]

The end time for the OSD was already added by me some time ago: https://github.com/xbmc/skin.confluence/pull/52

If you don't see that, then you might use an older version of confluence.

The section you edited might work, but does not seem to be correct if you ask me. You could edit this line: https://github.com/xbmc/skin.confluence/...n.xml#L342

and change it to:

<visible>[Player.ShowInfo | Window.IsVisible(VideoOSD)] + !VideoPlayer.Content(LiveTV)</visible>

By adding the "Player.ShowInfo" we add a visibility state of the finish time to: "it's either visible if the Info page or the Windows 'VideoOSD' is visible/active". Using that should give you this while on the video info section:

https://i.imgur.com/Ai5Xny1.png

By commenting out the line you suggested, it's also visible at a Live-TV stream where an end time doesn't make sense as the end time is not meant for a single show on the livetv stream. So I would suggest, the better way to go is adding the "Player.ShowInfo" as a visibility condition

If you are familiar with github, feel free to PR it. If not, I will as I like the idea. But it was your idea, so I will not steal it

Yes I was seeing the end time in the OSD, but wanted it to appear on the info screen as well... I swear that it used to appear there before Leia, but then it looks like it got added to the pause screen, and went missing from the info screen.  I have fixed line 342 as you suggested.

Go ahead and feel free to add it to Github as a request I don't know how to do that - and I am probably too lazy to figure it out 

[DaVu]

Ok, np. Will do

[DaVu]

done: https://github.com/xbmc/skin.confluence/pull/56