2025-01-18, 16:57
Yesterday, 20:12
@ksooo I noticed that with the pvr.iptvsimple recordings, playback actions related to the queue playlist (play from here, play next, continue watching,...) fail. It can easily be reproduced with "Play from here"
or just adding the recording to the queue and trying to play it from the queue playlist. Use the same m3u I posted before with iptvsimple.
From the queue playlist the recording fails to be played but it plays without problems using "Play recording" from the "Recording Information" dialog:
This is the debug log with the latest master that already includes the [video][music] Fix playback of PVR recordings provided by add-ons implementing URL-based playback PR:
kodi.log
or just adding the recording to the queue and trying to play it from the queue playlist. Use the same m3u I posted before with iptvsimple.
From the queue playlist the recording fails to be played but it plays without problems using "Play recording" from the "Recording Information" dialog:
This is the debug log with the latest master that already includes the [video][music] Fix playback of PVR recordings provided by add-ons implementing URL-based playback PR:
kodi.log
Yesterday, 21:09
@A600 could you give this patch a try:
```
diff --git a/xbmc/PlayListPlayer.cpp b/xbmc/PlayListPlayer.cpp
index f9aba33733..95c0e85a3d 100644
--- a/xbmc/PlayListPlayer.cpp
+++ b/xbmc/PlayListPlayer.cpp
@@ -354,7 +354,13 @@ bool CPlayListPlayer:lay(int iSong,
m_bPlaybackStarted = false;
const auto playAttempt = std::chrono:teady_clock::now();
- bool ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+
+ bool ret{false};
+ if ((MUSIC::IsAudio(*item) || VIDEO::IsVideo(*item)) && !item->IsPVR())
+ ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+ else
+ ret = g_application.PlayMedia(*item, player, m_iCurrentPlayList);
+
if (!ret)
{
CLog::Log(LOGERROR, "Playlist Player: skipping unplayable item: {}, path [{}]", m_iCurrentSong,
```
```
diff --git a/xbmc/PlayListPlayer.cpp b/xbmc/PlayListPlayer.cpp
index f9aba33733..95c0e85a3d 100644
--- a/xbmc/PlayListPlayer.cpp
+++ b/xbmc/PlayListPlayer.cpp
@@ -354,7 +354,13 @@ bool CPlayListPlayer:lay(int iSong,
m_bPlaybackStarted = false;
const auto playAttempt = std::chrono:teady_clock::now();
- bool ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+
+ bool ret{false};
+ if ((MUSIC::IsAudio(*item) || VIDEO::IsVideo(*item)) && !item->IsPVR())
+ ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+ else
+ ret = g_application.PlayMedia(*item, player, m_iCurrentPlayList);
+
if (!ret)
{
CLog::Log(LOGERROR, "Playlist Player: skipping unplayable item: {}, path [{}]", m_iCurrentSong,
```
Yesterday, 21:48
(Yesterday, 21:09)ksooo Wrote: @A600 could you give this patch a tryPerfect! A million thanks.
Yesterday, 21:54
(Yesterday, 21:48)A600 Wrote:(Yesterday, 21:09)ksooo Wrote: @A600 could you give this patch a tryPerfect! A million thanks.
Does this mean you have tested the patch and it works?