[darthdiablo]

This is from Subscene.com, which clearly show there are 4 subtitle files, 2 of them the "HI" (Hearing Impaired) variation. Here's the screenshot of my manual search on that website:


However the XBMC subtitle addon only lists 2, which means it filtered 2 out of the 4 shown as available at Subscene.com:



For me, it's clear that I have preference to go with the "HI" variation - the XBMC Subtitle Add-On does not have those show up.

Thanks

edit: Retitled this post and also removed questions (that are now no longer relevant) after I discovered that there was some intention to fix this based on comments I see in the XBMC Subtitle addon github pages.

[darthdiablo]

Same issue for Family Guy:

[darthdiablo]

Can this part of the subtitle pattern be removed from the add-on repository? (the part in bold)

https://github.com/amet/script.xbmc.subt...service.py

subtitle_pattern = "..<tr>.{5}<td>.{6}<a class=\"a1\" href=\"/([^\n\r]{10,200}?-\d{3,10}.aspx)\" title=\"[^\n\r]{10,200}\">\
[\r\n\t ]+?<span class=\"r(0|100)\" >[\r\n\t\ ]+([^\r\n\t]+?) [\r\n\t]+</span>[\r\n\t ]+?<span id=\"r\d+\">([^\r\n\t]{5,500})</span>\
[\r\n\t]+?</a>[\r\n\t ]+?</td>[\r\n\t ]+?<td class=\"a3\">1[\r\n\t\ ]+?</td>[\r\n\t\ ]+?<td>(?!<div id=imgEar)"
# group(1) = downloadlink, group(2) = qualitycode, group(3) = language, group(4) = filename

Seeing how the HI variation does show up for http://opensubtitles.org/ when using XBMC Subtitle Addon, I'd like this fixed for Subscene because I noticed that the subtitles often shows up there before it does for opensubtitles.org.

If having HI variations show up is not desired behavior (despite the fact that it's still showing up in http://opensubtitles.org/) then how about adding a configuration option (a checkbox in the add-on configuration settings) for the users who are actually hearing impaired and would love to have this option?

I love this addon, it's why I find the time to look into this, I think it can be made better.

[darthdiablo]

Discovered a pull request by Martin Wallgren here https://github.com/amet/script.xbmc.subtitles/pull/94

This looks like the commit (that was mentioned by amet in the pull request page linked above) should have removed the exclusion of HI variations for Subscene service:

https://github.com/amet/script.xbmc.subt...748afc420e

I couldn't tell whether or not this commit (SHA 74246770bd3fdce87891397394aac6748afc420e) was ever merged into the master branch (or eden branch, or whichever is being used for releases)?

[amet]

Discovered a pull request by Martin Wallgren here https://github.com/amet/script.xbmc.subtitles/pull/94

This looks like the commit (that was mentioned by amet in the pull request page linked above) should have removed the exclusion of HI variations for Subscene service:

https://github.com/amet/script.xbmc.subt...748afc420e

I couldn't tell whether or not this commit (SHA 74246770bd3fdce87891397394aac6748afc420e) was ever merged into the master branch (or eden branch, or whichever is being used for releases)?

if its in my github it is or will be included in the official release at some point

[amet]

here it will be in the next official release

[darthdiablo]

here it will be in the next official release

Thank you sir Much appreciated!