Login at Kodi Home

djneil · 2018-04-03, 15:21

Hey,

I am glad to see you trying to make this work.
I appreciate that you sacrifice your time for this!

**phunkyfish** · 2018-07-31, 23:18

So I started on this using the latest dev build of libreelec based in Kodi 18. The idea was I would implement based on the latest version.

Guess what, you can now timeshift and I didn’t write a single line code!

djneil · 2018-09-02, 18:59

Kodi 18 Beta 1 on windows: no Timeshift.

**phunkyfish** · 2018-09-02, 19:46

(2018-09-02, 18:59)djneil Wrote: Kodi 18 Beta 1 on windows: no Timeshift.

Yes, it was there on the alpha but after spending a bit more time with it it wasn’t real. The buttons were there and it did pause a bit but that was it. If you pause for more than a few minutes it stopped working.

**phunkyfish** · 2018-09-06, 15:51

So I started this based on the latest kodi.

I've successfully ported the supporting calls from DVBViewer to VU+. Is it's playing using an inputstream. The only thing is the pause button is not appearing and I've no idea why. CanPauseStream correctly returns true but still no button to pause with.

I'm missing something simple. @ksooo any ideas what I might be doing wrong. I have all the work I've done in a local branch.

**phunkyfish** · 2018-09-06, 18:00

Ok, so I've gotten a bit further.

I have 3 modes, Timeshift Off, Timeshift on pause and Timeshift on playback.

I have timeshift on playback working but can't figure out how to get timeshift on pause working. @ksooo I have CanPauseStream and CanSeekStream implemented, is there anything extra that is required to see the pause button?

It may just be a logic error as it's been a very long time since I coded in C++!

**ksooo** · 2018-09-06, 18:20

https://github.com/xbmc/xbmc/pull/14389

**phunkyfish** · 2018-09-06, 19:08

(2018-09-06, 18:20)ksooo Wrote: https://github.com/xbmc/xbmc/pull/14389

Ok @ksooo does this mean that because I create the timeshift buffer On playback it shows the pause button but when I have it on pause it doesn't exist yet so it won't show?

**phunkyfish** · 2018-09-06, 20:07

@ksooo I created a PR with the changes. It's the first time I've used Git so hopefully all is in order or close to it.

**phunkyfish** · 2018-09-10, 00:24

@djneil

This is in the latest Milhouse Kodi 18 Libreelec build as of last night.

djneil · 2019-04-10, 21:39

(2018-09-10, 00:24)phunkyfish Wrote: @djneil

This is in the latest Milhouse Kodi 18 Libreelec build as of last night.

I appreciate what you did here. Thanks a lot Smile

**phunkyfish** · 2019-04-10, 21:56

You’re very welcome, hope you making good use of all the new features. I’ve run out of ones to implement!

djneil · 2019-04-10, 22:07

(2019-04-10, 21:56)phunkyfish Wrote: You’re very welcome, hope you making good use of all the new features. I’ve run out of ones to implement!

I just love the add-on since everything has changed! Big Grin

daily driver. Runs just awesome!