[MacGyver]

I break mine whenever I want, and can add what I want, but it's most often a quick and dirty kludge. I'm really only concerned about whether it works for me (or just simply whether or not it can be done). If others don't mind the lack of a guarantee, no support, and manually updating, have at it.

I often like to go back and steal jingai's cleaned up version of stuff I had originally written hastily.

[jingai]

Just noticed you actually force-updated your original fork, MacGyver.. hmm.. it's going to make picking out the skin.shortcuts stuff a lot harder :/

Would you mind breaking out those commits? I can do diffs by hand but it can be hard to tell which change is for what.

[MacGyver]

I had too, I was already getting confused as to which version I was working on, each with it's own different changes. Helix, Gotham, Personal. So I cut my personal one off from the official one. It helps me keep track of them better and allows me to make specific official fixes without all my crap getting in the way, but I have been getting a little confused on my own version, it should be straight now though.
If you want I can clone the current master (Helix) and add the skin.shortcut stuff fresh to it. That should make it easy to pull the diffs out of it.

[jingai]

That would definitely be helpful if you wouldn't mind.

---

Also, quick question: are the PVR issues with the GUI version at 5.0.1 anything major? I ask because if it turns out fixing the alignment issues tomorrow after bumping it to 5.3.0 are huge, then I may have to go with it as is. If so, I'll branch off the PVR changes and not include them for 3.0.0.

If the PVR changes are "better than nothing," even with the GUI version at 5.0.1, I'll leave them in, however.

[MacGyver]

They work mostly fine, a column missing in the channel view and a time column in 2 of the 3 guide views. It's just funny looking more than anything, I'd leave them in but maybe turn them off by default from showing in the main the menu. But I mean really, to even have PVR you have to be pretty good with computers, so I don't think it's going to make anyone go crazy if they are not aligned 100%.

It will look exactly like this:

[attachment=356]

Those are from the master running 5.0.1.

[jingai]

Ok. If the 5.3.0 bump causes me too much grief tomorrow I'll just push it as-is. Thanks again.

[MacGyver]

Done.
Menu-refactor off of clean Helix master



I added every swinging submenu I could think of, that way users can simply delete the ones they don't want and reshuffle the order of the ones they do, rather than trying to figure out how to add it later. Simply "Resetting All" will bring them all back and to their original positions.
I also wish it could simply "disable" objects, but it can't (believe me I tried), I also wish we could set the Icon, but again, the script can't do it, so it's not there.

I'm sure something's wrong with it given the speed at which I did it. I'm going to bed now.

[VelvetKevorkian]

Maybe this is add-on specific:
There was a major update for the YouTube addon, the popup for the sign in-code
does not appear with Metropolis, but does so e.g. with Confluence.

[MacGyver]

Maybe this is add-on specific:
There was a major update for the YouTube addon, the popup for the sign in-code
does not appear with Metropolis, but does so e.g. with Confluence.

Do you know of a skin it works correctly in?

[jingai]

It's because the 3rd line is hidden, if I had to guess... lemme have a look.

edit: fixed.

[jingai]

@MacGyver (and anyone else that knows how and is willing to), would you mind pulling the master branch from my repo and giving it a whirl? I incrementally bumped the GUI version from 5.0.1 to 5.3.0 and so far, everything seems to be aligned correctly. But I have to attend to some other issues around the house now.. if I could get some more eyes on it today to make sure I found all of the misaligned elements, that'd be fantastic.

Assuming there are no more visual issues, Issue 286 is the final remaining issue before I can release 3.0.0.

One last caveat... I did just submit a pull request for 2.9.1 for Gotham, and I think I might wait until I hear back from the devs on that pull request before moving ahead with the Helix pull request, just in case their scrubber finds any issues. Hopefully they'll get to it today, but it might be a day or two longer. Sorry in advance if that turns out to be the case, folks.

[MacGyver]

I tried the most recent from the git, and there are still alignment issues. (that 5.3.0 is killer on skins using the old alignment method)
The third menu (main menu is offset, sub is fine), the rating and star in list mode (missing,misaligned in both movies and tv), and the now playing album cuts into the 2nd and 3rd home submenus (and is only showing on some of the selections). Kodi and Metropolis logo in 2nd home (and I'm guessing the 3rd home too) are see through and hard to make out, and mis-aligned.

PVR looks fine, and works fine. Most other things seem fine. All the other views seem fine.




Here is everything their scrubber should find "wrong":

Code:

Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 58]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 98]
Not Found: folder-focus.png - [MyPVRGuide.xml : Line 192]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 347]
Not Found: black-back2.png - [MyPVRGuide.xml : Line 459]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 466]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 692]
Not Found: black-back2.png - [MyPVRGuide.xml : Line 804]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 811]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 1026]
Not Found: black-back2.png - [MyPVRGuide.xml : Line 1118]
Not Found: tvguide-program-grey-nofocus.png - [MyPVRGuide.xml : Line 1125]
Not Found: black-back.png - [MyPVRGuide.xml : Line 1253]
Not Found: overlaydialogbackground.png - [PlayerControls.xml : Line 330]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 1349]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 1482]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 1615]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 1748]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 1881]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 2014]
Not Found: {fallback} empty.png - [script-NextAired-TVGuide.xml : Line 2147]
Not Found: top250.png - [script_rating_update-main.xml : Line 37]
Not Defined: font18 - [DialogSubtitles.xml : Line 148]
Not Defined: font18 - [DialogSubtitles.xml : Line 176]
Not Defined: font18 - [DialogSubtitles.xml : Line 221]
Not Defined: font18 - [DialogSubtitles.xml : Line 249]
Not Defined: font18 - [DialogSubtitles.xml : Line 391]
Not Defined: font18 - [DialogSubtitles.xml : Line 421]
Not Defined: font-20 - [Includes.xml : Line 253]
Not Defined: Font_Bartowski_Episodes - [MusicVisualisation.xml : Line 200]
Not Defined: Font_Bartowski_Episodes - [MusicVisualisation.xml : Line 228]
Not Defined: Font_Bartowski_Episodes - [MusicVisualisation.xml : Line 243]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 422]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 443]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 561]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 582]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 767]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 788]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 906]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 927]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 1081]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 1102]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 1200]
Not Defined: METF_DialogDetails - [MyPVRGuide.xml : Line 1221]
Not Defined: METF_TitleText_title - [PlayerControls.xml : Line 350]
Not Defined: METF_TitleText_title - [PlayerControls.xml : Line 364]
Not Defined: METF_TitleText_title - [PlayerControls.xml : Line 378]
Not Defined: font13_title - [PlayerControls.xml : Line 394]
Not Defined: font12_title - [script_rating_update-main.xml : Line 98]
Not Defined: METF_TitleTextSmall - [Viewtype_Panel_Square.xml : Line 73]
Not Defined: METF_TitleTextSmall - [Viewtype_Panel_Square.xml : Line 85]
Unused Font: METF_IMDbRating - [Font.xml : Line 92]
Unused Font: METF_HeadingDetails - [Font.xml : Line 102]
Unused Font: METF_PlotTextSpaced - [Font.xml : Line 162]
Unused Font: METF_WeatherDayDate24Hour - [Font.xml : Line 301]
Unused Include: MediaFlagsVarsMPAA - [Includes.xml : Line 406]
Unused Include: SettingsHeaderLabel - [Includes.xml : Line 943]
Unused Include: Animation_MenuFocus - [Includes_Animations.xml : Line 33]
Unused Include: Animation_ZoomOutZoomIn - [Includes_Animations.xml : Line 49]
Unused Include: Animation_PosterInfoHide - [Includes_Animations.xml : Line 150]
Unused Include: Animation_PosterInfoHide2 - [Includes_Animations.xml : Line 156]
Unused Include: Animation_Files_PosterInfoHide - [Includes_Animations.xml : Line 162]
Unused Include: Animation_Files_EpisodeInfoHide - [Includes_Animations.xml : Line 168]
Unused Include: Animation_ListFloat - [Includes_Animations.xml : Line 183]
Unused Variable: RatingColor - [Includes_Variables.xml : Line 23]
custom_DialogFavourites.xml: Invalid Value for //control[@type='label']/*: focusedcolor
custom_DialogFavourites.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogFavourites.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogFavourites.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogFileStacking.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogFileStacking.xml: Invalid Value for //control[@type='label']/*: focusedcolor
Double XML Tag: aligny in DialogPictureInfo.xml
DialogSelect.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogSelect.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogSelect.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogSelect.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogSelect.xml: Invalid Value for //control[@type='textbox']/*: focusedcolor
DialogSlider.xml: Invalid Value for //control[@type='label']/*: focusedcolor
DialogSlider.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
FileManager.xml: Invalid Value for //control[@type='label']/*: focusedcolor
Includes.xml: Invalid Value for align: false
Double XML Tag: scroll in Includes.xml
Double XML Tag: textcolor in Includes.xml
Double XML Tag: textcolor in Includes.xml
Includes_Animations.xml: Invalid Value for //*[(@align)]: bottom
Includes_HomeDeck.xml: Invalid Value for //control[@type='button']/*: texture
MusicOSD.xml: Invalid Value for //control[@type='button']/*: altclick
MusicOSD.xml: Invalid Value for //control[@type='button']/*: altclick
MusicOSD.xml: Invalid Value for //control[@type='button']/*: altclick
MusicOSD.xml: Invalid Value for //control[@type='button']/*: usealttexture
Double XML Tag: textcolor in MusicOSD.xml
Double XML Tag: textcolor in MusicOSD.xml
MusicVisualisation.xml: Invalid Value for //control[@type='progress']/*: align
MusicVisualisation.xml: Invalid Value for //control[@type='progress']/*: align
MusicVisualisation.xml: Invalid Value for aligny: -
MusicVisualisation.xml: Invalid Value for aligny: -
MyWeather.xml: Invalid Value for //control[@type='textbox']/*: wrapmultiline
MyWeather.xml: Invalid Value for //control[@type='textbox']/*: scroll
PlayerControls.xml: Invalid Value for //control[@type='button']/*: bordersize
PlayerControls.xml: Invalid Value for //control[@type='button']/*: aspectratio
Double XML Tag: texturefocus in PlayerControls.xml
Double XML Tag: texturenofocus in PlayerControls.xml
SettingsCategory.xml: Invalid Value for //control[@type='button']/*: alttexturefocus
SettingsCategory.xml: Invalid Value for //control[@type='button']/*: alttexturenofocus
SettingsProfile.xml: Invalid Value for //control[@type='radiobutton']/*: textureradiofocus
SettingsProfile.xml: Invalid Value for //control[@type='radiobutton']/*: textureradionofocus
SettingsProfile.xml: Invalid Value for //control[@type='label']/*: focusedcolor
SettingsProfile.xml: Invalid Value for //control[@type='label']/*: focusedcolor
SettingsProfile.xml: Invalid Value for //control[@type='label']/*: focusedcolor
SkinSettings.xml: Invalid Value for //control[@type='button']/*: onload
SkinSettings.xml: Invalid Value for //control[@type='button']/*: onload
SkinSettings.xml: Invalid Value for //control[@type='label']/*: focusedcolor
SkinSettings.xml: Invalid Value for //control[@type='label']/*: focusedcolor
VideoOSDSettings.xml: Invalid Value for //control[@type='radiobutton']/*: textureradiofocus
VideoOSDSettings.xml: Invalid Value for //control[@type='radiobutton']/*: textureradionofocus
Double XML Tag: fadetime in Viewtype_List.xml
Viewtype_LowList.xml: Invalid Attribute for aspectratio: background
Viewtype_LowList.xml: Invalid Attribute for aspectratio: background
Viewtype_LowList.xml: Invalid Attribute for aspectratio: background
Viewtype_LowList.xml: Invalid Attribute for aspectratio: background
DialogVideoInfo.xml: Untranslated Label:TvTunes Downloader
Includes_PVR.xml: Untranslated Label:View Options
Includes_PVR.xml: Untranslated Label:Sort: Descending
Includes_PVR.xml: Untranslated Label:Sort: Ascending

But out of those the only real things that they could call problems would be:

Code:

Not Found: tvguide-program-grey-nofocus.png
Not Found: black-back2.png
Not Found: black-back.png
Not Found: folder-focus.png
Not Found: overlaydialogbackground.png
Not Found: {fallback} empty.png
Not Found: top250.png

Not Defined: font18
Not Defined: font-20
Not Defined: Font_Bartowski_Episodes
Not Defined: METF_DialogDetails
Not Defined: METF_TitleText_title
Not Defined: font13_title
Not Defined: METF_TitleTextSmall

I think examples of those exist already. Everything else is looking good.

[jingai]

The third menu (main menu is offset, sub is fine),

This really isn't a 5.3.0 thing... it's that I was shooting for getting 4 items on-screen at any given time and giving them all equal space.. but yeah, it doesn't look right..

Would you mind dealing with this one? The wife is bugging me to fix other things around the house.. if you don't get the chance, it's ok, I'll do it tomorrow. Whatever you decide looks best is fine with me. I don't use Home3 anyway

the rating and star in list mode (missing,misaligned in both movies and tv),

I did this on purpose, as there's another Issue out on the ratings/star thing anyway. I actually never really intended to include it in the release until it was done.. it got in there by accident and just kinda.. stayed there..

and the now playing album cuts into the 2nd and 3rd home submenus

Fixed.

(and is only showing on some of the selections).

This is intentional -- if there might not be enough room, it doesn't show the album text.

Kodi and Metropolis logo in 2nd home (and I'm guessing the 3rd home too) are see through and hard to make out, and mis-aligned.

I'll fix the alignment. I actually just removed the logo from Home3.. might do the same for Home2. Eh, screw it, removed it just to make it match the other two

[jingai]

Fixed the fonts and missing PVR images. They're gonna kick back the pull request for the untranslated strings, so doing that now.

[jingai]

After the Home3 style is cleaned up, and assuming no one finds any other alignment issues, I'll push up 3.0.0. Going to save Issue #286 for a point release since it's not a really big deal.

These issues are what stand in the way of the release now