Login at Kodi Home

**mikeSiLVO** · 2024-06-30, 01:13

I'm not really sure what you are asking with the pop up bubbles.

Let's start from the beginning. Can you tell me what you want to see happen?

Then we can go from there and take it step by step :)

**kittmaster** · 2024-06-30, 01:32

(2024-06-30, 01:13)mikeSiLVO Wrote: I'm not really sure what you are asking with the pop up bubbles.

Let's start from the beginning. Can you tell me what you want to see happen?

Then we can go from there and take it step by step

When you first click on the movie, you get the "landing screen", you see, trailer, tmdb info, director, rating, similar, settings, etc... and all of remaining buttons.... that is the "normal" expectation no ask there.

When you click on the "tmdb info" button, in the last video I showed, what it shows, is that ALL of the buttons listed above, go away, and new ones are created, because the script is creating an "new" but similar layout except that now the new buttons are now defined as: Crew, Set, Similar, Videos, and Info.

The "info" happens to contain the fields that you had me test, awards, budget etc... so embuary has 3 unique xmls for video, person, image as you are aware. So for this "movie" when I click "tmdb info" I am trying to reconcile how to recreate the workflow of Crew, Set, Similar, Videos, and Info as shown in the last video. That is really the purpose of that video, just to show that it is "redrawing" the screen, updating the buttons, and providing the "tmdb" data based on the movie itself.

Now, I know tmdb helper is probably going to change that flow, so I'm trying to figure out exactly how that needs to be done since you mentioned the helper is doing it all "on one screen" which negates embuary's method... does that clarify my concern? I'm not entirely sure how to not lose the functionality due to the new implementation of an all on one page vs a "sub page" type of workflow.

**mikeSiLVO**

You can add a crew or whatever panel in the same place that the other ones are. Just use the content path you want.
Something like the below for crew:

xml:
plugin://plugin.video.themoviedb.helper?info=discover&amp;type=movie&amp;with_crew=$INFO[ListItem.Label]

There is also a recommendations dialog that you can use which may be closer to the separate dialog you're used to from Embuary Info:
https://github.com/jurialmunkey/plugin.v...ons-Dialog

(2024-06-30, 01:32)kittmaster Wrote: Now, I know tmdb helper is probably going to change that flow, so I'm trying to figure out exactly how that needs to be done since you mentioned the helper is doing it all "on one screen" which negates embuary's method... does that clarify my concern? I'm not entirely sure how to not lose the functionality due to the new implementation of an all on one page vs a "sub page" type of workflow.

It sort of still is a "sub page". It opens up another instance of the video info dialog and when you click to open other things populated from the script it remembers and you can backtrack all the way to when you first clicked the button.

**kittmaster** · 2024-06-30, 02:18

I think THAT might be the ticket.... I'll need to read up on it as I was hyperfocused on the other thing....

**mikeSiLVO** · 2024-06-30, 02:29

My implementation is pretty basic but it might help to see how I added it:
https://github.com/MikeSiLVO/skin.aeon.n...ations.xml

https://github.com/MikeSiLVO/skin.aeon.n...ations.xml

https://github.com/MikeSiLVO/skin.aeon.n...o.xml#L537

**kittmaster** · 2024-06-30, 02:49

I will add the same way, I think if I get the gist, I'll be able to fill in the blanks.... Smile

**kittmaster** · 2024-06-30, 22:33

Got late last night and eyes glazed over....tried to follow your version of the string... called it quits in frustration.

I had to start using the example at the wiki. Here is what I have which of course doesn't work.

Custom_1191.xml

xml:




<?xml version="1.0" encoding="UTF-8"?>

<window type="window" id="1191">

        <!-- Backdrop -->

        <include content="BackgroundDefault">

            <param name="imagepath">$VAR[HomeFanartVar]</param>

            <param name="animatedfanart">Skin.HasSetting(HomeAnimatedFanart)</param>

        </include>

</window>

script-tmdbhelper-recommendations.xml

xml:




<?xml version="1.0" encoding="UTF-8"?>

<window type="dialog">

    <defaultcontrol always="true">6000</defaultcontrol>

    <controls>

        <control type="grouplist" id="6000">

            <control type="list" id="5000">

                <include>MyPosterListDefinition</include>

            </control>

            <control type="list" id="5001">

                <include>MyPosterListDefinition</include>

            </control>

        </control>

    </controls>

</window>

Includes_InfoDialogs.xml ~ Line 192

xml:




                    <item id="101">

                        <description>TMDb info</description>

                        <visible>Skin.HasSetting(VideoInfoTMDb)</visible>

                        <label></label>

                        <label2>$LOCALIZE[31351]</label2>

                        <!-- <onclick>Dialog.Close(all)</onclick> -->

                        <!-- <onclick>$VAR[VideoInfoTMDbVar]</onclick> -->

                        <!-- <onclick>$VAR[VideoInfoTMDbVar2]</onclick> -->

                        <!-- <onclick>RunScript(plugin.video.themoviedb.helper,add_query=$INFO[ListItem.Label],type=movie,call_auto=1190)</onclick> -->

                        <onclick>Runscript(plugin.video.themoviedb.helper,recommendations=5000|info=cast|true|info,window_id=1191,tmdb_type=movie,tmdb_id=348)</onclick>

                    </item>

When I click on the button... it flashes see log for error which is:

Code:

2024-06-30 16:16:00.673 T:2832    debug <general>: CPythonInvoker(29, D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py): start processing

2024-06-30 16:16:00.712 T:2832    debug <general>: -->Python Interpreter Initialized<--

2024-06-30 16:16:00.712 T:2832    debug <general>: 

2024-06-30 16:16:00.712 T:2832    debug <general>: CPythonInvoker(29, D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py): the source file to load is "D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py"

2024-06-30 16:16:00.713 T:2832    debug <general>: CPythonInvoker(29): full python path:

2024-06-30 16:16:00.713 T:2832    debug <general>: CPythonInvoker(29):   custom python path:

2024-06-30 16:16:00.714 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\addons\script.module.pil\lib

2024-06-30 16:16:00.714 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper

2024-06-30 16:16:00.714 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.addon.signals\lib

2024-06-30 16:16:00.714 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.certifi\lib

2024-06-30 16:16:00.715 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.chardet\lib

2024-06-30 16:16:00.715 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.idna\lib

2024-06-30 16:16:00.715 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.requests\lib

2024-06-30 16:16:00.715 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\portable_data\addons\script.module.urllib3\lib

2024-06-30 16:16:00.716 T:2832    debug <general>: CPythonInvoker(29):   default python path:

2024-06-30 16:16:00.716 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\system\python\DLLs

2024-06-30 16:16:00.716 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\system\python\Lib

2024-06-30 16:16:00.716 T:2832    debug <general>: CPythonInvoker(29):     D:\Appz\Kodi_Portables\Omega\system\python\Lib\site-packages

2024-06-30 16:16:00.716 T:2832    debug <general>: CPythonInvoker(29): adding args:

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29):  script.py

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29):  recommendations=5000|info=cast|true|info

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29):  window_id=1191

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29):  tmdb_type=movie

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29):  tmdb_id=348

2024-06-30 16:16:00.717 T:2832    debug <general>: CPythonInvoker(29, D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py): entering source directory D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper

2024-06-30 16:16:00.718 T:2832    debug <general>: CPythonInvoker(29, D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py): instantiating addon using automatically obtained id of "plugin.video.themoviedb.helper" dependent on version 3.0.0 of the xbmc.python api

2024-06-30 16:16:00.827 T:2832    error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                                   Error Type: <class 'KeyError'>

                                                   Error Contents: 'pop from an empty set'

                                                   Traceback (most recent call last):

                                                     File "D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py", line 7, in <module>

                                                       Script(*sys.argv[1:]).router()

                                                     File "D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\resources\lib\script\router.py", line 96, in router

                                                       route_taken = set.intersection(routes_available, params_given).pop()

                                                   KeyError: 'pop from an empty set'

                                                   -->End of Python script error report<--

2024-06-30 16:16:00.827 T:2832    debug <general>: CPythonInvoker::onExecutionDone(29, D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py)

2024-06-30 16:16:00.838 T:16592   debug <general>: ------ Window Init (DialogNotification.xml) ------

2024-06-30 16:16:00.904 T:2832    debug <general>: Python interpreter stopped

2024-06-30 16:16:00.904 T:2832    debug <general>: Thread LanguageInvoker 2832 terminating

I was hoping it would just be a simple drop in...not sure if I missed something simple.

**mikeSiLVO** · 2024-06-30, 23:32

What is in your MyPosterListDefinition include?

If it is empty or doesn't exist then that is probably what the error is.

**kittmaster** · 2024-06-30, 23:52

Zippo...does not exist.

**kittmaster** · 2024-07-01, 02:18

I updated the code, still no joy:

xml:




                    <item id="101">

                        <description>TMDb info</description>

                        <visible>Skin.HasSetting(VideoInfoTMDb)</visible>

                        <label></label>

                        <label2>$LOCALIZE[31351]</label2>

                        <onclick>RunScript(plugin.video.themoviedb.helper,action=details,tmdb_type=movie,tmdb_id=$INFO[ListItem.Property(TMDbId)])</onclick>

                    </item>

xml:




<?xml version="1.0" encoding="UTF-8"?>

<window type="dialog" id="1191">

    <defaultcontrol always="true">6000</defaultcontrol>

    <controls>

        <control type="grouplist" id="6000">

            <control type="list" id="5000">

                <!-- The content of this list will be filled by the script -->

            </control>

            <control type="list" id="5001">

                <!-- The content of this list will be filled by the script -->

            </control>

        </control>

    </controls>

</window>

xml:




<?xml version="1.0" encoding="UTF-8"?>

<window type="window" id="1191">

    <controls>

                <!-- Backdrop -->

        <include content="BackgroundDefault">

            <param name="imagepath">$VAR[HomeFanartVar]</param>

            <param name="animatedfanart">Skin.HasSetting(HomeAnimatedFanart)</param>

        </include>

    </controls>

</window>

Code:

2024-06-30 20:11:48.049 T:20280   error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!

                                                   Error Type: <class 'KeyError'>

                                                   Error Contents: 'pop from an empty set'

                                                   Traceback (most recent call last):

                                                     File "D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\script.py", line 7, in <module>

                                                       Script(*sys.argv[1:]).router()

                                                     File "D:\Appz\Kodi_Portables\Omega\portable_data\addons\plugin.video.themoviedb.helper\resources\lib\script\router.py", line 96, in router

                                                       route_taken = set.intersection(routes_available, params_given).pop()

                                                   KeyError: 'pop from an empty set'

                                                   -->End of Python script error report<--

**mikeSiLVO**

There are a few things I can see that wouldn't work.

The onclick wouldn't open the recommendations.
The script recommendations window doesn't need an id but if it did it shouldn't be the same as the custom window for the background.
Also if the dialog did open it would be completely empty cause you have no controls defined for list id="5000".

I had another thought about the error. Are you using the latest from jurials repo?
The one in the Kodi repo wouldn't work cause the recommendations dialog was added way after that functionality was implemented.

**kittmaster** · 2024-07-01, 04:07

It is showing 4.10.14.... oh crap, I think it is supposed to be 5+?

But shouldn't it have updated?

**mikeSiLVO** · 2024-07-01, 04:12

Only if you have his repo.

There are install instructions on the first page of his wip skin thread.

https://forum.kodi.tv/showthread.php?tid...pid3160244

**kittmaster** · 2024-07-01, 04:18

5.2.26 now installed.

**mikeSiLVO** · 2024-07-01, 06:29

Mocked up a basic recommendations dialog based on DialogVideoInfo.xml.

Latest commit in the tmdbh_test branch.