[ksooo]

> Compiled the PR with the fix and working as before

@A600 thanks for letting me know.

[A600]

@ksooo I noticed that with the pvr.iptvsimple recordings, playback actions related to the queue playlist (play from here, play next, continue watching,...) fail. It can easily be reproduced with "Play from here" 
or just adding the recording to the queue and trying to play it from the queue playlist. Use the same m3u I posted before with iptvsimple.

From the queue playlist the recording fails to be played but it plays without problems using "Play recording" from the "Recording Information" dialog:




This is the debug log with the latest master that already includes the [video][music] Fix playback of PVR recordings provided by add-ons implementing URL-based playback PR:

kodi.log

[ksooo]

Please open an issue at github.

[ksooo]

@A600 could you give this patch a try: 
```
diff --git a/xbmc/PlayListPlayer.cpp b/xbmc/PlayListPlayer.cpp
index f9aba33733..95c0e85a3d 100644
--- a/xbmc/PlayListPlayer.cpp
+++ b/xbmc/PlayListPlayer.cpp
@@ -354,7 +354,13 @@ bool CPlayListPlayer:lay(int iSong,
   m_bPlaybackStarted = false;
 
   const auto playAttempt = std::chrono:teady_clock::now();
-  bool ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+
+  bool ret{false};
+  if ((MUSIC::IsAudio(*item) || VIDEO::IsVideo(*item)) && !item->IsPVR())
+    ret = g_application.PlayFile(*item, player, bAutoPlay, forceSelection);
+  else
+    ret = g_application.PlayMedia(*item, player, m_iCurrentPlayList);
+
   if (!ret)
   {
     CLog::Log(LOGERROR, "Playlist Player: skipping unplayable item: {}, path [{}]", m_iCurrentSong,

```

[A600]

@A600 could you give this patch a try

Perfect! A million thanks.

[ksooo]

@A600 could you give this patch a try

Perfect! A million thanks.

Does this mean you have tested the patch and it works?

[A600]

Yes. Tested and working flawlessly.

[ksooo]

@A600 https://github.com/xbmc/xbmc/pull/26346

[A600]

https://github.com/xbmc/xbmc/pull/26346

Tested and no regressions detected.

[ksooo]

> Tested and no regressions detected.

But I have. That PR needs a bit more love from my end.

[A600]

@ksooo After more testings I found a problem.
With this m3u that has 4 recordings:
 

Code:

#EXTM3U

#EXTINF:-1 tvg-id="" tvg-logo="" group-title="TEST",Recording 1
#EXT-X-PLAYLIST-TYPE:VOD
#KODIPROP:mimetype=application/dash+xml
#KODIPROP:inputstream=inputstream.adaptive
https://ott.dolby.com/OnDelKits/DDP/Dolby_Digital_Plus_Online_Delivery_Kit_v1.5/Test_Signals/example_streams/DASH/OnDemand/MPD/Holi_25fps_example_1_clean.mpd

#EXTINF:-1 tvg-id="" tvg-logo="" group-title="TEST",Recording 2
#EXT-X-PLAYLIST-TYPE:VOD
#KODIPROP:mimetype=application/dash+xml
#KODIPROP:inputstream=inputstream.adaptive
https://dash.akamaized.net/dash264/TestCases/5a/nomor/1.mpd

#EXTINF:-1 tvg-id="" tvg-logo="" group-title="TEST",Recording 3
#EXT-X-PLAYLIST-TYPE:VOD
#KODIPROP:inputstream=inputstream.adaptive
https://demo.unified-streaming.com/k8s/features/stable/video/tears-of-steel/tears-of-steel.ism/.m3u8

#EXTINF:-1 tvg-id="" tvg-logo="" group-title="TEST",Recording 4
#EXT-X-PLAYLIST-TYPE:VOD
#KODIPROP:mimetype=application/dash+xml
#KODIPROP:inputstream=inputstream.adaptive
https://media.axprod.net/TestVectors/v7-Clear/Manifest_1080p.mpd

if I play the folder


after the first recording (Recording 1) is finished, the next recording played is still the same Recording 1 so it seems the playlist doesn't advance.

Latest master with the PR applied:

kodi.log

[ksooo]

> after the first recording (Recording 1) is finished, the next recording played is still the same Recording 1 so it seems the playlist doesn't advance.

That's the same regression I found, yes.