Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
WIP uri2addon
#31
(2015-06-07, 16:40)Razze Wrote:
(2015-06-07, 16:19)Lunatixz Wrote: [...]
I'm playing devil's advocate here... prompts should be limited and not repetitive... avg youtube video is 4 mins, so users should prepare to click a prompt for each video?... what happens if they put together a playlist? endless waiting by the tv just to select which plugin should handle the media?

[...]

I would think playlists just get called one time at the initialization with the corresponding url. So it would be only one dialog if you havent setup anything. Everything after that is still handled by the addon which then is called.

correct.
Reply
#32
(2015-06-07, 16:43)bromix Wrote:
(2015-06-07, 16:40)Razze Wrote:
(2015-06-07, 16:19)Lunatixz Wrote: [...]
I'm playing devil's advocate here... prompts should be limited and not repetitive... avg youtube video is 4 mins, so users should prepare to click a prompt for each video?... what happens if they put together a playlist? endless waiting by the tv just to select which plugin should handle the media?

[...]

I would think playlists just get called one time at the initialization with the corresponding url. So it would be only one dialog if you havent setup anything. Everything after that is still handled by the addon which then is called.

correct.
I was referring to queueing URLs from some future app that uses this service... Not YouTube playlists Smile
Image Lunatixz - Kodi / Beta repository
Image PseudoTV - Forum | Website | Youtube | Help?
Reply
#33
Small update....substitution via regex is now possible. So an addon can describe how to transform a simple URLs into the call for the addon:

https://www.youtube.com/watch?v=shVBRKE6rgY

will be:
Code:
plugin://plugin.video.youtube/play/?video_id=shVBRKE6rgY

That's for me today Smile have a nice weekend Smile
Reply
#34
Great add-on bromix. Would be a great addition for casting via the kore app. Select link source ie. YouTube -open kore-send to kodi.

I know you can use kodi YouTube add-on to link your device but this is much more user friendly.

Thanks
Reply
#35
So is this blocked by anything or whats the plan here?
Reply
#36
(2015-06-12, 09:50)Razze Wrote: So is this blocked by anything or whats the plan here?

I don't know...I don't get further feedback Sad Maybe I have to contact some specific people of KODI to decide how to proceed.

I would love to do more with this. At least we have to do more planing and testing...but I think KODI could benefit with this simple/slim addon like this one.
Reply
#37
(2015-06-12, 09:59)bromix Wrote:
(2015-06-12, 09:50)Razze Wrote: So is this blocked by anything or whats the plan here?

I don't know...I don't get further feedback Sad Maybe I have to contact some specific people of KODI to decide how to proceed.

I would love to do more with this. At least we have to do more planing and testing...but I think KODI could benefit with this simple/slim addon like this one.

Yes, and if it helps you with the youtube plugin and tolriq with yatse then there will be others that can benefit.
Reply
#38
It's a good POC and it would be a great feature to have in kodi, but IMO it is something that should be done in core. Using an addon for it sort of half-solve the problem. Urls are still coupled to a specific addon, and if you change it you have the same problem as before: you are stuck with urls that no one can handle. (I see you *already* change it since posting this thread lol)

There's a lot integration you just cannot do (e.g finding addons that can handle a certain url). And with the current way of registering handlers (via files) you'll hit major performance problems very fast.
Reply
#39
(2015-06-13, 11:23)takoi Wrote: It's a good POC and it would be a great feature to have in kodi, but IMO it is something that should be done in core. Using an addon for it sort of half-solve the problem. Urls are still coupled to a specific addon, and if you change it you have the same problem as before: you are stuck with urls that no one can handle. (I see you *already* change it since posting this thread lol)

There's a lot integration you just cannot do (e.g finding addons that can handle a certain url). And with the current way of registering handlers (via files) you'll hit major performance problems very fast.
You have missed something. If this addon is a 'base' addon like the version check addon or the scrappers, everything is fine. If we don't use an addon for this we loose also the advantage of updating this addon if a bug was found. Try that with a core implementation - you would need to update KODI completely.

After that each developer is responsible for his own addon to register an URI via regular expression. uri2addon needs no update after that for new addons. It's a factory pattern.

Simple explained:
uri2addon asks each addon if it's supporting a given uri...if one addon says it's supporting an uri, uri2addon calls the corresponding addon with the uri and that addon itself has to parse and process the uri.

That's how operating system work for registered uri schemes or file extensions. Something KODI is missing in my opinion.
Reply
#40
(2015-06-13, 11:31)bromix Wrote:
(2015-06-13, 11:23)takoi Wrote: It's a good POC and it would be a great feature to have in kodi, but IMO it is something that should be done in core. Using an addon for it sort of half-solve the problem. Urls are still coupled to a specific addon, and if you change it you have the same problem as before: you are stuck with urls that no one can handle. (I see you *already* change it since posting this thread lol)

There's a lot integration you just cannot do (e.g finding addons that can handle a certain url). And with the current way of registering handlers (via files) you'll hit major performance problems very fast.
You have missed something. If this addon is a 'base' addon like the version check addon or the scrappers, everything is fine. If we don't use an addon for this we loose also the advantage of updating this addon if a bug was found. Try that with a core implementation - you would need to update KODI completely.

After that each developer is responsible for his own addon to register an URI via regular expression. uri2addon needs no update after that for new addons. It's a factory pattern.
No, I understand what it is. And I think basically the same should be added to the core addon system, instead of an addon system inside the addon system. Ofc that won't let you make updates as fast, but that you can say about every feature..
Reply
#41
As a PM viewpoint features are for major releases (upgrades) and not updates which provide somehow bugfixes.
Reply
#42
(2015-06-13, 11:31)bromix Wrote: You have missed something. If this addon is a 'base' addon like the version check addon or the scrappers, everything is fine. If we don't use an addon for this we loose also the advantage of updating this addon if a bug was found. Try that with a core implementation - you would need to update KODI completely.

After that each developer is responsible for his own addon to register an URI via regular expression. uri2addon needs no update after that for new addons. It's a factory pattern.

Simple explained:
uri2addon asks each addon if it's supporting a given uri...if one addon says it's supporting an uri, uri2addon calls the corresponding addon with the uri and that addon itself has to parse and process the uri.

That's how operating system work for registered uri schemes or file extensions. Something KODI is missing in my opinion.

The resolving part is easy. But this needs to be integrated into the repository-system. A plugin needs to register its regular expressions in addon.xml and these expressions need to be in the repositories addons.xml so that it really gets a benefit.
My GitHub. My Add-ons:
Image
Reply
#43
(2015-06-13, 12:13)sphere Wrote:
(2015-06-13, 11:31)bromix Wrote: You have missed something. If this addon is a 'base' addon like the version check addon or the scrappers, everything is fine. If we don't use an addon for this we loose also the advantage of updating this addon if a bug was found. Try that with a core implementation - you would need to update KODI completely.

After that each developer is responsible for his own addon to register an URI via regular expression. uri2addon needs no update after that for new addons. It's a factory pattern.

Simple explained:
uri2addon asks each addon if it's supporting a given uri...if one addon says it's supporting an uri, uri2addon calls the corresponding addon with the uri and that addon itself has to parse and process the uri.

That's how operating system work for registered uri schemes or file extensions. Something KODI is missing in my opinion.

The resolving part is easy. But this needs to be integrated into the repository-system. A plugin needs to register its regular expressions in addon.xml and these expressions need to be in the repositories addons.xml so that it really gets a benefit.
I agree totally with the last part (I think that's what you already posted in your thread of wishes) - love to see that. But I can't quite follow what you mean by 'repository-system'?

What can I do to push this further?
Reply
#44
As a reminder lot's of things are not in Kodi or XBMC because solution proposed where not perfect and no one have better solution but nothing was chosen over something that works and fill a need.

As long as the addon system permit this (and it's the case), I do not see why this should not be pushed because maybe one day someone in 3 years will do something at core level.
Reply
#45
(2015-06-13, 12:52)bromix Wrote:
(2015-06-13, 12:13)sphere Wrote:
(2015-06-13, 11:31)bromix Wrote: You have missed something. If this addon is a 'base' addon like the version check addon or the scrappers, everything is fine. If we don't use an addon for this we loose also the advantage of updating this addon if a bug was found. Try that with a core implementation - you would need to update KODI completely.

After that each developer is responsible for his own addon to register an URI via regular expression. uri2addon needs no update after that for new addons. It's a factory pattern.

Simple explained:
uri2addon asks each addon if it's supporting a given uri...if one addon says it's supporting an uri, uri2addon calls the corresponding addon with the uri and that addon itself has to parse and process the uri.

That's how operating system work for registered uri schemes or file extensions. Something KODI is missing in my opinion.

The resolving part is easy. But this needs to be integrated into the repository-system. A plugin needs to register its regular expressions in addon.xml and these expressions need to be in the repositories addons.xml so that it really gets a benefit.
I agree totally with the last part (I think that's what you already posted in your thread of wishes) - love to see that. But I can't quite follow what you mean by 'repository-system'?

What can I do to push this further?

He's saying the repository needs to be aware of it so you/we can show something like "Kodi has received a call from addon X and can't handle this, to resolve this please install one of these addons: [List of Addons that can handel this]"

(2015-06-13, 12:54)Tolriq Wrote: As a reminder lot's of things are not in Kodi or XBMC because solution proposed where not perfect and no one have better solution but nothing was chosen over something that works and fill a need.

As long as the addon system permit this (and it's the case), I do not see why this should not be pushed because maybe one day someone in 3 years will do something at core level.

This.
Reply

Logout Mark Read Team Forum Stats Members Help
uri2addon1