2024-03-10, 01:00
Kittmaster, much appreciated your efforts to resurrect Madnox!
On the task at hand, maybe a solid base would be to make sure that *arr app stack naming conventions translates well to flags shown in Kodi? Everybody is free to name their files as they see fit, but if one wants to stay sane, *arr apps conventions (and TRaSH Guides) should be the common denominator. Just my two cents. Things have evolved in the last few years, and the flag logic may be different now than when Madnox was originally built. It's somewhat telling that the flags collection when it comes to the 'videocodec' folder is a combo of media sources, containers, codecs, and so on, further confusing the issue.
From the top of my head there are three cases, where the logic needs to be re-evaluated:
- the result is plain wrong -> i.e. WEBDL-2160p gets a UltraHD Bluray flag, probably based on resolution alone, but that is incorrect.
- currently if the skin fails to detect the source (WEBDL, Bluray, UltraHD Bluray, DVD, etc) it will shows the codec instead. These things - source, resolution, codec - should be separated and not substituted one for the other; maybe more like "show it if it exists/it's detected; if not - not"
- there are... more complex tokens to be evaluated. For example "Remux-2160p" should always trigger the UltraHD Bluray source flag and the 4kRemux resolution flag.
On the task at hand, maybe a solid base would be to make sure that *arr app stack naming conventions translates well to flags shown in Kodi? Everybody is free to name their files as they see fit, but if one wants to stay sane, *arr apps conventions (and TRaSH Guides) should be the common denominator. Just my two cents. Things have evolved in the last few years, and the flag logic may be different now than when Madnox was originally built. It's somewhat telling that the flags collection when it comes to the 'videocodec' folder is a combo of media sources, containers, codecs, and so on, further confusing the issue.
From the top of my head there are three cases, where the logic needs to be re-evaluated:
- the result is plain wrong -> i.e. WEBDL-2160p gets a UltraHD Bluray flag, probably based on resolution alone, but that is incorrect.
- currently if the skin fails to detect the source (WEBDL, Bluray, UltraHD Bluray, DVD, etc) it will shows the codec instead. These things - source, resolution, codec - should be separated and not substituted one for the other; maybe more like "show it if it exists/it's detected; if not - not"
- there are... more complex tokens to be evaluated. For example "Remux-2160p" should always trigger the UltraHD Bluray source flag and the 4kRemux resolution flag.