[Blurayx]

Feature Request:

Put it in the Kodi repo so I can keep my nVidia Shield automatically updated at all times.

Soon, soon. I promise!
I've got to go through and do a clean up of all the unused textures and other crap.

This one made me laugh out loud when I saw it

jurialmunkey, You have a great sense of humour!!!

[jurialmunkey]

@Blurayx - Do you have this option turned off per chance?

[Blurayx]

@Blurayx - Do you have this option turned off per chance?

It was turned off, working now


Thanks

[foghat]

Noooo! Do not remove. It works fine for me. Displays 0 hr xx minutes for items less than an hour.

Also, a bit of a navigation bug, I think:

1. From home screen open sideblade and select to 'Settings'
2. Open Settings side blade and navigate to 'System' (or any item after 'Interface') and select.
3. Notice System items are displayed.
4. While still on System, back out to Home screen.
5. Select settings again.

Expected results:
1. System is selected and 'System' menu items are displayed.

Actual Results
1. System is selected (once sideblade is opened), but 'Interface' menu items are displayed.

And, feature request:

Instead of a 'full' loader, can you show (or provide an option to show) the fan art after a movie/tv show has been selected to play?

The Plex for Kodi addon does this and it is very nice - it also shows a minimal loader in lower right corner. This is nice when NAS drives are waking up and it a takes a 4, 5, or 6+ seconds for the movie/show to start. Once my nas is awake, playback is almost instant, so not really a need in those cases.

Okay I will leave it in. Maybe its just the official repo version of skin helper that has the problem and not the beta version.

What is the "Action" set for your settings menu item? It is supposed to go to interface settings, but it should override the indicator position when doing so. Anyway, I agree that the settings should "remember" where you were and take you back, so I've changed it to do that.

I'm not sure if I understand what you mean by the busy indicator. Are you saying it would show the fanart full screen with a busy indicator in the corner? I don't think there is any way for me to check whether someone is trying to play something or do something else. The Busy indicator is a general use dialog. I could add the fanart, but this would do it everywhere...

Thanks for leaving in.

I guess a non-issue now that you have updated (works great, thx!), but with the sideblade closed 'action' item highlighted was 'Interface', but as soon as I open the side blade, it would change to 'System', but the 'interface' items were still showing.

By busy indicator, I just mean the loading indicator that is currently displayed after selecting a movie to play - while the movie is loading. If you take the scenario where one had minimal busy loaders turned on, currently when you start a movie, you see whatever screen you started the movie from plus the minimal loader. The plex for kodi app instead displays the fan art for the movie/tv show being started, plus the minimal loader.

[jurialmunkey]

I guess a non-issue now that you have updated (works great, thx!), but with the sideblade closed 'action' item highlighted was 'Interface', but as soon as I open the side blade, it would change to 'System', but the 'interface' items were still showing.

By busy indicator, I just mean the loading indicator that is currently displayed after selecting a movie to play - while the movie is loading. If you take the scenario where one had minimal busy loaders turned on, currently when you start a movie, you see whatever screen you started the movie from plus the minimal loader. The plex for kodi app instead displays the fan art for the movie/tv show being started, plus the minimal loader.

Ah that makes more sense with the settings. I thought you were saying that small indicator "light" next to the icon when the side blade was closed was showing the wrong position and I couldn't figure out how that would happen. Makes more sense knowing that you mean when opening the sideblade the focus was in the wrong position. I just added an additional condition here to make sure it will always focus the current settings item.

Yeah I don't think the busy indicator thing is possible. I agree it would be a really nice feature, but I don't know of any way to determine when the busy indicator is showing because something is about to play versus when it shows for other reasons (e.g. loading the content of a list in an addon or opening up extended info).

[foghat]

I guess a non-issue now that you have updated (works great, thx!), but with the sideblade closed 'action' item highlighted was 'Interface', but as soon as I open the side blade, it would change to 'System', but the 'interface' items were still showing.

By busy indicator, I just mean the loading indicator that is currently displayed after selecting a movie to play - while the movie is loading. If you take the scenario where one had minimal busy loaders turned on, currently when you start a movie, you see whatever screen you started the movie from plus the minimal loader. The plex for kodi app instead displays the fan art for the movie/tv show being started, plus the minimal loader.

Ah that makes more sense with the settings. I thought you were saying that small indicator "light" next to the icon when the side blade was closed was showing the wrong position and I couldn't figure out how that would happen. Makes more sense knowing that you mean when opening the sideblade the focus was in the wrong position. I just added an additional condition here to make sure it will always focus the current settings item.

Yeah I don't think the busy indicator thing is possible. I agree it would be a really nice feature, but I don't know of any way to determine when the busy indicator is showing because something is about to play versus when it shows for other reasons (e.g. loading the content of a list in an addon or opening up extended info).

I'm not suggesting you doing anything different with the busy indicator. It will currently show when movie has been selected for play, but is waiting for the NAS to wake up (or whatever the may be causing the delay in playing). Just asking if it is possible to show the fan art while one is waiting with any loaders displaying on top of the fan art..

[jurialmunkey]

@foghat - You misunderstand me. The skin has no way to know whether the busy indicator is showing because something is going to play or because something like the youtube addon is attempting to load the results of a search. Kodi basically just sends a command to say "make DialogBusy.xml visible" and that's it - it doesn't say why it is making the busy dialog visible. If I changed it, then it would show fanart if you were trying to do a search in youtube or anything like that, which doesn't make much sense to me.

[foghat]

@foghat - You misunderstand me. The skin has no way to know whether the busy indicator is showing because something is going to play or because something like the youtube addon is attempting to load the results of a search. Kodi basically just sends a command to say "make DialogBusy.xml visible" and that's it - it doesn't say why it is making the busy dialog visible. If I changed it, then it would show fanart if you were trying to do a search in youtube or anything like that, which doesn't make much sense to me.

I wonder how the Plex for Kodi add-on does it.

Aren't the busy indicators separate from the action being performed? Can't showing the fan art be tied to the action vs. the indicator? Since you know (I assume) if someone is selecting the 'play' action, can that not be what triggers showing the fan art up until the point the movie plays? And wouldn't the busy indicator just automatically show as required? Showing fan art, would probably only be applicable when using minimal loaders?

[jurialmunkey]

I wonder how the Plex for Kodi add-on does it.

Aren't the busy indicators separate from the action being performed? Can't showing the fan art be tied to the action vs. the indicator? Since you know (I assume) if someone is selecting the 'play' action, can that not be what triggers showing the fan art up until the point the movie plays? And wouldn't the busy indicator just automatically show as required? Showing fan art, would probably only be applicable when using minimal loaders?

The addon probably calls a custom dialog when the play action is selected.

Skins don't have control over actions like that. Skins can define onclick / oninfo / onback actions BUT ONLY when these aren't already defined by Kodi. When it comes to a container with playable content then Kodi overrides the onclick action with whatever the user has chosen in the media settings for default select action (i.e. choose; play; resume; or show info). So what happens is that when a user clicks on something playable, if the default action is play then Kodi attempts to start playing the content. If the content needs to load then Kodi will make DialogBusy.xml visible. If the content is from an addon then Kodi will tell the addon to play the content -- this is when the plex addon would call its own custom busy dialog.

Its not like the skin receives the actions/clicks and then tells Kodi what to do. It is the other way around. Kodi receives the clicks and then decides what properties to set and what windows/dialogs to make visible etc. Only in cases where it doesn't have something specifically defined to do for that action will it check to see if the skin has defined an action.

Its the same reason why you will notice that when playing music/video, pressing back whilst on a widget will open the visualisation/video rather than return to the side menu. In this scenario the onback setfocus command that I have defined in the skin is overridden by Kodi with the fullscreen command.

All this is done to enforce that behaviours remain fairly consistent across skins and so that keymaps and user settings aren't overridden by skins.

[Edworld]

Jurialmunkey:

Could be self inflicting bug, but if I have a movie on pause and scroll my library I don't get a background on dialogvideoinfo

watch gallery

[jurialmunkey]

@Edworld - Do you have "Skin Settings > Background > Show video in background" enabled? If so, then it is intentional.

[jurialmunkey]

Colorbox advanced settings

Heads up for everyone that I've added an advanced settings dialog for colorbox.

This is intended to work with the most recent github version of colorbox which is currently waiting approval for official repo. The settings will still work with the current repo version, but a few wont do anything (desaturate effect wont work and blend control will do nothing as these are both new features).

This should give everyone the ability to fine tune effects how they want. Note that changing the image quality will also change the intensity of the effect due to a shift in resolution. For effects like blur I recommend using Quality at 8 (the lowest setting) as it will be the fastest and because the image is blurred it isn't possible to really tell much of a difference.

The image window should give real time updates so that you can preview your effect settings.

[Edworld]

@Edworld - Do you have "Skin Settings > Background > Show video in background" enabled? If so, then it is intentional.

Yes, didn't know what this option was for

[Blurayx]

Hi jurialmunkey,

Do you have a roadmap for an icon only option


Thanks

[jurialmunkey]

Do you have a roadmap for an icon only option

I was actually going to look at it today as I have some free time to dedicate to skinning.

I'm glad that you brought it up, as I'm wondering whether it should be icon only inside the library also (so the side menu for view options etc.)? Or would that be too confusing to know what is what?