[giaur]

Hi,

I'm trying to sync your latest version with Oepenlec for OrangePi and I'm getting error:

Code:

CMake Error at CMakeLists.txt:13 (find_package):
  By not providing "Findp8-platform.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "p8-platform", but CMake did not find one.

  Could not find a package configuration file provided by "p8-platform" with
  any of the following names:

    p8-platformConfig.cmake
    p8-platform-config.cmake

  Add the installation prefix of "p8-platform" to CMAKE_PREFIX_PATH or set
  "p8-platform_DIR" to a directory containing one of the above files.  If
  "p8-platform" provides a separate development package or SDK, be sure it
  has been installed.

If I use package version (commit) the same as it was by default inside package.mk, addon compiles but the same old version. Do you have any idea what's wrong? PLATFORM namespace renamed to P8-PLATFORM I guess, but I dont know how to solve it. Are your sources compatible with Kodi Jarvis and Openelec 7.0?

[AchimTuran]

If I use package version (commit) the same as it was by default inside package.mk, addon compiles but the same old version. Do you have any idea what's wrong? PLATFORM namespace renamed to P8-PLATFORM I guess, but I dont know how to solve it. Are your sources compatible with Kodi Jarvis and Openelec 7.0?

No, It's only for Krypton

[giaur]

Ok, I managed it to compile. I renamed back p8platform to platform. Then compiled against Jarvis sources and it works.

I must say - good work! Settings saving fixed. The only issue is that eq settings are not displayed if skin is not Confluence.

Btw - why Krypton only? Is this the reason why I was unable to compile? You could create Jarvis branch, Krypton is not usable at current stage, especially on Android

[AchimTuran]

Because lack of time. At first I like to fix all bugs and see if it works.

I already created a jarvis branch, but had not enpugh time to test it. Other reason is that I mainly use Krypton on my own. Also Jarvis 16.1 is released and you can only get latest version if you compile it on your own. We currently do not have a possibility to deploy addons independ on all platforms without our releases.

Yeah I know Android is still broken and the issues also occur if you disable AudioDSP. Currently Android does not have any dev that cares for this platform. In my view I would not stick to Android. Linux or Windows works a lot better.

[giaur]

From my tests, it (still) works on Jarvis. I was only forced to get rid of namespace platform changed to p8platform to compile it. I guess this was introduced on Krypton or my Kodi sources was outdated a bit (Jarvis 16.1). All my stuff is unofficial, openelec forked to run on Allwinner hardware

[BytEvil]

Hi, friends! Can`t compile adsp.biquad.filters with gcc 6.1.1 from AchimTuran/asplib github repo:

Code:

/HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp: In function 'float abs(float)':
/HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:27:29: error: 'float abs(float)' conflicts with a previous declaration
   inline float abs(float Val)
                             ^
In file included from /usr/include/c++/6.1.1/math.h:36:0,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:23:
/usr/include/c++/6.1.1/cmath:91:3: note: previous declaration 'constexpr float std::abs(float)'
   abs(float __x)
   ^~~
/HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp: In static member function 'static float CADSPHelpers::Convert_Value_TO_dB(float)':
/HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:444:32: error: call of overloaded 'abs(float&)' is ambiguous
   return 20.0f*log10f(abs(Scale));
                                ^
In file included from /usr/include/c++/6.1.1/cstdlib:75:0,
                 from /usr/include/c++/6.1.1/ext/string_conversions.h:41,
                 from /usr/include/c++/6.1.1/bits/basic_string.h:5402,
                 from /usr/include/c++/6.1.1/string:52,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.h:24,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:22:
/usr/include/stdlib.h:774:12: note: candidate: int abs(int)
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
            ^~~
In file included from /usr/include/c++/6.1.1/math.h:36:0,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:23:
/usr/include/c++/6.1.1/cmath:95:3: note: candidate: constexpr long double std::abs(long double)
   abs(long double __x)
   ^~~
/usr/include/c++/6.1.1/cmath:91:3: note: candidate: constexpr float std::abs(float)
   abs(float __x)
   ^~~
/usr/include/c++/6.1.1/cmath:85:3: note: candidate: constexpr double std::abs(double)
   abs(double __x)
   ^~~
In file included from /usr/include/c++/6.1.1/ext/string_conversions.h:41:0,
                 from /usr/include/c++/6.1.1/bits/basic_string.h:5402,
                 from /usr/include/c++/6.1.1/string:52,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.h:24,
                 from /HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:22:
/usr/include/c++/6.1.1/cstdlib:185:3: note: candidate: __int128 std::abs(__int128)
   abs(__GLIBCXX_TYPE_INT_N_0 __x) { return __x >= 0 ? __x : -__x; }
   ^~~
/usr/include/c++/6.1.1/cstdlib:180:3: note: candidate: long long int std::abs(long long int)
   abs(long long __x) { return __builtin_llabs (__x); }
   ^~~
/usr/include/c++/6.1.1/cstdlib:172:3: note: candidate: long int std::abs(long int)
   abs(long __i) { return __builtin_labs(__i); }
   ^~~
/HGST/krypton/kodi-adsp-biquad-filters-git/src/adsp.biquad.filters-b6001f74467820d5406c37a9d74d53148743c598/src/template/ADSPHelpers.cpp:27:16: note: candidate: float abs(float)
   inline float abs(float Val)
                ^~~
make[2]: *** [CMakeFiles/adsp.biquad.filters.dir/build.make:207: CMakeFiles/adsp.biquad.filters.dir/src/template/ADSPHelpers.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/adsp.biquad.filters.dir/all] Error 2
make: *** [Makefile:150: all] Error 2

[giaur]

Try to compile with gcc5 or sources need to he fixed

[AchimTuran]

Hi, friends! Can`t compile adsp.biquad.filters with gcc 6.1.1 from AchimTuran/asplib github repo:

Hi BytEvil,

this is a known problem and I received an PR for it, but I didn't receive any response. This PR breaks the Windows build, which is the reason why it was never merged.
Furthermore I use gcc 5 to build this addon and it is fine.

Until I use gcc 6, I will never try to build with it

But if you are able to create a patch that doesn't break other platforms. I will not be the show stopper to merge it.

[giaur]

This PR breaks the Windows build, which is the reason why it was never merged.

Have you tried preprocessor directives to get correct result on any platform? Something like this:

Code:

#ifdef __linux__
    //linux code goes here
#elif _WIN32
    // windows code goes here
#else

#endif

This stuff is compiler dependent though, so it can look different in your case - need to read compiler docs. But I believe Kodi already uses that for multiplatform compilation handling, so you can do the same

[adit]

hi @giaur, can I have your compiled version of biquad filter addon? I'm also stuck with Jarvis on wetek play. Thanks!

[AchimTuran]

hi @giaur, can I have your compiled version of biquad filter addon? I'm also stuck with Jarvis on wetek play. Thanks!

Btw does anybody know if there is any Android build? Some repository for Android?

Should this be in kodi at all? Should it be in the DIY audio forum?

http://www.diyaudio.com/forums/

Thanks for the input. I am using a similat approach but let's create a new thread where we can discuss this without taking away focus from wisler's great work. I will create one tonight if you don't beat me to it. I'm just not sure which forum to post it in.

Guys, which part did you miss? This is a development sub forum! It's for discussing issues, idea, features ...
But not for exchanging private communication stuff like:
Can you give addon A, please?
You're wasting my time, because on every post you create I receive an e-mail. This is really helpful to keep on track on issues and ideas that occur in the community. But it's wasting time for to read your posts, which are not related to development...

EDIT:
Or do you wanna see stuff like:
I have an ION 1. Is there some one who will buy it?
User A asks dev B: can you build addon XYZ for me?

I guess NO!

[BytEvil]

Hi, friends! Can`t compile adsp.biquad.filters with gcc 6.1.1 from AchimTuran/asplib github repo:

Hi BytEvil,

this is a known problem and I received an PR for it, but I didn't receive any response. This PR breaks the Windows build, which is the reason why it was never merged.
Furthermore I use gcc 5 to build this addon and it is fine.

Until I use gcc 6, I will never try to build with it

But if you are able to create a patch that doesn't break other platforms. I will not be the show stopper to merge it.

Thanks, wisler for help! I have compile addon for yourself wit this PR

Unfortunately I am not a programmer

[giaur]

hi @giaur, can I have your compiled version of biquad filter addon? I'm also stuck with Jarvis on wetek play. Thanks!

My version is for OrangePI, it won't run on wetek

[axbmcuser]

Hey,

using a simple 5.1 HDMI LPCM KODI setup (No Passthrough) with LibreELEC 8 - i can't save the EQ-settings. The EQ does work great - you can hear the changes you make on the bands - but if i click "OK" to confirm and save the settings, KODI crashes with this log:

Code:

18:38:11 T:140079959812160   DEBUG: OnKey: return (0xf00d) pressed, action is Select
18:38:11 T:140079959812160   DEBUG: ------ Window Init (/storage/.kodi/addons/adsp.biquad.filters/resources/skins/skin.confluence/720p/DialogParametricEQ.xml) ------
18:38:11 T:140079959812160    INFO: Loading skin file: /storage/.kodi/addons/adsp.biquad.filters/resources/skins/skin.confluence/720p/DialogParametricEQ.xml, load type: LOAD_ON_GUI_INIT
18:38:11 T:140079959812160   DEBUG: CGUIMediaWindow::GetDirectory ()
18:38:11 T:140079959812160   DEBUG:   ParentPath = []
18:38:11 T:140079959812160   DEBUG: Keyboard: scancode: 0x74, sym: 0x0112, unicode: 0x0000, modifier: 0x0
18:38:12 T:140079959812160   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x0000, modifier: 0x0
18:38:26 T:140079959812160   DEBUG: Keyboard: scancode: 0x6f, sym: 0x0111, unicode: 0x0000, modifier: 0x0
18:38:26 T:140079959812160   DEBUG: OnKey: up (0xf080) pressed, action is Up
18:38:26 T:140079959812160   DEBUG: Keyboard: scancode: 0x6f, sym: 0x0111, unicode: 0x0000, modifier: 0x0
18:38:26 T:140079959812160   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x000d, modifier: 0x0
18:38:26 T:140079959812160   DEBUG: OnKey: return (0xf00d) pressed, action is Select
18:38:26 T:140079959812160   ERROR: ActiveAE DSP - Unhandled exception caught while trying to call 'CallMenuHook' on add-on 'Biquad Filters', becomes diabled. Please contact the developer of this add-on: Achim Turan, Team KODI
18:38:26 T:140079959812160   DEBUG: ActiveAE DSP - Destroy - destroying audio dsp add-on 'Biquad Filters'
18:38:26 T:140079959812160   DEBUG: SECTION:UnloadDll(/storage/.kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so.0.0.2)

Additional Info:

There is no "parametricEQSettings.xml" within the folder "userdata\addon_data\adsp.biquad.filters". I tried creating an empty file. Does't work. Same crash.


Thanks!

[AchimTuran]

Code:

...
18:38:26 T:140079959812160   DEBUG: SECTION:UnloadDll(/storage/.kodi/addons/adsp.biquad.filters/adsp.biquad.filters.so.0.0.2)
...

You are using an old version. Latest development version is 0.0.3.