Login at Kodi Home

Angelscry · 2012-09-17, 02:23

(2012-09-16, 23:26)jingai Wrote: I'll work on integrating these views into the stock Metropolis this week. Thanks for the contributions!

Thank you very much for your wonderful skin. Oupsss... forget to indicate that I have also modified the /language/English/strings.xml file for views name :

Code:
    ...

    <string id="31461">Game Covers (Tall)</string> 

    <string id="31462">Game Covers (Square)</string> 

    <string id="31463">Game Covers (Wide)</string> 

    ...

jingai · 2012-09-20, 00:04

Working on integrating this now, but.. am I missing something, or is Viewtype_Games_PosterAndFanart.xml pretty much a duplicate of Viewtype_Games_Tall.xml?

jingai · 2012-09-20, 00:44

I'm going to limit these views to only the Advanced Launcher addon to minimize any interference with others -- for instance, my iPhoto addon sets the content type to Pictures and Metropolis displays the EXIF information where the plot/description would normally be.

So, rather than test all available addons, this seems the easiest route. Besides, I think only Advanced Launcher can really benefit from these views anyway, yes? If any other addons can use these views we can address them on a case-by-case basis.

Angelscry · (This post was last modified: 2012-09-20, 01:54 by Angelscry.)

(2012-09-20, 00:04)jingai Wrote: Working on integrating this now, but.. am I missing something, or is Viewtype_Games_PosterAndFanart.xml pretty much a duplicate of Viewtype_Games_Tall.xml?

Yes its pretty much the same view than Viewtype_Games_Tall.xml with some minor modification (view name, and information display). I have made a separate view just to be sure to not brake anything with the original views of the skin. I think it will be possible to merge the 2 views into the same file using conditionnal parameter a the visible tag.

(2012-09-20, 00:44)jingai Wrote: I'm going to limit these views to only the Advanced Launcher addon to minimize any interference with others -- for instance, my iPhoto addon sets the content type to Pictures and Metropolis displays the EXIF information where the plot/description would normally be.

So, rather than test all available addons, this seems the easiest route. Besides, I think only Advanced Launcher can really benefit from these views anyway, yes? If any other addons can use these views we can address them on a case-by-case basis.

I think that any program addon that have, for example, fanart, may benefit of these views. But must be better to limit this view actually to Advanced Launcher, then is someone want this view ported to another addon you will jsut have to modifiy these views.

jingai · (This post was last modified: 2012-09-20, 02:20 by jingai.)

I'll make it specific to your addon for now. If any other addon authors find the views useful, we can add them then. It's just much easier to ensure that this modification doesn't have other ramifications for other addons if I do it this way.

(2012-09-20, 01:47)Angelscry Wrote: I think that any program addon that have, for example, fanart, may benefit of these views.

The standard Fanart view is already available for addons. The new views seem to be there to address specific aspect ratios for the thumbnails for game box art. Since XBMC has no in-built support for launching applications and currently -- as far as I know -- your addon is the only thing that provides such support, it seems reasonable to limit these views to Advanced Launcher only.

jingai · 2012-09-23, 17:00

These changes have been pushed into the official repository and will be released in Metropolis 2.0.0rc3.

Thanks again Angelscry, and sorry it took me so long to get around to this -- life's been hectic this week.

Angelscry · 2012-09-23, 18:48

(2012-09-23, 17:00)jingai Wrote: These changes have been pushed into the official repository and will be released in Metropolis 2.0.0rc3.

Thanks again Angelscry, and sorry it took me so long to get around to this -- life's been hectic this week.

No problem. It always better to take time to make things good. Wink

woomba · 2012-10-31, 22:39

Thanks for your great work guys!
I decided to create a view based on Viewtype_Panel_Square.xml. Here is a preview:

Still need to do some tweaking

jingai · 2012-10-31, 23:18

Certainly feel free to share it when you're done Smile

woomba · 2012-11-01, 01:56

No worries. I'm more than happy to share it.

woomba · 2012-11-01, 11:53

Just like Angelscry I modified includes.xml (953)

Code:
    ...

    <include file="Viewtype_Games_Square.xml" />        <!-- 951 -->

    <include file="Viewtype_Games_Wide.xml" />        <!-- 952 -->

    <include file="Viewtype_Games_Panel_Square.xml" />        <!-- 953 -->

    <include file="Viewtype_Landscape.xml" />        <!-- 52  -->

    <include file="Viewtype_List.xml" />            <!-- 503 -->

    ...

MyPrograms.xml:

Code:
<window id="1">

    <views>55,503,58,950,951,952,953</views>

        ...

        </control>

        <include>Viewtype_Files</include>        <!-- 55 -->

        <include>Viewtype_Gallery_Square</include>    <!-- 58 -->

        <include>Viewtype_List</include>        <!-- 503 -->

        <include>Viewtype_Games_Tall</include>        <!-- 950 -->

        <include>Viewtype_Games_Square</include>    <!-- 951 -->

        <include>Viewtype_Games_Wide</include>        <!-- 952 -->

        <include>Viewtype_Games_Panel_Square</include>        <!-- 953 -->

        <include>Global_ContextFilter</include>

        <include>Global_AddonInfo</include>

        ...

strings.xml:

Code:
    ...

    <string id="31469">Appearance</string>

    <string id="31470">Games Panel Square</string>

    <!-- PVR Resources -->

    ...

And the actual view Viewtype_Games_Panel_Square.xml:
http://pastebin.com/q9mHf9kU

You better have a look through it. It's my first view so I'm not sure if I did everything right.

woomba · (This post was last modified: 2012-11-01, 16:12 by woomba.)

These two are definitely not perfect but I thought I share them anyway:

Wide

includes.xml (954)

Code:
    ...

    <include file="Viewtype_Games_Wide.xml" />        <!-- 952 -->

    <include file="Viewtype_Games_Panel_Square.xml" />        <!-- 953 -->

    <include file="Viewtype_Games_Panel_Wide.xml" />        <!-- 954 -->

    <include file="Viewtype_Landscape.xml" />        <!-- 52  -->

    ...

MyPrograms.xml:

Code:
<window id="1">

    <views>55,503,58,950,951,952,953,954</views>

        ...

        </control>

        <include>Viewtype_Files</include>        <!-- 55 -->

        <include>Viewtype_Gallery_Square</include>    <!-- 58 -->

        <include>Viewtype_List</include>        <!-- 503 -->

        <include>Viewtype_Games_Tall</include>        <!-- 950 -->

        <include>Viewtype_Games_Square</include>    <!-- 951 -->

        <include>Viewtype_Games_Wide</include>        <!-- 952 -->

        <include>Viewtype_Games_Panel_Square</include>        <!-- 953 -->

        <include>Viewtype_Games_Panel_Wide</include>        <!-- 954 -->

        <include>Global_ContextFilter</include>

        <include>Global_AddonInfo</include>

        ...

strings.xml:

Code:
    ...

    <string id="31469">Appearance</string>

    <string id="31470">Games Panel Square</string>

    <string id="31471">Games Panel Wide</string>

    <!-- PVR Resources -->

    ...

Viewtype_Games_Panel_Wide.xml:
http://pastebin.com/Sfa9htEN

And the other one:

Tall

includes.xml (955)

Code:
    ...

    <include file="Viewtype_Games_Wide.xml" />        <!-- 952 -->

    <include file="Viewtype_Games_Panel_Square.xml" />        <!-- 953 -->

    <include file="Viewtype_Games_Panel_Wide.xml" />        <!-- 954 -->

    <include file="Viewtype_Games_Panel_Tall.xml" />        <!-- 955 -->

    <include file="Viewtype_Landscape.xml" />        <!-- 52  -->

    ...

MyPrograms.xml:

Code:
<window id="1">

    <views>55,503,58,950,951,952,953,954,955</views>

        ...

        </control>

        <include>Viewtype_Files</include>        <!-- 55 -->

        <include>Viewtype_Gallery_Square</include>    <!-- 58 -->

        <include>Viewtype_List</include>        <!-- 503 -->

        <include>Viewtype_Games_Tall</include>        <!-- 950 -->

        <include>Viewtype_Games_Square</include>    <!-- 951 -->

        <include>Viewtype_Games_Wide</include>        <!-- 952 -->

        <include>Viewtype_Games_Panel_Square</include>        <!-- 953 -->

        <include>Viewtype_Games_Panel_Wide</include>        <!-- 954 -->

        <include>Viewtype_Games_Panel_Tall</include>        <!-- 955 -->

        <include>Global_ContextFilter</include>

        <include>Global_AddonInfo</include>

        ...

strings.xml:

Code:
    ...

    <string id="31469">Appearance</string>

    <string id="31470">Games Panel Square</string>

    <string id="31471">Games Panel Wide</string>

    <string id="31472">Games Panel Tall</string>

    <!-- PVR Resources -->

    ...

Viewtype_Games_Panel_Wide.xml:
http://pastebin.com/eJ5b0aBV

jingai · 2012-11-01, 17:01

Metropolis 2.0.0 is in feature freeze now, so I'll go over these after release and push them up then. Thanks for the contribution!

jingai · 2012-11-11, 23:03

I've decided I'm going to just alter Panel Square to work with all addons. It will be up shortly.

jingai · 2012-11-17, 00:35

FYI, I have it on my list to make generic Panel Tall and Panel Wide views (as well as some others for Gallery). Will get to it over the holidays some time I'm sure.